回复:pg_rewind fails with in-place tablespace

2023-07-31 Thread Rui Zhao
Sorry for the delay in responding to this matter as I have been waiting for 
another similar subject to approved by a moderator.
Upon review, I am satisfied with the proposed solution and believe that 
checking absolute path is better than hard coding with "pg_tblspc/". I think we 
have successfully resolved this issue in the pg_rewind case.
However, I would like to bring your attention to another issue: pg_upgrade 
fails with in-place tablespace. Another issue is still waiting for approved. I 
have tested all the tools in src/bin with in-place tablespace, and I believe 
this is the final issue.
Thank you for your understanding and assistance.
Best regard,
Rui Zhao
--
发件人:Michael Paquier 
发送时间:2023年7月31日(星期一) 06:49
收件人:赵锐(惜元) 
抄 送:pgsql-hackers ; Thomas Munro 

主 题:Re: pg_rewind fails with in-place tablespace
On Fri, Jul 28, 2023 at 04:54:56PM +0900, Michael Paquier wrote:
> I am finishing with the attached. Thoughts?
Applied this one as bf22792 on HEAD, without a backpatch as in-place
tablespaces are around for developers. If there are opinions in favor
of a backpatch, feel free of course.
--
Michael


Re: 回复:pg_rewind fails with in-place tablespace

2023-07-30 Thread Michael Paquier
On Mon, Jul 31, 2023 at 10:07:44AM +0800, Rui Zhao wrote:
> However, I would like to bring your attention to another issue:
> pg_upgrade fails with in-place tablespace. Another issue is still
> waiting for approved. I have tested all the tools in src/bin with
> in-place tablespace, and I believe this is the final issue. 

No problem.  Please feel free to start a new thread about that, I'm
okay to look at what you would like to propose.  Adding a test in
002_pg_upgrade.pl where the pg_upgrade runs happen would be a good
thing to have, I guess.
--
Michael


signature.asc
Description: PGP signature