Re: 2018-03 Commitfest Summary (Andres #3)

[Andres Freund]

On 2018-03-02 12:22:15 +0300, Ildus Kurbangaliev wrote:
> On Thu, 1 Mar 2018 20:34:11 -0800
> Andres Freund  wrote:
> > - Custom compression methods
> > 
> >   RFC. While marked as ready for committer, I think this is mostly
> >   because some high level design input is needed.  It's huge, and so
> > far only seems to add already existing compression support.
> > 
> >   Not seing this for v11.

> This patch is not about adding new compression algorithms, it's about
> adding a new access method type which could be used for new compression
> methods.

Yes, but that's not a contradiction to what I wrote? Currently we don't
gain any practical improvements for users with this patch, no?  It'd
"just" allow extension authors to provide benefit.

Greetings,

Andres Freund

Re: 2018-03 Commitfest Summary (Andres #3)

[Alexander Korotkov]

On Fri, Mar 2, 2018 at 7:34 AM, Andres Freund  wrote:

> - Pluggable storage API
>
>   NR.  This unfortunately still seems far off. It's possible though that
>   we can split off some smaller pieces of work and get them committed?
>

I'm working on reordering patchset so that refactoring patches go before
API introduction.  I'm planning to publish patchset this weekend.
Hopefully, some peices of patchset could be committed.

--
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Re: 2018-03 Commitfest Summary (Andres #3)

[Ildus Kurbangaliev]

On Thu, 1 Mar 2018 20:34:11 -0800
Andres Freund  wrote:


> 
> - Custom compression methods
> 
>   RFC. While marked as ready for committer, I think this is mostly
>   because some high level design input is needed.  It's huge, and so
> far only seems to add already existing compression support.
> 
>   Not seing this for v11.
> 

Hi,

This patch is not about adding new compression algorithms, it's about
adding a new access method type which could be used for new compression
methods.

It's quite big but the large part of it are changes in regression tests
(becauses it adds new field in \d+) and new tests.

-- 
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Re: 2018-03 Commitfest Summary (Andres #3)

[Amit Langote]

Hi Andres.

On 2018/03/02 13:34, Andres Freund wrote:
> - reorganize partitioning code
> 
>   NR. Created recently, but split off an older patch.
> 
>   Seems like a generally reasonable idea. Wonder if it conflicts with
>   some other partition related patches?

It actually does.  There are at least a few other functionality patches
that touch same files and it may not be a good idea for them to have to
worry about conflicts with this.

I gave up on rebasing this patch yesterday as I couldn't finish it in 5
minutes, but maybe I will try later this month.  Gotta focus on the faster
pruning stuff for now...

> - Add support for tuple routing to foreign partitions
> 
>   NR. Patch is still evolving, the latest versions haven't gotten a lot
>   of review.
> 
>   It seems a bit ambitious to try to get this into v11.

I've looked at this a bit yesterday and plan to do review it sometime this
month.  Having skimmed it, the new FDW API added by the patch looks well
documented and seems to do the very specific job assigned to it well
enough, but then again I haven't done a full review yet.

Thanks,
Amit

Re: 2018-03 Commitfest Summary (Andres #3)

[Andres Freund]

On 2018-03-01 14:45:15 -0800, Andres Freund wrote:
> Second round.

And last round. [ work ]. Scratch that. There'll be one more after this
;)


- Subscription code improvements

  WOA.  This is some minor cleanup stuff afaics. Don't think it's
  terribly release bound.


- Bootstrap data conversion

  NR.

  Not quite sure if it's realistic to do something about for v11. If so,
  it'd probably reasonable to merge this *after* the formal code freeze,
  to avoid breaking ~all pending patches.


- reorganize partitioning code

  NR. Created recently, but split off an older patch.

  Seems like a generally reasonable idea. Wonder if it conflicts with
  some other partition related patches?


- get rid of StdRdOptions, use individual binary reloptions
  representation for each relation kind instead

  NR. Created days ago, split off another patch.

  I'm unclear why this is particularly desirable, but I might just be
  missing something.


- Rewrite of pg_dump TAP tests

  WOA. Recently created.

  As it's "just" test infrastructure and makes things easier to
  understand, I think it makes sense to push this ASAP.


- remove pg_class.relhaspkey

  NR. Recentrly created.

  Minor cleanup, might break a few clients. Probably should do it, don't
  think it matters whether it's v11 or v12.


- pg_proc.prokind column

  RFC. Cleans up some sql procedure stuff.

  Obviously should get in.


- Unlogged tables re-initialization tests

  NR.

  Some questions about windows stuff that probably can easily be
  resolved within CF.


- fixing more format truncation issues

  NR.  Warnings cleanup / addition by configure.


- Make async slave to wait for lsn to be replayed

  WOA.

  There's been some design discussion a month ago, but no other
  activity. Given that this seems unlikely to be a candidate for
  v11. Should RWF.


- Logical decoding of two-phase transactions

  NR. Old thread, but lots of churn.

  I personally don't see how all of this patch series could get into
  v11. There's a bunch of fairly finnicky details here.


- Replication status in logical replication

  RFC.  Pretty small patch, Simon has claimed it.


- Restricting maximum keep segments by repslots

  NR.  Submitted a good while ago.

  I've some doubts about the design here, and there's certainly not been
  a lot of low level review.  Would need some reviewer focus to make it
  possible to get into v11.


- Exclude unlogged tables from base backups

  RFC, for quite a while.

  I still have some correctness doubts around this, will try to have a
  look.


- logical_work_mem limit for reorderbuffer
- logical streaming for large in-progress transactions

  NR.  I'm not quite sure why these in this CF, inquired on thread.


- TRUNCATE behavior when session_replication_role = replica

  RFC. Small patch, RFC since last CF. Should be merged.


- Logical decoding of TRUNCATE

  RFC.

  I think this isn't quite pretty, but I think that's largely because
  the DML vs DDL separation itself isn't really clean.


- Changing WAL Header to reduce contention during ReserveXLogInsertLocation()

  NR.

  We don't really seem to have agreement on what precisely to do, and
  there's no patch implementing the latest state of what's being
  discussed.  I'm not really certain why this in this CF.


- Checksums for slru files

  WOA.  Patch clearly not close to commit, and there's not much
  activity. Proposed to mark as RWF.


- handling of heap rewrites in logical decoding

  NR. Sent 2018-02-24, CFed 2018-02-28.

  This is an important feature, but I think it's going to have to wait
  for v12.


- Exclude temp relations from base backup

  NR. Sent 2018-02-28.

  But it's essentially a trivial extension from the other "exclude"
  patch above.  If we merge the above, we should just merge this as
  well.


- Verify Checksums during Basebackups

  NR. Sent 2018-02-28.

  It's a pretty simple patch, but it's been submitted on the day before
  the last CF. So I think there's a good case to be made for just moving
  it.


- GnuTLS support

  WOA.  I'm not quite sure what the status here is. If we want it, there
  seems to be some work to make it fully compatible, including scram
  work.


- Group Read Access for Data Directory

  WOA, although I don't quite know what for.

  Seems mostly ready, but I'm not sure how detailed a code review this
  got. A lot of the discussion in the thread is about tangential stuff.


- macOS Secure Transport SSL Support

  NR, CF entry created recently, but thread started much earlier.

  This is a fairly large part, and there seem to be some open
  issues. Being pre-auth and network exposed, It's also an area of code
  that is more security critical than a lot of other stuff. OTOH, there
  seems to be quite some desire to get off openssl on macs...


- pg_hba.conf : new auth option : clientcert=verify-full

  NR. Submitted first 2018-02-16.

  Fairly trivial patch, but submitted to last CF.  I think this is
  pretty borderline.


-