Re: Fix a typo in xlogreader.c

2021-01-12 Thread Alvaro Herrera 
On 2021-Jan-12, Masahiko Sawada wrote:

> Hi,
> 
> The function comment of RestoreBlockImage() seems not correct since it
> returns a boolean, not the buffer number.

You're right -- this has always been wrong.  Pushed your patch.

Thank you!



-- 
Álvaro Herrera39°49'30"S 73°17'W
"It takes less than 2 seconds to get to 78% complete; that's a good sign.
A few seconds later it's at 90%, but it seems to have stuck there.  Did
somebody make percentages logarithmic while I wasn't looking?"
http://smylers.hates-software.com/2005/09/08/1995c749.html

Fix a typo in xlogreader.c

2021-01-12 Thread Masahiko Sawada 
Hi,

The function comment of RestoreBlockImage() seems not correct since it
returns a boolean, not the buffer number.

 /*
  * Restore a full-page image from a backup block attached to an XLOG record.
  *
  * Returns the buffer number containing the page.
  */
 bool
 RestoreBlockImage(XLogReaderState *record, uint8 block_id, char *page)

Attached the patch that fixes it.

Regards,

-- 
Masahiko Sawada
EnterpriseDB:  https://www.enterprisedb.com/


fix_typo_xlogreader.patch
Description: Binary data