Re: patch: Add missing descriptions for rmgr APIs
On Mon, Aug 29, 2022 at 8:48 AM kuroda.hay...@fujitsu.com
wrote:
>
> Hi hackers,
>
> While reading codes related with logical decoding,
> I thought that following comment in rmgrlist.h is not consistent.
>
> > /* symbol name, textual name, redo, desc, identify, startup, cleanup */
>
> This comment describes a set of APIs that the resource manager should have,
> but functions for {mask, decode} are missed here.
>
Your observation seems correct to me but you have not updated the
comment for the mask. Is there a reason for the same?
--
With Regards,
Amit Kapila.
RE: patch: Add missing descriptions for rmgr APIs
> Your observation seems correct to me but you have not updated the > comment for the mask. Is there a reason for the same? Oh, it seems that I attached wrong one. There is no reason. PSA the newer version. Best Regards, Hayato Kuroda FUJITSU LIMITED v2-0001-add-a-missing-comment.patch Description: v2-0001-add-a-missing-comment.patch
Re: patch: Add missing descriptions for rmgr APIs
On Mon, Aug 29, 2022 at 6:19 PM kuroda.hay...@fujitsu.com wrote: > > > Your observation seems correct to me but you have not updated the > > comment for the mask. Is there a reason for the same? > > Oh, it seems that I attached wrong one. There is no reason. > PSA the newer version. > LGTM. Pushed. -- With Regards, Amit Kapila.
