Dag Lem <d...@nimrod.no> writes: > Please find attached a patch to run the previously commented-out > UTF8-dependent tests for citext, according to best practice. For now I > don't dare to touch the unaccent module, which seems to be UTF8-only > anyway.
I tried this on a bunch of different locale settings and concluded that we need to restrict the locale to avoid failures: it falls over with locale C. With that, it passes on all UTF8 LANG settings on RHEL8 and FreeBSD 12, and all except am_ET.UTF-8 on current macOS. I'm not sure what the deal is with am_ET, but macOS has a long and sad history of wonky UTF8 locales, so I was actually expecting worse. If the buildfarm shows more problems, we can restrict it further --- I won't be too upset if we end up restricting to just Linux systems, like collate.linux.utf8. Anyway, pushed to see what happens. regards, tom lane