Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

2021-11-17 Thread Peter Smith 
On Wed, Nov 17, 2021 at 11:45 PM Daniel Gustafsson  wrote:
>
> Pushed, thanks for review!
>

Thanks!

--
Kind Regards,
Peter Smith.
Fujitsu Australia

Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

2021-11-17 Thread Daniel Gustafsson 
> On 17 Nov 2021, at 09:24, Masahiko Sawada  wrote:
> On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson  wrote:
>> 
>>> On 15 Nov 2021, at 23:29, Peter Smith  wrote:

>>>  
>>>   
>>>   
>>> +   
>> 
>> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
>> reference each other, there should IMO be another xref to ALTER SUBSCRIPTION 
>> as
>> well.
> 
> +1

Pushed, thanks for review!

--
Daniel Gustafsson   https://vmware.com/

Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

2021-11-17 Thread Masahiko Sawada 
On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson  wrote:
>
> > On 15 Nov 2021, at 23:29, Peter Smith  wrote:
>
> > I noticed recently that the CREATE PUBLICATION docs page [1] does not
> > have any "See Also" reference to the CREATE SUBSCRIPTION docs page
> > [2].
>
> Nice catch.
>
> >   
> >
> >
> > +   
>
> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
> reference each other, there should IMO be another xref to ALTER SUBSCRIPTION 
> as
> well.

+1

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

2021-11-16 Thread Daniel Gustafsson 
> On 15 Nov 2021, at 23:29, Peter Smith  wrote:

> I noticed recently that the CREATE PUBLICATION docs page [1] does not
> have any "See Also" reference to the CREATE SUBSCRIPTION docs page
> [2].

Nice catch.

>   
>
>
> +   

To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as
well.

Unless there are objections, I'll apply that.

--
Daniel Gustafsson   https://vmware.com/