Re: Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments

2022-01-16 Thread Amit Kapila
On Fri, Jan 14, 2022 at 8:05 PM Amit Kapila  wrote:
>
> On Fri, Jan 14, 2022 at 8:55 AM Bharath Rupireddy
>  wrote:
> >
> > The function CreateCheckPoint is specified as CreateCheckpoint in some
> > of the code comments whereas in other places it is correctly
> > mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
> > across code comments.
> >
>
> LGTM. I'll take care of this unless someone thinks otherwise.
>

Pushed.

-- 
With Regards,
Amit Kapila.




Re: Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments

2022-01-14 Thread Amit Kapila
On Fri, Jan 14, 2022 at 8:55 AM Bharath Rupireddy
 wrote:
>
> The function CreateCheckPoint is specified as CreateCheckpoint in some
> of the code comments whereas in other places it is correctly
> mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
> across code comments.
>

LGTM. I'll take care of this unless someone thinks otherwise.

-- 
With Regards,
Amit Kapila.




Re: Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments

2022-01-13 Thread Robert Treat
On Thu, Jan 13, 2022 at 10:25 PM Bharath Rupireddy
 wrote:
>
> Hi,
>
> The function CreateCheckPoint is specified as CreateCheckpoint in some
> of the code comments whereas in other places it is correctly
> mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
> across code comments.
>

Heh, that's interesting, as I would have said that CreateCheckpoint is
the right casing vs CreateCheckPoint, but it looks like it has always
been the other way (according to
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=f0e37a85319e6c113ecd3303cddeb6edd5a6ac44).


Robert Treat
https://xzilla.net