Re: Is ssl_crl_file "SSL server cert revocation list"?

2021-12-05 Thread Kyotaro Horiguchi
At Fri, 3 Dec 2021 14:32:54 +0100, Daniel Gustafsson  wrote in 
> > On 2 Dec 2021, at 16:04, Peter Eisentraut 
> >  wrote:
> 
> > This change looks correct to me.
> 
> Thanks for review, I've pushed this backpatched (in part) down to 10.

Thanks for revising and comitting this.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




Re: Is ssl_crl_file "SSL server cert revocation list"?

2021-12-03 Thread Daniel Gustafsson
> On 2 Dec 2021, at 16:04, Peter Eisentraut  
> wrote:

> This change looks correct to me.

Thanks for review, I've pushed this backpatched (in part) down to 10.

--
Daniel Gustafsson   https://vmware.com/





Re: Is ssl_crl_file "SSL server cert revocation list"?

2021-12-02 Thread Peter Eisentraut

On 02.12.21 10:42, Daniel Gustafsson wrote:

On 2 Dec 2021, at 06:07, Kyotaro Horiguchi  wrote:

At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi 
 wrote in

As discussed in the thread [1], I find the wording "SSL server
certificate revocation list" as misleading or plain wrong.


FWIW, I'm convinced that that's plain wrong after finding some
occurances of "(SSL) client certificate" in the doc.


I agree with this, the concepts have been a bit muddled.

While in there I noticed that we omitted mentioning sslcrldir in a few cases.
The attached v2 adds these and removes the whitespace changes from your patch
for easier review.


This change looks correct to me.




Re: Is ssl_crl_file "SSL server cert revocation list"?

2021-12-02 Thread Daniel Gustafsson
> On 2 Dec 2021, at 06:07, Kyotaro Horiguchi  wrote:
> 
> At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi 
>  wrote in 
>> As discussed in the thread [1], I find the wording "SSL server
>> certificate revocation list" as misleading or plain wrong.
> 
> FWIW, I'm convinced that that's plain wrong after finding some
> occurances of "(SSL) client certificate" in the doc.

I agree with this, the concepts have been a bit muddled.

While in there I noticed that we omitted mentioning sslcrldir in a few cases.
The attached v2 adds these and removes the whitespace changes from your patch
for easier review.

--
Daniel Gustafsson   https://vmware.com/



fix_crl_doc-v2.diff
Description: Binary data


Re: Is ssl_crl_file "SSL server cert revocation list"?

2021-12-01 Thread Kyotaro Horiguchi
At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi 
 wrote in 
> As discussed in the thread [1], I find the wording "SSL server
> certificate revocation list" as misleading or plain wrong.

FWIW, I'm convinced that that's plain wrong after finding some
occurances of "(SSL) client certificate" in the doc.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center