Re: Missing cases from SPI_result_code_string()

[Dean Rasheed]

On Mon, 20 Feb 2023 at 19:49, Dean Rasheed  wrote:
>
> On Mon, 20 Feb 2023 at 19:39, Tom Lane  wrote:
> >
> > Ugh.  Grepping around, it looks like pltcl_process_SPI_result
> > is missing a case for SPI_OK_MERGE as well.
>
> Yes, I was about to post a patch for that too. That's the last case
> that I found, looking around.
>

OK, I've pushed fixes for those.

Regards,
Dean

Re: Missing cases from SPI_result_code_string()

[Dean Rasheed]

On Mon, 20 Feb 2023 at 19:39, Tom Lane  wrote:
>
> Ugh.  Grepping around, it looks like pltcl_process_SPI_result
> is missing a case for SPI_OK_MERGE as well.
>

Yes, I was about to post a patch for that too. That's the last case
that I found, looking around.

Regards,
Dean

Re: Missing cases from SPI_result_code_string()

[Tom Lane]

Dean Rasheed  writes:
> Another one noticed from the MERGE RETURNING patch -- the switch
> statement in SPI_result_code_string() is missing cases for
> SPI_OK_TD_REGISTER and SPI_OK_MERGE.

Ugh.  Grepping around, it looks like pltcl_process_SPI_result
is missing a case for SPI_OK_MERGE as well.

regards, tom lane