Re: Missing comment edit

2018-03-01 Thread Tom Lane 
Andres Freund  writes:
> On 2018-02-28 19:03:01 -0500, Tom Lane wrote:
>> Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
>> to just remove it, because it'll certainly be wrong again in future.
>> It's not telling you anything you can't find out with a trivial search
>> in the same file, so is it worth the maintenance overhead?

> +1. Do you want to do the honors?  If you don't and nobody comments,
> I'll do so.

Done.

regards, tom lane

Re: Missing comment edit

2018-03-01 Thread Andres Freund 
On 2018-02-28 19:03:01 -0500, Tom Lane wrote:
> Kyotaro HORIGUCHI  writes:
> > I happend to find that the comment on formdesc is missing
> > pg_subscription. Please find the attached patch (I'm sure:) to
> > fix that .
> 
> Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
> to just remove it, because it'll certainly be wrong again in future.
> It's not telling you anything you can't find out with a trivial search
> in the same file, so is it worth the maintenance overhead?

+1. Do you want to do the honors?  If you don't and nobody comments,
I'll do so.

- Andres

Re: Missing comment edit

2018-02-28 Thread Tom Lane 
Kyotaro HORIGUCHI  writes:
> I happend to find that the comment on formdesc is missing
> pg_subscription. Please find the attached patch (I'm sure:) to
> fix that .

Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
to just remove it, because it'll certainly be wrong again in future.
It's not telling you anything you can't find out with a trivial search
in the same file, so is it worth the maintenance overhead?

regards, tom lane