Re: Solaris "sed" versus pre-v13 plpython tests
On Thu, Sep 01, 2022 at 11:10:35AM +0200, Alvaro Herrera wrote: > On 2022-Aug-31, Noah Misch wrote: > > > On Wed, Aug 31, 2022 at 06:25:01PM -0400, Tom Lane wrote: > > > I am not completely sure why buildfarm member wrasse isn't failing > > > similarly > > > > wrasse disabled plpython in v12-, from day one, due to this and a crash bug > > that I shelved. I will be interested to see how margay reacts to your fix. > > It turned green two hours ago. Yay :-) Excellent. I can no longer reproduce the crash bug, so I enabled plpython on wrasse v10,v11,v12.
Re: Solaris "sed" versus pre-v13 plpython tests
On 2022-Aug-31, Noah Misch wrote: > On Wed, Aug 31, 2022 at 06:25:01PM -0400, Tom Lane wrote: > > I am not completely sure why buildfarm member wrasse isn't failing > > similarly > > wrasse disabled plpython in v12-, from day one, due to this and a crash bug > that I shelved. I will be interested to see how margay reacts to your fix. It turned green two hours ago. Yay :-) -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Re: Solaris "sed" versus pre-v13 plpython tests
On Wed, Aug 31, 2022 at 06:25:01PM -0400, Tom Lane wrote: > I am not completely sure why buildfarm member wrasse isn't failing > similarly wrasse disabled plpython in v12-, from day one, due to this and a crash bug that I shelved. I will be interested to see how margay reacts to your fix.
Re: Solaris "sed" versus pre-v13 plpython tests
I wrote: > I confirmed on the gcc farm's Solaris 11 box that the pattern > doesn't work as expected with /usr/bin/sed: > tgl@gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except > \([[:alpha:]][[:alpha:].]*\), *\([[:alpha:]][[:alpha:]]*\):/except \1 as > \2:/g' > except foo, bar: > We could perhaps do this instead: > $ echo except foo, bar: | sed -e '/^ *except.*,.*: *$/s/, / as /g' > except foo as bar: > It's a little bit more brittle, but Python doesn't allow any other > commands on the same line does it? Oh ... after a bit more experimentation, there's an easier way. Apparently the real problem is that Solaris' sed doesn't handle [[:alpha:]] (I wonder if this is locale-dependent?). I get correct results after expanding it manually, eg tgl@gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except \([a-z][a-z.]*\), *\([a-z][a-zA-Z]*\):/except \1 as \2:/g' except foo as bar: We aren't likely to need anything beyond a-zA-Z and maybe 0-9, so I'll go fix it that way. regards, tom lane
