Re: Unnecessary global variable declared in xlog.c
On Wed, Nov 17, 2021 at 7:36 AM Michael Paquier wrote: > > On Tue, Nov 16, 2021 at 02:08:54AM -0500, Tom Lane wrote: > > I think LastRec was originally referenced by multiple functions > > in xlog.c. But it does look like it could be a local now. > > Thanks for double-checking, applied this one as of f975fc3. Thank you, Michael. Regards, Amul
Re: Unnecessary global variable declared in xlog.c
On Tue, Nov 16, 2021 at 02:08:54AM -0500, Tom Lane wrote: > I think LastRec was originally referenced by multiple functions > in xlog.c. But it does look like it could be a local now. Thanks for double-checking, applied this one as of f975fc3. -- Michael signature.asc Description: PGP signature
Re: Unnecessary global variable declared in xlog.c
Michael Paquier writes: > On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote: >> The attached patch moves the "LastRec" variable declaration inside >> StartupXLOG() where it is supposed to be. > Yes, reading through the code, your suggestion makes sense. I'll > double-check and apply if there are no objections. I think LastRec was originally referenced by multiple functions in xlog.c. But it does look like it could be a local now. regards, tom lane
Re: Unnecessary global variable declared in xlog.c
On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote: > The attached patch moves the "LastRec" variable declaration inside > StartupXLOG() where it is supposed to be. Yes, reading through the code, your suggestion makes sense. I'll double-check and apply if there are no objections. -- Michael signature.asc Description: PGP signature
