Re: fine tune v11 release notes
Justin Pryzby writes: > On Sat, Oct 13, 2018 at 05:31:46PM -0400, Tom Lane wrote: >> I've pushed updates merging Jonathan's last with my work. Please >> look over what's in HEAD and see if you want to propose additional >> changes. > Find attached what's left. I pushed some of this verbatim, tweaked some others, and left some spots alone because I thought the existing wording was superior. Notably, I ended up merging the two items about partitioned indexes and rewriting them altogether, because it seemed more sensible to present it that way. See what you think. Also, on the point of whether 11d8d72c2 requires a compatibility note, I did think about that earlier today. I think it's fine though; the case in question is so odd that probably nobody's done it anyway. We don't want the compatibility section to get impossibly long ... regards, tom lane
Re: fine tune v11 release notes
On Sat, Oct 13, 2018 at 05:31:46PM -0400, Tom Lane wrote: > Justin Pryzby writes: > >> On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: > >>> Hmm, I just saw this after spending an afternoon editing the release > >>> notes. I'll try to merge it with what I did. > > > Feel free to send your own patch and I'll resolve conflicts and resend > > proposed > > changes. > > I've pushed updates merging Jonathan's last with my work. Please > look over what's in HEAD and see if you want to propose additional > changes. Find attached what's left. Justin diff --git a/doc/src/sgml/release-11.sgml b/doc/src/sgml/release-11.sgml index 188222f..cdf41af 100644 --- a/doc/src/sgml/release-11.sgml +++ b/doc/src/sgml/release-11.sgml @@ -31,8 +31,8 @@ - Add support for PRIMARY KEY, FOREIGN - KEY, indexes, and triggers on partitioned tables + Add support on partitioned tables for PRIMARY + KEY, FOREIGN KEY, indexes, and triggers @@ -65,7 +65,7 @@ CREATE INDEX can now use parallel processing - while building B-tree indexes + while building a B-tree index @@ -117,9 +117,9 @@ - Many other useful performance improvements, including a significant - speedup to ALTER TABLE ... ADD COLUMN with a - non-null column default, as it no longer rewrites the table data + Many other useful performance improvements, including the ability to avoid + a table rewrite when using ALTER TABLE .. ADD COLUMN + with a non-null column default. @@ -587,15 +587,18 @@ --> -Allow indexes on a partitioned table to be automatically created -in new child partitions (lvaro Herrera) +Support indexes on partitioned tables (lvaro Herrera) + + + +This is not a global index, but rather a mechanism to create an indexes +on each partition of a partitioned table. The new command ALTER -INDEX ATTACH PARTITION allows indexes to be -attached to partitions. This does not behave as a global index -since the contents are private to each index. +INDEX ATTACH PARTITION allows an index on a partition +to be inherited by the index on its partitioned table. @@ -733,8 +736,8 @@ --> -Perform aggregation on each partition, and then merge the results -(Jeevan Chalke, Ashutosh Bapat, Robert Haas) +Allow aggregate functions on partitioned tables to be evaluated +directly on partitions. (Jeevan Chalke, Ashutosh Bapat, Robert Haas) @@ -1101,8 +1104,8 @@ same commits as above --> -Improve optimizer's row count estimates for EXISTS -and NOT EXISTS queries (Tom Lane) +Improve row count estimates for EXISTS and +NOT EXISTS queries (Tom Lane) @@ -1146,7 +1149,7 @@ same commits as above This feature requires LLVM to be -available. It is not currently enabled by default, even in +available. It is disabled by default, even in builds that support it. @@ -1564,11 +1567,11 @@ same commits as above Allow server options related to memory and file sizes to be -specified as a number of bytes (Beena Emerson) +specified in units of bytes (Beena Emerson) -The new unit is B. This is in addition to the +The new suffix is B. This is in addition to the existing units kB, MB, GB and TB. @@ -1605,7 +1608,7 @@ same commits as above --> -Retain WAL data for only a single checkpoint +Retain WAL data for a single checkpoint, only. (Simon Riggs) @@ -1801,6 +1804,7 @@ same commits as above +DOES THIS NEED TO BE IN "COMPATIBILITY NOTES"? Also, if any table mentioned in VACUUM uses a column list, then the ANALYZE keyword must be supplied; previously, ANALYZE was implied in @@ -2199,8 +2203,7 @@ same commits as above Add psql command \gdesc -to display the column names and types of the query output (Pavel -Stehule) +to display the names and types of the columns in query results (Pavel Stehule)
Re: fine tune v11 release notes
Justin Pryzby writes: >> On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: >>> Hmm, I just saw this after spending an afternoon editing the release >>> notes. I'll try to merge it with what I did. > Feel free to send your own patch and I'll resolve conflicts and resend > proposed > changes. I've pushed updates merging Jonathan's last with my work. Please look over what's in HEAD and see if you want to propose additional changes. regards, tom lane
Re: fine tune v11 release notes
On Sat, Oct 13, 2018 at 03:38:39PM -0500, Justin Pryzby wrote: > On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: > > "Jonathan S. Katz" writes: > > > On 10/6/18 9:42 AM, Justin Pryzby wrote: > > >> Find below various fixes to release notes for v11, for discussion > > >> purposes. > > > > > Thanks for putting this together. I reviewed, broke it up into two > > > patches, and made some additions / changes / deletions. Please see > > > attached patches. > > > > Hmm, I just saw this after spending an afternoon editing the release > > notes. I'll try to merge it with what I did. > > I had some more local changes too...I'll try to send an patch relative to my > original. I'm sure Jonathan already caught most of the errors anyway. I'm attaching two patches. They're redundant ; choose one. 1) fine-tune-jonathan-justin.patch: To be applied on top of Jonathan's patch to release notes. I believe he dropped a few of my changes, but I don't know offhand which, so some of my changes should perhaps be removed. I think at least these two additional hunks are important: - B-tree indexes can now be built in parallel with + A B-tree index can now be built in parallel with => avoid confusion between "parallel" and "simultaneous". -Allow UNIQUE indexes on partitioned tables if -the partition key guarantees uniqueness (lvaro Herrera, +Allow UNIQUE indexes on partitioned tables when +the partition key is included in the index key (lvaro Herrera, => Needed for correctness IMHO. 2) fine-tune-v2.patch: relative to my original. Should be self explanatory. Feel free to send your own patch and I'll resolve conflicts and resend proposed changes. Justin diff --git a/doc/src/sgml/release-11.sgml b/doc/src/sgml/release-11.sgml index 5df6a41..5594d43 100644 --- a/doc/src/sgml/release-11.sgml +++ b/doc/src/sgml/release-11.sgml @@ -49,8 +49,8 @@ - Having a "default" partition for storing data that does not match any - of the remaining partitions + Allow creation of a "default" partition for storing rows which are + excluded by bounds of all other partitions. @@ -63,7 +63,7 @@ - B-tree indexes can now be built in parallel with + A B-tree index can now be built in parallel with CREATE INDEX @@ -118,9 +118,9 @@ - Many other useful performance improvements, including a significant - speedup to the ALTER TABLE .. ADD COLUMN with a - non-null column default as it no longer rewrites the full table. + Many other useful performance improvements, including the ability to avoid + a table rewrite when using ALTER TABLE .. ADD COLUMN + with a non-null column default. @@ -591,8 +591,8 @@ --> -Allow UNIQUE indexes on partitioned tables if -the partition key guarantees uniqueness (lvaro Herrera, +Allow UNIQUE indexes on partitioned tables when +the partition key is included in the index key (lvaro Herrera, Amit Langote) @@ -603,15 +603,18 @@ --> -Allow indexes on a partitioned table to be automatically created -in any child partitions (lvaro Herrera) +Support indexes on partitioned tables (lvaro Herrera) + + + +This is not a global index, but rather a mechanism to create indexes on +on each partition of a partitioned table. The new command ALTER -INDEX ATTACH PARTITION allows indexes to be -attached to partitions. This does not behave as a global index -since the contents are private to each index. +INDEX ATTACH PARTITION allows an index on a partition +to be inherited by the index on its partitioned tables. @@ -654,7 +657,7 @@ Creation of a trigger on partitioned tables automatically creates -triggers on all existing and future partitions. +triggers on all existing and any future partitions. This also allows deferred unique constraints on partitioned tables. @@ -667,14 +670,16 @@ --> -Allow partitioned tables to be joined directly for equality joins with -identically partitioned child tables. (Ashutosh Bapat) +Allow joins between partitioned tables to be performed directly +on partitions. (Ashutosh Bapat) -This feature is disabled by default -but can be enabled by changing enable_partitionwise_join. +This applies to equality joins between partitioned tables whose +partitions have exactly the same partition bounds. +This feature is disabled by default but can be enabled by changing +enable_partitionwise_join. + @@ -685,14 +690,13 @@ --> -
Re: fine tune v11 release notes
On 10/13/18 4:38 PM, Justin Pryzby wrote: > On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: >> "Jonathan S. Katz" writes: >>> On 10/6/18 9:42 AM, Justin Pryzby wrote: Find below various fixes to release notes for v11, for discussion purposes. >> >>> Thanks for putting this together. I reviewed, broke it up into two >>> patches, and made some additions / changes / deletions. Please see >>> attached patches. >> >> Hmm, I just saw this after spending an afternoon editing the release >> notes. I'll try to merge it with what I did. > > I had some more local changes too...I'll try to send an patch relative to my > original. I'm sure Jonathan already caught most of the errors anyway. Maybe, maybe not :) Jonathan signature.asc Description: OpenPGP digital signature
Re: fine tune v11 release notes
On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: > "Jonathan S. Katz" writes: > > On 10/6/18 9:42 AM, Justin Pryzby wrote: > >> Find below various fixes to release notes for v11, for discussion purposes. > > > Thanks for putting this together. I reviewed, broke it up into two > > patches, and made some additions / changes / deletions. Please see > > attached patches. > > Hmm, I just saw this after spending an afternoon editing the release > notes. I'll try to merge it with what I did. I had some more local changes too...I'll try to send an patch relative to my original. I'm sure Jonathan already caught most of the errors anyway. Justin
Re: fine tune v11 release notes
"Jonathan S. Katz" writes: > On 10/6/18 9:42 AM, Justin Pryzby wrote: >> Find below various fixes to release notes for v11, for discussion purposes. > Thanks for putting this together. I reviewed, broke it up into two > patches, and made some additions / changes / deletions. Please see > attached patches. Hmm, I just saw this after spending an afternoon editing the release notes. I'll try to merge it with what I did. regards, tom lane
Re: fine tune v11 release notes
Hi Justin, On 10/6/18 9:42 AM, Justin Pryzby wrote: > Find below various fixes to release notes for v11, for discussion purposes. Thanks for putting this together. I reviewed, broke it up into two patches, and made some additions / changes / deletions. Please see attached patches. Thanks! Jonathan From eaf42cd9f014a2420339afbd89be2e5f35cf49e7 Mon Sep 17 00:00:00 2001 From: "Jonathan S. Katz" Date: Sat, 13 Oct 2018 15:38:18 -0400 Subject: [PATCH 1/2] Updates to CREATE INDEX documentation. Includes clarifications on new functionality availability in PostgreSQL 11, as well as some language cleanups Author: Justin Pryzby Reviewed-by: Jonathan Katz --- doc/src/sgml/ref/create_index.sgml | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml index 3c1223b324..3424733851 100644 --- a/doc/src/sgml/ref/create_index.sgml +++ b/doc/src/sgml/ref/create_index.sgml @@ -612,11 +612,12 @@ Indexes: Regular index builds permit other regular index builds on the -same table to occur in parallel, but only one concurrent index build -can occur on a table at a time. In both cases, no other types of schema -modification on the table are allowed meanwhile. Another difference -is that a regular CREATE INDEX command can be performed within -a transaction block, but CREATE INDEX CONCURRENTLY cannot. +same table to occur simultaneously, but only one concurrent index build +can occur on a table at a time. In either case, schema modification of the +table is not allowed while the index is being built. Another difference is +that a regular CREATE INDEX command can be performed +within a transaction block, but CREATE INDEX CONCURRENTLY +cannot. @@ -650,7 +651,7 @@ Indexes: ordering. For example, we might want to sort a complex-number data type either by absolute value or by real part. We could do this by defining two operator classes for the data type and then selecting - the proper class when making an index. More information about + the proper class when creating an index. More information about operator classes is in and in . @@ -673,7 +674,7 @@ Indexes: valid, once all partitions acquire the index.) Note, however, that any partition that is created in the future using CREATE TABLE ... PARTITION OF will automatically - contain the index regardless of whether this option was specified. + contain the index regardless of ONLY being specified. -- 2.14.3 (Apple Git-98) From 3af6130cbc551b75b7c7433a5cd0dfb6b01071db Mon Sep 17 00:00:00 2001 From: "Jonathan S. Katz" Date: Sat, 13 Oct 2018 15:59:10 -0400 Subject: [PATCH 2/2] Updates for PostgreSQL 11 Release notes. Includes grammatical fixes and clarifications. Author: Justin Pryzby Reviewed-by: Jonathan Katz --- doc/src/sgml/release-11.sgml | 88 ++-- 1 file changed, 43 insertions(+), 45 deletions(-) diff --git a/doc/src/sgml/release-11.sgml b/doc/src/sgml/release-11.sgml index ca42f28cc9..5df6a418e9 100644 --- a/doc/src/sgml/release-11.sgml +++ b/doc/src/sgml/release-11.sgml @@ -32,19 +32,19 @@ UPDATE statements that change a partition key - now move affected rows to the appropriate partitions + now cause affected rows to be moved to the appropriate partitions Improved SELECT performance from enhanced partition - elimination strategies during query processing and execution + elimination strategies during query planning and execution - Support for PRIMARY KEY, FOREIGN - KEY, indexes, and triggers on partitioned tables + Added support on partitioned tables for PRIMARY + KEY, FOREIGN KEY, indexes, and triggers @@ -118,9 +118,9 @@ - Many other useful performance improvements, including making - ALTER TABLE .. ADD COLUMN with a - non-null column default faster + Many other useful performance improvements, including a significant + speedup to the ALTER TABLE .. ADD COLUMN with a + non-null column default as it no longer rewrites the full table. @@ -163,7 +163,7 @@ -Previously database attributes like +Previously, database attributes like GRANT/REVOKE permissions and ALTER DATABASE SET and ALTER ROLE IN DATABASE SET variable settings were only dumped by A restore of pg_dumpall will now create databases with their original locale and encoding, and will fail if -the creation fails. Previously CREATE DATABASE +the creation fails. Previously, CREATE DATABASE would be dumped without such specifications if the database locale and encoding matched
Re: fine tune v11 release notes
I like broccoli
