Re: old_snapshot: add test for coverage
On Mon, Aug 8, 2022 at 2:37 PM Tom Lane wrote: > > Dong Wook Lee writes: > > I wrote a test of the old_snapshot extension for coverage. > > Hmm, does this really provide any meaningful coverage? The test > sure looks like it's not doing much. Previously written tests were simply test codes to increase coverage. Therefore, we can make a better test. I'll think about it by this week. If this work exceeds my ability, I will let you know by reply. It's okay that the issue should be closed unless I write a meaningful test. --- Regards, DongWook Lee.
Re: old_snapshot: add test for coverage
> On 8 Aug 2022, at 07:37, Tom Lane wrote: > Dong Wook Lee writes: >> I wrote a test of the old_snapshot extension for coverage. > > Hmm, does this really provide any meaningful coverage? The test > sure looks like it's not doing much. Looking at this I agree, this test doesn't provide enough to be of value and the LIMIT 0 might even hide bugs under a postive test result. I think we should mark this entry RwF. -- Daniel Gustafsson https://vmware.com/
Re: old_snapshot: add test for coverage
Dong Wook Lee writes: > I wrote a test of the old_snapshot extension for coverage. Hmm, does this really provide any meaningful coverage? The test sure looks like it's not doing much. I spent some time a week or so ago trying to graft testing of contrib/old_snapshot into src/test/modules/snapshot_too_old. I didn't come up with anything I liked, but I still think that that might lead to a more thorough test than a standalone exercise. regards, tom lane