Re: Remove PG_SHA*_DIGEST_STRING_LENGTH from sha2.h
On Thu, Jan 14, 2021 at 03:11:12PM +0900, Michael Paquier wrote: > I have just noticed that aef8948 has removed the last reference to > PG_SHA256_DIGEST_STRING_LENGTH in the code (this was getting used to > know the length of a SHA256 digest encoded to hex for checksum > manifests, but pg_hex_enc_len() calculates the same in a more > consistent way). Attached is a patch to remove all those now-useless > declarations, for all four SHA2 options. Cleanup done as of ccf4e27. -- Michael signature.asc Description: PGP signature
Remove PG_SHA*_DIGEST_STRING_LENGTH from sha2.h
Hi all, I have just noticed that aef8948 has removed the last reference to PG_SHA256_DIGEST_STRING_LENGTH in the code (this was getting used to know the length of a SHA256 digest encoded to hex for checksum manifests, but pg_hex_enc_len() calculates the same in a more consistent way). Attached is a patch to remove all those now-useless declarations, for all four SHA2 options. Thoughts? -- Michael diff --git a/src/include/common/sha2.h b/src/include/common/sha2.h index f4bae35af1..dfeee6bceb 100644 --- a/src/include/common/sha2.h +++ b/src/include/common/sha2.h @@ -18,15 +18,11 @@ /*** SHA224/256/384/512 Various Length Definitions ***/ #define PG_SHA224_BLOCK_LENGTH 64 #define PG_SHA224_DIGEST_LENGTH 28 -#define PG_SHA224_DIGEST_STRING_LENGTH (PG_SHA224_DIGEST_LENGTH * 2 + 1) #define PG_SHA256_BLOCK_LENGTH 64 #define PG_SHA256_DIGEST_LENGTH 32 -#define PG_SHA256_DIGEST_STRING_LENGTH (PG_SHA256_DIGEST_LENGTH * 2 + 1) #define PG_SHA384_BLOCK_LENGTH 128 #define PG_SHA384_DIGEST_LENGTH 48 -#define PG_SHA384_DIGEST_STRING_LENGTH (PG_SHA384_DIGEST_LENGTH * 2 + 1) #define PG_SHA512_BLOCK_LENGTH 128 #define PG_SHA512_DIGEST_LENGTH 64 -#define PG_SHA512_DIGEST_STRING_LENGTH (PG_SHA512_DIGEST_LENGTH * 2 + 1) #endif /* _PG_SHA2_H_ */ signature.asc Description: PGP signature
