Re: Remove redundant HandleWalWriterInterrupts()
On Thu, Jan 25, 2024 at 4:40 AM Nathan Bossart wrote: > > On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote: > > On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao wrote: > >> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts() > >> became the same as HandleMainLoopInterrupts(). So I'd like to propose to > >> remove HandleWalWriterInterrupts() and make walwriter use > >> HandleMainLoopInterrupts() instead for improved code simplicity. Thought? > >> > >> Patch attached. > > > > Nice catch. Indeed they both are the same after commit 1bdd54e662. The > > patch LGTM. > > LGTM, too. Thank you both for reviewing! I've pushed the patch. Regards, -- Fujii Masao
Re: Remove redundant HandleWalWriterInterrupts()
On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote: > On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao wrote: >> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts() >> became the same as HandleMainLoopInterrupts(). So I'd like to propose to >> remove HandleWalWriterInterrupts() and make walwriter use >> HandleMainLoopInterrupts() instead for improved code simplicity. Thought? >> >> Patch attached. > > Nice catch. Indeed they both are the same after commit 1bdd54e662. The > patch LGTM. LGTM, too. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Re: Remove redundant HandleWalWriterInterrupts()
On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao wrote: > > Hi, > > Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts() > became the same as HandleMainLoopInterrupts(). So I'd like to propose to > remove HandleWalWriterInterrupts() and make walwriter use > HandleMainLoopInterrupts() instead for improved code simplicity. Thought? > > Patch attached. Nice catch. Indeed they both are the same after commit 1bdd54e662. The patch LGTM. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Remove redundant HandleWalWriterInterrupts()
Hi, Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts() became the same as HandleMainLoopInterrupts(). So I'd like to propose to remove HandleWalWriterInterrupts() and make walwriter use HandleMainLoopInterrupts() instead for improved code simplicity. Thought? Patch attached. Regards, -- Fujii Masao v1-0001-Remove-redundant-HandleWalWriterInterrupts.patch Description: Binary data