RE: Remove wal_level settings for subscribers in tap tests
Dear Michael, I found it was pushed. Thanks! Best Regards, Hayato Kuroda FUJITSU LIMITED
Re: Remove wal_level settings for subscribers in tap tests
On Wed, Oct 18, 2023 at 03:39:16PM +0900, Michael Paquier wrote: > Hmm, okay. On top of your argument, this may be a good idea for a > different reason: it makes the tests a bit cheaper as "logical" > generates a bit more WAL. Still the gain is marginal. And applied this one. -- Michael signature.asc Description: PGP signature
Re: Remove wal_level settings for subscribers in tap tests
On Wed, Oct 18, 2023 at 02:59:52AM +, Hayato Kuroda (Fujitsu) wrote: > While discussing [1], I found that in tap tests, wal_level was set to logical > for > subscribers too. The setting is not needed for subscriber side, and it may > cause > misunderstanding for newcomers. Therefore, I wanted to propose the patch which > removes unnecessary "allows_streaming => 'logical'". > I grepped with the string and checked the necessity of them one by one. > > How do you think? > > [1]: https://commitfest.postgresql.org/45/4273/ Hmm, okay. On top of your argument, this may be a good idea for a different reason: it makes the tests a bit cheaper as "logical" generates a bit more WAL. Still the gain is marginal. -- Michael signature.asc Description: PGP signature
Remove wal_level settings for subscribers in tap tests
Dear hackers, While discussing [1], I found that in tap tests, wal_level was set to logical for subscribers too. The setting is not needed for subscriber side, and it may cause misunderstanding for newcomers. Therefore, I wanted to propose the patch which removes unnecessary "allows_streaming => 'logical'". I grepped with the string and checked the necessity of them one by one. How do you think? [1]: https://commitfest.postgresql.org/45/4273/ Best Regards, Hayato Kuroda FUJITSU LIMITED 0001-remove-unnecessary-wal_level-settings.patch Description: 0001-remove-unnecessary-wal_level-settings.patch
