Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

2022-09-25 Thread Amit Kapila 
On Fri, Sep 23, 2022 at 8:58 AM Amit Kapila  wrote:
>
> On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli  wrote:
> >
> > On Sep 21, 2022, 22:22 +0800, Melih Mutlu , wrote:
> >
> > Hi hackers,
> >
> > Sharing a small patch to remove an unused parameter in 
> > SnapBuildGetOrBuildSnapshot function in snapbuild.c
> >
> >
> > +1, Good Catch.
> >
>
> LGTM.
>

Pushed.

-- 
With Regards,
Amit Kapila.

Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

2022-09-22 Thread Amit Kapila 
On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli  wrote:
>
> On Sep 21, 2022, 22:22 +0800, Melih Mutlu , wrote:
>
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in 
> SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot 
> no longer needs transaction id. This also makes the xid parameter in 
> SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
>
> +1, Good Catch.
>

LGTM.

-- 
With Regards,
Amit Kapila.

Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

2022-09-21 Thread Zhang Mingli 
On Sep 21, 2022, 22:22 +0800, Melih Mutlu , wrote:
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in 
> SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot 
> no longer needs transaction id. This also makes the xid parameter in 
> SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
+1, Good Catch.

Regards,
Zhang Mingli

Removing unused parameter in SnapBuildGetOrBuildSnapshot

2022-09-21 Thread Melih Mutlu 
Hi hackers,

Sharing a small patch to remove an unused parameter
in SnapBuildGetOrBuildSnapshot function in snapbuild.c

With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f,
SnapBuildBuildSnapshot no longer needs transaction id. This also makes the
xid parameter in SnapBuildGetOrBuildSnapshot useless.
I couldn't see a reason to keep it and decided to remove it.

Regards,
Melih


0001-Remove-unused-xid-parameter.patch
Description: Binary data