Re: Slightly improved meson error for docs tools

[Magnus Hagander]

On Wed, Jan 10, 2024 at 1:05 PM Aleksander Alekseev
 wrote:
>
> Hi,
>
> > least lists what's expected -- I'm not sure if this is the way to go,
> > or if we should somehow list the individual tools that are failing
> > here?
>
> Personally I think the patch is OK.

Thanks. I've pushed this one for now, we can always adjust further
later if needed.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

Re: Slightly improved meson error for docs tools

[Aleksander Alekseev]

Hi,

> least lists what's expected -- I'm not sure if this is the way to go,
> or if we should somehow list the individual tools that are failing
> here?

Personally I think the patch is OK.

-- 
Best regards,
Aleksander Alekseev

Slightly improved meson error for docs tools

[Magnus Hagander]

The meson build doesn't tell you what tool is missing when trying to
build the docs (and you don't have it in the path.. sigh), it just
tells you that something is missing. Attached is a small patch that at
least lists what's expected -- I'm not sure if this is the way to go,
or if we should somehow list the individual tools that are failing
here?


-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/
diff --git a/meson.build b/meson.build
index 57f9735feb..c317144b6b 100644
--- a/meson.build
+++ b/meson.build
@@ -587,7 +587,7 @@ if not docs_opt.disabled()
   if xmllint_bin.found() and xsltproc_bin.found()
 docs_dep = declare_dependency()
   elif docs_opt.enabled()
-error('missing required tools for docs in HTML / man page format')
+error('missing required tools (xmllint and xsltproc needed) for docs in HTML / man page format')
   endif
 endif