Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

> Tatsuo Ishii  writes:
>> Would you like to do this yourself? Or shall I do this?
> 
> Go ahead, I have a bunch of other stuff to do ...

Done. Once my editing is confirmed ok, I will delete the item.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Re: TODO item for broken \s with libedit seems fixed

[Patrick Krecker]

> On Feb 27, 2018, at 06:25, Tom Lane  wrote:
> 
> Tatsuo Ishii  writes:
>> Would you like to do this yourself? Or shall I do this?
> 
> Go ahead, I have a bunch of other stuff to do ...
> 
>regards, tom lane

I don’t think I have permission to edit the page, otherwise I would be happy to.

Thanks,
Patrick

Re: TODO item for broken \s with libedit seems fixed

[Tom Lane]

Tatsuo Ishii  writes:
> Would you like to do this yourself? Or shall I do this?

Go ahead, I have a bunch of other stuff to do ...

regards, tom lane

Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

Patrick,

>> Sure, although leaving a commit message with a pointer to the fix in git
>> would document this better.
> 
> Right. We should always do that.

Would you like to do this yourself? Or shall I do this?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

> Sure, although leaving a commit message with a pointer to the fix in git
> would document this better.

Right. We should always do that.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Re: TODO item for broken \s with libedit seems fixed

[Tom Lane]

Tatsuo Ishii  writes:
> I would prefer to mark it done then remove the item just for leaving
> an editing history.

Sure, although leaving a commit message with a pointer to the fix in git
would document this better.

regards, tom lane

Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

> I think that, back when we were actively maintaining the TODO list,
> the idea was that items got marked as "Done" when committed and then
> removed from the list after the fix was released.  In this case, since
> the fix went out years ago, we might as well just remove the entry
> immediately.

I would prefer to mark it done then remove the item just for leaving
an editing history.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Re: TODO item for broken \s with libedit seems fixed

[Tom Lane]

Tatsuo Ishii  writes:
> Ok, let's mark it as "Done.", (rather than removing it) if there's no
> objection.

I think that, back when we were actively maintaining the TODO list,
the idea was that items got marked as "Done" when committed and then
removed from the list after the fix was released.  In this case, since
the fix went out years ago, we might as well just remove the entry
immediately.

regards, tom lane

Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

> On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii  wrote:
>>> It appears this was fixed back in 2014 with 750c5ee. I propose for it
>>> to be removed from the TODO list.
>>
>> Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
>> Mac OS X yet though.
>>
>> Best regards,
>> --
>> Tatsuo Ishii
>> SRA OSS, Inc. Japan
>> English: http://www.sraoss.co.jp/index_en.php
>> Japanese:http://www.sraoss.co.jp
> 
> I tested on macOS 10.12.6.

Ok, let's mark it as "Done.", (rather than removing it) if there's no
objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Re: TODO item for broken \s with libedit seems fixed

[Patrick Krecker]

On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii  wrote:
>> It appears this was fixed back in 2014 with 750c5ee. I propose for it
>> to be removed from the TODO list.
>
> Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
> Mac OS X yet though.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp

I tested on macOS 10.12.6.

Patrick

Re: TODO item for broken \s with libedit seems fixed

[Tatsuo Ishii]

> It appears this was fixed back in 2014 with 750c5ee. I propose for it
> to be removed from the TODO list.

Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
Mac OS X yet though.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

TODO item for broken \s with libedit seems fixed

[Patrick Krecker]

It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.

Thanks,
Patrick