Re: Unused variable in TAP tests file

2021-09-05 Thread Amul Sul
Thank you !

Regards,
Amul

On Mon, Sep 6, 2021 at 7:58 AM Michael Paquier  wrote:
>
> On Fri, Sep 03, 2021 at 04:03:36PM +0900, Michael Paquier wrote:
> > Indeed.  Let's clean up that.  Thanks!
>
> And done.
> --
> Michael




Re: Unused variable in TAP tests file

2021-09-05 Thread Michael Paquier
On Fri, Sep 03, 2021 at 04:03:36PM +0900, Michael Paquier wrote:
> Indeed.  Let's clean up that.  Thanks!

And done.
--
Michael


signature.asc
Description: PGP signature


Re: Unused variable in TAP tests file

2021-09-03 Thread Michael Paquier
On Fri, Sep 03, 2021 at 10:53:19AM +0530, Amul Sul wrote:
> Few tap test files have the "tempdir_short" variable which isn't in
> use. The attached patch removes the same

Indeed.  Let's clean up that.  Thanks!
--
Michael


signature.asc
Description: PGP signature


Unused variable in TAP tests file

2021-09-02 Thread Amul Sul
Few tap test files have the "tempdir_short" variable which isn't in
use. The attached patch removes the same

Regards,
Amul
From 0751895df64bcd6bc719933013edf1d76e31b784 Mon Sep 17 00:00:00 2001
From: Amul Sul 
Date: Fri, 3 Sep 2021 01:19:29 -0400
Subject: [PATCH] Remove unused variable

---
 src/bin/pg_ctl/t/002_status.pl   | 1 -
 src/bin/pg_dump/t/001_basic.pl   | 1 -
 src/bin/pg_dump/t/002_pg_dump.pl | 1 -
 src/bin/pg_dump/t/003_pg_dump_with_server.pl | 1 -
 src/test/modules/test_pg_dump/t/001_base.pl  | 1 -
 5 files changed, 5 deletions(-)

diff --git a/src/bin/pg_ctl/t/002_status.pl b/src/bin/pg_ctl/t/002_status.pl
index 56a06fafa3b..c6f4fac57b6 100644
--- a/src/bin/pg_ctl/t/002_status.pl
+++ b/src/bin/pg_ctl/t/002_status.pl
@@ -9,7 +9,6 @@ use TestLib;
 use Test::More tests => 3;
 
 my $tempdir   = TestLib::tempdir;
-my $tempdir_short = TestLib::tempdir_short;
 
 command_exit_is([ 'pg_ctl', 'status', '-D', "$tempdir/nonexistent" ],
 	4, 'pg_ctl status with nonexistent directory');
diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index d1a7e1db405..d6731855eda 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -10,7 +10,6 @@ use TestLib;
 use Test::More tests => 82;
 
 my $tempdir   = TestLib::tempdir;
-my $tempdir_short = TestLib::tempdir_short;
 
 #
 # Basic checks
diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
index a4ee54d516f..223f60e3bcb 100644
--- a/src/bin/pg_dump/t/002_pg_dump.pl
+++ b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -10,7 +10,6 @@ use TestLib;
 use Test::More;
 
 my $tempdir   = TestLib::tempdir;
-my $tempdir_short = TestLib::tempdir_short;
 
 ###
 # Definition of the pg_dump runs to make.
diff --git a/src/bin/pg_dump/t/003_pg_dump_with_server.pl b/src/bin/pg_dump/t/003_pg_dump_with_server.pl
index ba994aee823..a879ae28d8d 100644
--- a/src/bin/pg_dump/t/003_pg_dump_with_server.pl
+++ b/src/bin/pg_dump/t/003_pg_dump_with_server.pl
@@ -9,7 +9,6 @@ use TestLib;
 use Test::More tests => 3;
 
 my $tempdir   = TestLib::tempdir;
-my $tempdir_short = TestLib::tempdir_short;
 
 my $node = PostgresNode->new('main');
 my $port = $node->port;
diff --git a/src/test/modules/test_pg_dump/t/001_base.pl b/src/test/modules/test_pg_dump/t/001_base.pl
index ea7739d7254..17c404c81f2 100644
--- a/src/test/modules/test_pg_dump/t/001_base.pl
+++ b/src/test/modules/test_pg_dump/t/001_base.pl
@@ -10,7 +10,6 @@ use TestLib;
 use Test::More;
 
 my $tempdir   = TestLib::tempdir;
-my $tempdir_short = TestLib::tempdir_short;
 
 ###
 # This structure is based off of the src/bin/pg_dump/t test
-- 
2.18.0