Re: XLogInsert() of dangling pointer while logging replica identity
On 2019-02-01 10:38:49 +0900, Michael Paquier wrote: > On Thu, Jan 31, 2019 at 11:51:36PM +0300, Stas Kelvich wrote: > > It seems that heapam.c:3082 calls XLogRegisterData() with an argument > > allocated on stack, but following call to XLogInsert() happens after > > end of context for that variable. > > Issue spotted by clang's AddressSanitizer. Fix attached. > > Oh, good catch. Committed and back-patched down to 9.4. Thanks Stas and Michael!
Re: XLogInsert() of dangling pointer while logging replica identity
On Thu, Jan 31, 2019 at 11:51:36PM +0300, Stas Kelvich wrote: > It seems that heapam.c:3082 calls XLogRegisterData() with an argument > allocated on stack, but following call to XLogInsert() happens after > end of context for that variable. > Issue spotted by clang's AddressSanitizer. Fix attached. Oh, good catch. Committed and back-patched down to 9.4. -- Michael signature.asc Description: PGP signature
XLogInsert() of dangling pointer while logging replica identity
Hi, hackers. It seems that heapam.c:3082 calls XLogRegisterData() with an argument allocated on stack, but following call to XLogInsert() happens after end of context for that variable. Issue spotted by clang's AddressSanitizer. Fix attached. -- Stas Kelvich Postgres Professional: http://www.postgrespro.com The Russian Postgres Company 0001-Fix-use-after-scope.patch Description: Binary data