Re: backtrace_functions emits trace for any elog

2023-09-04 Thread Noah Misch
On Mon, Sep 04, 2023 at 09:30:32PM +0100, Ilya Gladyshev wrote:
> I used backtrace_functions to debug one of my ideas and found its behavior 
> counter-intuitive and contradictory to it own docs. I think the GUC is 
> supposed to be used to dump backtrace only on elog(ERROR) (should it also be 
> done for higher levels? not sure about this), but, in fact, it does that for 
> any log-level. I have attached a patch that checks log-level before attaching 
> backtrace.

This would make the feature much less useful.  Better to change the docs.




backtrace_functions emits trace for any elog

2023-09-04 Thread Ilya Gladyshev
Hi,
I used backtrace_functions to debug one of my ideas and found its behavior 
counter-intuitive and contradictory to it own docs. I think the GUC is supposed 
to be used to dump backtrace only on elog(ERROR) (should it also be done for 
higher levels? not sure about this), but, in fact, it does that for any 
log-level. I have attached a patch that checks log-level before attaching 
backtrace.

Regards,
Ilya


0001-check-elevel-before-attaching-backtrace.patch
Description: Binary data