Re: contrib/spi/insert_username.c comment typo?

2023-05-28 Thread John Naylor
On Mon, May 29, 2023 at 11:31 AM jian he 
wrote:
> hi.
> reading through contrib/spi/insert_username.c
>
https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=contrib/spi/insert_username.c;h=a2e1747ff74c7667665dcc334f54ad368885d83c;hb=HEAD
> 36 /* sanity checks from autoinc.c */
> 37 if (!CALLED_AS_TRIGGER(fcinfo))
> 38 /* internal error */
> 39 elog(ERROR, "insert_username: not fired by trigger manager");
>
> should it be  /* sanity checks from insert_username.c */ ?

I believe it's saying the checks were copied from autoinc.c.

--
John Naylor
EDB: http://www.enterprisedb.com


contrib/spi/insert_username.c comment typo?

2023-05-28 Thread jian he
hi.
reading through contrib/spi/insert_username.c
https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=contrib/spi/insert_username.c;h=a2e1747ff74c7667665dcc334f54ad368885d83c;hb=HEAD
36

/* sanity checks from autoinc.c */
37

if (!CALLED_AS_TRIGGER(fcinfo))
38

/* internal error */
39

elog(ERROR, "insert_username: not fired by trigger manager");

should it be  /* sanity checks from insert_username.c */ ?