Re: file_fdw vs relative paths

[Magnus Hagander]

On Wed, Sep 9, 2020 at 3:39 AM Ian Barwick 
wrote:

> Hi
>
> On 2020/09/07 2:31, Magnus Hagander wrote:
> > On Mon, Aug 31, 2020 at 5:03 PM Bruce Momjian  br...@momjian.us>> wrote:
> >
> > On Mon, Aug 31, 2020 at 01:16:05PM +0200, Magnus Hagander wrote:
> >  > Bruce, I've applied and backpatched your docs patch for this.
> >  >
> >  > Gah, and of course right after doing that, I remembered I wanted
> to get a
> >  > second change in :) To solve the "who's this Josh" question, I
> suggest we also
> >  > change the example to point to the data/log directory which is
> likely to exist
> >  > in a lot more of the cases. I keep getting people who ask "who is
> josh" based
> >  > on the /home/josh path. Not that it's that important, but...
> >
> > Thanks, and agreed.
> >
> >
> > Thanks, applied. I backpacked to 13 but didn't bother with the rest as
> it's not technically *wrong* before..
>
> It's missing the leading single quote from the filename parameter:
>
>  diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
>  (...)
>  -OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' );
>  +OPTIONS ( filename log/pglog.csv', format 'csv' );
>  (...)
>

GAH.

Thanks!


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: file_fdw vs relative paths

[Ian Barwick]

Hi

On 2020/09/07 2:31, Magnus Hagander wrote:

On Mon, Aug 31, 2020 at 5:03 PM Bruce Momjian mailto:br...@momjian.us>> wrote:

On Mon, Aug 31, 2020 at 01:16:05PM +0200, Magnus Hagander wrote:
 >     Bruce, I've applied and backpatched your docs patch for this.
 >
 > Gah, and of course right after doing that, I remembered I wanted to get a
 > second change in :) To solve the "who's this Josh" question, I suggest 
we also
 > change the example to point to the data/log directory which is likely to 
exist
 > in a lot more of the cases. I keep getting people who ask "who is josh" 
based
 > on the /home/josh path. Not that it's that important, but...

Thanks, and agreed.


Thanks, applied. I backpacked to 13 but didn't bother with the rest as it's not 
technically *wrong* before..


It's missing the leading single quote from the filename parameter:

diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
(...)
-OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' );
+OPTIONS ( filename log/pglog.csv', format 'csv' );
(...)


Regards


Ian Barwick


--
Ian Barwick   https://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Re: file_fdw vs relative paths

[Magnus Hagander]

On Mon, Aug 31, 2020 at 5:03 PM Bruce Momjian  wrote:

> On Mon, Aug 31, 2020 at 01:16:05PM +0200, Magnus Hagander wrote:
> > Bruce, I've applied and backpatched your docs patch for this.
> >
> > Gah, and of course right after doing that, I remembered I wanted to get a
> > second change in :) To solve the "who's this Josh" question, I suggest
> we also
> > change the example to point to the data/log directory which is likely to
> exist
> > in a lot more of the cases. I keep getting people who ask "who is josh"
> based
> > on the /home/josh path. Not that it's that important, but...
>
> Thanks, and agreed.
>
>
Thanks, applied. I backpacked to 13 but didn't bother with the rest as it's
not technically *wrong* before..

//Magnus

Re: file_fdw vs relative paths

[Bruce Momjian]

On Mon, Aug 31, 2020 at 01:16:05PM +0200, Magnus Hagander wrote:
> Bruce, I've applied and backpatched your docs patch for this.
> 
> Gah, and of course right after doing that, I remembered I wanted to get a
> second change in :) To solve the "who's this Josh" question, I suggest we also
> change the example to point to the data/log directory which is likely to exist
> in a lot more of the cases. I keep getting people who ask "who is josh" based
> on the /home/josh path. Not that it's that important, but... 

Thanks, and agreed.

-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Re: file_fdw vs relative paths

[Magnus Hagander]

On Mon, Aug 31, 2020 at 1:10 PM Magnus Hagander  wrote:

>
>
> On Tue, Aug 25, 2020 at 9:28 AM Li Japin  wrote:
>
>>
>> On Aug 25, 2020, at 8:26 AM, Bruce Momjian  wrote:
>>
>> Yes, I tested back to 9.5 too:
>>
>> CREATE EXTENSION file_fdw;
>> CREATE SERVER pgconf FOREIGN DATA WRAPPER file_fdw;
>> CREATE FOREIGN TABLE pgconf (line TEXT) SERVER pgconf OPTIONS ( filename
>> 'postgresql.conf', format 'text', delimiter E'\x7f' );
>> SELECT * FROM pgconf;
>>  # -
>>  # PostgreSQL configuration file
>>  # -
>>  #
>>  # This file consists of lines of the form:
>> …
>>
>>
>> The file_fdw extension was introduced by
>> commit 7c5d0ae7078456bfeedb2103c45b9a32285c2631,
>> and I tested it supports relative paths.  This is a doc bug.
>>
>>
> Well technically it can also have been a code bug but yes if so it is one
> that has lived since day 1. But given that nobody has chimed in to say they
> think that's what it is for a month, I think we'll conclude it's a docs
> bug.
>
> Bruce, I've applied and backpatched your docs patch for this.
>
>
Gah, and of course right after doing that, I remembered I wanted to get a
second change in :) To solve the "who's this Josh" question, I suggest we
also change the example to point to the data/log directory which is likely
to exist in a lot more of the cases. I keep getting people who ask "who is
josh" based on the /home/josh path. Not that it's that important, but...

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 
diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index d985ef0a06..8209f3ea6c 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -265,7 +265,7 @@ CREATE FOREIGN TABLE pglog (
   application_name text,
   backend_type text
 ) SERVER pglog
-OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' );
+OPTIONS ( filename log/pglog.csv', format 'csv' );
 
   
 

Re: file_fdw vs relative paths

[Magnus Hagander]

On Tue, Aug 25, 2020 at 9:28 AM Li Japin  wrote:

>
> On Aug 25, 2020, at 8:26 AM, Bruce Momjian  wrote:
>
> Yes, I tested back to 9.5 too:
>
> CREATE EXTENSION file_fdw;
> CREATE SERVER pgconf FOREIGN DATA WRAPPER file_fdw;
> CREATE FOREIGN TABLE pgconf (line TEXT) SERVER pgconf OPTIONS ( filename
> 'postgresql.conf', format 'text', delimiter E'\x7f' );
> SELECT * FROM pgconf;
>  # -
>  # PostgreSQL configuration file
>  # -
>  #
>  # This file consists of lines of the form:
> …
>
>
> The file_fdw extension was introduced by
> commit 7c5d0ae7078456bfeedb2103c45b9a32285c2631,
> and I tested it supports relative paths.  This is a doc bug.
>
>
Well technically it can also have been a code bug but yes if so it is one
that has lived since day 1. But given that nobody has chimed in to say they
think that's what it is for a month, I think we'll conclude it's a docs
bug.

Bruce, I've applied and backpatched your docs patch for this.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: file_fdw vs relative paths

[Li Japin]

On Aug 25, 2020, at 8:26 AM, Bruce Momjian 
mailto:br...@momjian.us>> wrote:

Yes, I tested back to 9.5 too:

CREATE EXTENSION file_fdw;
CREATE SERVER pgconf FOREIGN DATA WRAPPER file_fdw;
CREATE FOREIGN TABLE pgconf (line TEXT) SERVER pgconf OPTIONS ( filename
'postgresql.conf', format 'text', delimiter E'\x7f' );
SELECT * FROM pgconf;
 # -
 # PostgreSQL configuration file
 # -
 #
 # This file consists of lines of the form:
…

The file_fdw extension was introduced by commit 
7c5d0ae7078456bfeedb2103c45b9a32285c2631,
and I tested it supports relative paths.  This is a doc bug.

--
Japin Li

Re: file_fdw vs relative paths

[Bruce Momjian]

On Wed, Jul 15, 2020 at 01:22:21PM +0200, Magnus Hagander wrote:
> According to the documentation, the filename given in file_fdw must be an
> absolute path. Hwever, it works perfectly fine with a relative path.
> 
> So either the documentation is wrong, or the code is wrong. It behaves the 
> same
> at least back to 9.5, I did not try it further back than that.

Yes, I tested back to 9.5 too:

CREATE EXTENSION file_fdw;
CREATE SERVER pgconf FOREIGN DATA WRAPPER file_fdw;
CREATE FOREIGN TABLE pgconf (line TEXT) SERVER pgconf OPTIONS ( filename
'postgresql.conf', format 'text', delimiter E'\x7f' );
SELECT * FROM pgconf;
 # -
 # PostgreSQL configuration file
 # -
 #
 # This file consists of lines of the form:
...

> I can't find a reference to the code that limits this. AFAICT the 
> documentation
> has been there since day 1.
> 
> Question is, which one is right. Is there a reason we'd want to restrict it to
> absolute pathnames?

I think it should work just like COPY, which allows relative paths;  doc
patch attached.

-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index ed028e4ec9..d985ef0a06 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -28,7 +28,8 @@
 

 
- Specifies the file to be read.  Must be an absolute path name.
+ Specifies the file to be read.  Relative paths are relative to the
+ data directory.
  Either filename or program must be
  specified, but not both.
 

file_fdw vs relative paths

[Magnus Hagander]

According to the documentation, the filename given in file_fdw must be an
absolute path. Hwever, it works perfectly fine with a relative path.

So either the documentation is wrong, or the code is wrong. It behaves the
same at least back to 9.5, I did not try it further back than that.

I can't find a reference to the code that limits this. AFAICT the
documentation has been there since day 1.

Question is, which one is right. Is there a reason we'd want to restrict it
to absolute pathnames?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/