Re: pg_verify_checksums review

[sixela]

Hello,

There is a similar utility that I wrote that does offline checksum
verification as well.

https://github.com/google/pg_page_verification

This utility includes a verbose option as well as scanning multiple
subsequent segment files.

Alexis



--
Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html

Re: pg_verify_checksums review

[Magnus Hagander]

On Tue, Jun 19, 2018 at 10:25 AM, Daniel Gustafsson  wrote:

> In looking over pg_verify_checksums I found a few small things that I think
> would improve on it:
>
> * pg_verify_checksums was placed in the Client Utils section in the docs.
> Since it requries physical access to the cluster datafiles it seems to
> belong
> in the Server Utils section.
>

Makes sense.


* The -D option and supported environment variable wasn’t documented.
>

> * Only -D is supported for specifying the data directory, but most all
> other
> utilities also support --pgdata on top of -D.  To present a consistent user
> interface we should probably support --pgdata in pg_verify_checksums as
> well.


> The latter is I assume too invasive as we are past the freeze, but the
> first
> two docs patches would make sense in 11 IMO as they document whats in the
> tree.
>
> The attached patches fixes the above mentioned things (I don’t have a docs
> toolchain working right now so the docs patches are best effort).
>

I believe both those are fine for 11, so I've pushed that. I kept it as a
separate patch to make it easy enough to revert it if people prefer that :)

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

pg_verify_checksums review

[Daniel Gustafsson]

In looking over pg_verify_checksums I found a few small things that I think
would improve on it:

* pg_verify_checksums was placed in the Client Utils section in the docs.
Since it requries physical access to the cluster datafiles it seems to belong
in the Server Utils section.

* The -D option and supported environment variable wasn’t documented.

* Only -D is supported for specifying the data directory, but most all other
utilities also support --pgdata on top of -D.  To present a consistent user
interface we should probably support --pgdata in pg_verify_checksums as well.

The latter is I assume too invasive as we are past the freeze, but the first
two docs patches would make sense in 11 IMO as they document whats in the tree.

The attached patches fixes the above mentioned things (I don’t have a docs
toolchain working right now so the docs patches are best effort).

cheers ./daniel



0001-Move-pg_verify_checksum-from-client-to-server-utils.patch
Description: Binary data


0002-Add-D-option-to-pg_verify_checksum-documentation.patch
Description: Binary data


0003-Add-pgdata-as-alias-for-D-for-consistency.patch
Description: Binary data