Re: pgsql: Generate automatically code and documentation related to wait ev

[Michael Paquier]

On Thu, Oct 19, 2023 at 09:38:30AM +0200, Christoph Berg wrote:
> Thanks for the lightning-fast fix :)

No pb.  Not the first one, not the last one.  ;)
--
Michael


signature.asc
Description: PGP signature

Re: pgsql: Generate automatically code and documentation related to wait ev

[Christoph Berg]

Re: Michael Paquier
> Will fix as per the attached.  Thanks for the report.

Thanks for the lightning-fast fix :)

Christoph

Re: pgsql: Generate automatically code and documentation related to wait ev

[Michael Paquier]

On Wed, Oct 18, 2023 at 05:59:19PM +0200, Christoph Berg wrote:
> I'm not entirely sure this is the commit to blame, but it's certainly
> close:

That would be in this area, thanks for the report.

> A Debian user is complaining that in PG17, the installed
> /usr/include/postgresql/17/server/utils/wait_event.h file is
> referencing utils/wait_event_types.h, but that file doesn't get
> installed by the (autoconf) build sytem.

On a fresh install of HEAD (3f9b1f26ca), I get:
$ cd $(pg_config --includedir-server)
$ find . -name wait_event.h
./utils/wait_event.h
$ find . -name wait_event_types.h
./utils/wait_event_types.h

But I have missed a piece related to VPATH builds for
wait_event_types.h in src/include/Makefile (see around probes.h).
Will fix as per the attached.  Thanks for the report.
--
Michael
diff --git a/src/include/Makefile b/src/include/Makefile
index 2d5242561c..a7ca277803 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -54,7 +54,7 @@ install: all installdirs
 	  $(INSTALL_DATA) $(srcdir)/$$dir/*.h '$(DESTDIR)$(includedir_server)'/$$dir || exit; \
 	done
 ifeq ($(vpath_build),yes)
-	for file in catalog/schemapg.h catalog/system_fk_info.h catalog/pg_*_d.h storage/lwlocknames.h utils/probes.h; do \
+	for file in catalog/schemapg.h catalog/system_fk_info.h catalog/pg_*_d.h storage/lwlocknames.h utils/probes.h utils/wait_event_types.h; do \
 	  $(INSTALL_DATA) $$file '$(DESTDIR)$(includedir_server)'/$$file || exit; \
 	done
 endif


signature.asc
Description: PGP signature

Re: pgsql: Generate automatically code and documentation related to wait ev

[Christoph Berg]

Re: Michael Paquier
> Generate automatically code and documentation related to wait events

Hi,

I'm not entirely sure this is the commit to blame, but it's certainly
close:

A Debian user is complaining that in PG17, the installed
/usr/include/postgresql/17/server/utils/wait_event.h file is
referencing utils/wait_event_types.h, but that file doesn't get
installed by the (autoconf) build sytem.

See
https://pgdgbuild.dus.dg-i.net/job/postgresql-17-binaries-snapshot/242/architecture=amd64,distribution=sid/consoleText
for a build log with file listings near the end.

Christoph