fix a comment

[wangyu...@fujitsu.com]

Hi, Hackers:

In function ExecGetTriggerResultRel, we can see comments:

> /* First, search through the query result relations */ ...
> /*
> * Third, search through the result relations that were created during
> * tuple routing, if any.
> */

But the 'Second' was deleted since commit 1375422c78.

Update the 'Third' to 'Second', please see the attachment.

Thoughts?

Best wishes
Yukun Wang



fix-a-typo.diff
Description: fix-a-typo.diff

RE: fix a comment

[wangyu...@fujitsu.com]

Hi, Amul

Thank you for reviewing.

> How about simply removing these numbering?

Agree. Please see the v2 patch which delete the number in comment.

Best wishes
Yukun Wang

-Original Message-
From: Amul Sul  
Sent: Friday, April 23, 2021 3:51 PM
To: Wang, Yukun/王 俞坤 
Cc: pgsql-hack...@postgresql.org
Subject: Re: fix a comment

On Fri, Apr 23, 2021 at 12:12 PM wangyu...@fujitsu.com  
wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> > * Third, search through the result relations that were created 
> > during
> > * tuple routing, if any.
> > */
>
> But the 'Second' was deleted since commit 1375422c78.
>
> Update the 'Third' to 'Second', please see the attachment.
>
> Thoughts?
>

Well yes, looks good to me.

How about simply removing these numbering?

Regards,
Amul


fix-a-comment.diff
Description: fix-a-comment.diff

add 'noError' to euc_tw_and_big5.c

[wangyu...@fujitsu.com]

Hi, Heikki

'noError' argument was added at commit ea1b99a661,
but it seems to be neglected in euc_tw_and_big5.c Line 289.
please see the attachment.

Regards,
Yukun Wang


add-noError.patch
Description: add-noError.patch