Re: [HACKERS] [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié abr 27 17:10:37 -0300 2011:
> Alvaro Herrera  writes:
> > Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
> >> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.
> 
> > Apparently this change is causing Moa's SunStudio compiler to fail an
> > assertion.
> 
> [ scratches head... ]  Hard to see why, there's nothing at all
> interesting in that code.

I agree, but it fails exactly in that code, and started to fail
immediately after that patch.

Maybe casting the 2 to int64 would fix it?

-- 
Álvaro Herrera 
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-27 Thread Tom Lane
Alvaro Herrera  writes:
> Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
>> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.

> Apparently this change is causing Moa's SunStudio compiler to fail an
> assertion.

[ scratches head... ]  Hard to see why, there's nothing at all
interesting in that code.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers