Re: [HACKERS] [patch] Reformat permissions in \l+ (like \z does)
On Wed, 31 Dec 2008 13:08:20 -0500 Tom Lane wrote: Andreas 'ads' Scherbaum adsm...@wars-nicht.de writes: On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote: If we're going to do this, shouldn't it happen uniformly for *all* ACL displays in describe.c? Makes sense, imho. Done. Oh, thanks. The updated patch was on my todo. Kind regards -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [patch] Reformat permissions in \l+ (like \z does)
Andreas 'ads' Scherbaum adsm...@wars-nicht.de writes: On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote: If we're going to do this, shouldn't it happen uniformly for *all* ACL displays in describe.c? Makes sense, imho. Done. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [patch] Reformat permissions in \l+ (like \z does)
On Sun, 28 Dec 2008 18:19:48 -0500 Tom Lane wrote: Andreas 'ads' Scherbaum adsm...@wars-nicht.de writes: the march 2008 commitfest added a patch[1] with extended information for \l+. The may 2008 commitfest added a patch[2] which reformats the permission output in \z. I like the new output in \z, but the \l+ output is still missing this feature. The attached patch solves this problem. If we're going to do this, shouldn't it happen uniformly for *all* ACL displays in describe.c? Makes sense, imho. I just stumbled over this one by checking the list of new patches for 8.4. Other opinions? Kind regards -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [patch] Reformat permissions in \l+ (like \z does)
Andreas 'ads' Scherbaum adsm...@wars-nicht.de writes: the march 2008 commitfest added a patch[1] with extended information for \l+. The may 2008 commitfest added a patch[2] which reformats the permission output in \z. I like the new output in \z, but the \l+ output is still missing this feature. The attached patch solves this problem. If we're going to do this, shouldn't it happen uniformly for *all* ACL displays in describe.c? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] [patch] Reformat permissions in \l+ (like \z does)
Hello, the march 2008 commitfest added a patch[1] with extended information for \l+. The may 2008 commitfest added a patch[2] which reformats the permission output in \z. I like the new output in \z, but the \l+ output is still missing this feature. The attached patch solves this problem. Kind regards 1: http://archives.postgresql.org/message-id/488c2fe3-a6c7-4cfa-bd3c-f0588da81...@tcpd.net 2: http://archives.postgresql.org/message-id/37ed240d0804170921h7a6b92fev65aeb99f658f8...@mail.gmail.com -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors *** src/bin/psql/describe.c 2008-12-21 13:19:40.0 +0100 --- src/bin/psql/describe.c.orig 2008-12-21 02:16:31.0 +0100 *** *** 464,476 d.datctype as \%s\,\n, gettext_noop(Collation), gettext_noop(Ctype)); ! if (pset.sversion = 80100) ! appendPQExpBuffer(buf, ! pg_catalog.array_to_string(d.datacl, E'\\n') as \%s\, ! gettext_noop(Access Privileges)); ! else ! appendPQExpBuffer(buf, ! pg_catalog.array_to_string(d.datacl, '\\n') as \%s\, gettext_noop(Access Privileges)); if (verbose pset.sversion = 80200) appendPQExpBuffer(buf, --- 464,471 d.datctype as \%s\,\n, gettext_noop(Collation), gettext_noop(Ctype)); ! appendPQExpBuffer(buf, ! d.datacl as \%s\, gettext_noop(Access Privileges)); if (verbose pset.sversion = 80200) appendPQExpBuffer(buf, -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
