Re: [HACKERS] Anyone want to update our Windows timezone map?

[Magnus Hagander]

On Thu, Aug 18, 2016 at 3:30 PM, Tom Lane  wrote:

> Magnus Hagander  writes:
> > On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane  wrote:
> >> If we got this done in the next couple weeks, any resulting changes
> >> could go out in 9.6rc1.  Given that we've not done this routinely,
> >> that seems like a better plan than having them first hit the field
> >> in minor releases of stable branches.
>
> > I read that as we want it out in RC1 and make sure that works before we
> > backpatch it to earlier branches.
>
> I think we might as well back-patch now so we don't forget to do so.
> rc1 will give us a chance to discover any problems, but if there are
> any, we'd back-patch those fixes too.
>

OK, fair enough if you think so. I'll go ahead and do that right away.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Tom Lane]

Magnus Hagander  writes:
> Done. I skipped 9.1 given it's status and that the backpatch didn't apply
> cleanly there (we moved code around).

I think the same code exists in a different file in 9.1, but I concur
that it's probably not worth a lot of effort.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Magnus Hagander]

On Thu, Aug 18, 2016 at 3:34 PM, Magnus Hagander 
wrote:

>
>
> On Thu, Aug 18, 2016 at 3:30 PM, Tom Lane  wrote:
>
>> Magnus Hagander  writes:
>> > On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane  wrote:
>> >> If we got this done in the next couple weeks, any resulting changes
>> >> could go out in 9.6rc1.  Given that we've not done this routinely,
>> >> that seems like a better plan than having them first hit the field
>> >> in minor releases of stable branches.
>>
>> > I read that as we want it out in RC1 and make sure that works before we
>> > backpatch it to earlier branches.
>>
>> I think we might as well back-patch now so we don't forget to do so.
>> rc1 will give us a chance to discover any problems, but if there are
>> any, we'd back-patch those fixes too.
>>
>
> OK, fair enough if you think so. I'll go ahead and do that right away.
>
>
Done. I skipped 9.1 given it's status and that the backpatch didn't apply
cleanly there (we moved code around).

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Tom Lane]

Magnus Hagander  writes:
> On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane  wrote:
>> If we got this done in the next couple weeks, any resulting changes
>> could go out in 9.6rc1.  Given that we've not done this routinely,
>> that seems like a better plan than having them first hit the field
>> in minor releases of stable branches.

> I read that as we want it out in RC1 and make sure that works before we
> backpatch it to earlier branches.

I think we might as well back-patch now so we don't forget to do so.
rc1 will give us a chance to discover any problems, but if there are
any, we'd back-patch those fixes too.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Magnus Hagander]

On Thu, Aug 18, 2016 at 3:26 PM, Tom Lane  wrote:

> Magnus Hagander  writes:
> > On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier <
> michael.paqu...@gmail.com>
> > wrote:
> >> OK, so after re-running that on my Win10 station and a newly updated
> >> Win7 station I am finishing with the attached that combines all the
> >> changes.
>
> > Thanks, pushed for master and 9.6.
>
> My thought was to push it in all branches --- that's what we do for
> other timezone data updates.
>

Your initial comment was:

> If we got this done in the next couple weeks, any resulting changes
> could go out in 9.6rc1.  Given that we've not done this routinely,
> that seems like a better plan than having them first hit the field
> in minor releases of stable branches.

I read that as we want it out in RC1 and make sure that works before we
backpatch it to earlier branches.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Tom Lane]

Magnus Hagander  writes:
> On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier 
> wrote:
>> OK, so after re-running that on my Win10 station and a newly updated
>> Win7 station I am finishing with the attached that combines all the
>> changes.

> Thanks, pushed for master and 9.6.

My thought was to push it in all branches --- that's what we do for
other timezone data updates.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Michael Paquier]

On Thu, Aug 18, 2016 at 7:38 PM, Magnus Hagander  wrote:
> Thanks, pushed for master and 9.6.

Cool. Thanks for the commit.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Magnus Hagander]

On Thu, Aug 18, 2016 at 7:06 AM, Michael Paquier 
wrote:

> On Tue, Aug 16, 2016 at 6:22 PM, Magnus Hagander 
> wrote:
> > I think what we want is basically the UNION ALL of all the different
> active
> > versions. If we just use the definitions from Win10, we will map
> incorrectly
> > on Win7. As long as they are not *conflicting*, we should just add them
> all.
>
> I see, so that's why the script does not do any suggestions to remove any
> data.
>

Yup.



> > The UTC->GMT switch is mostly just annoying as it only hits the comments,
> > right? I think we just accept that change and do a once-over patch that
> > changes all those things.
>
> OK, so after re-running that on my Win10 station and a newly updated
> Win7 station I am finishing with the attached that combines all the
> changes.
>
>
Thanks, pushed for master and 9.6.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Michael Paquier]

On Tue, Aug 16, 2016 at 6:22 PM, Magnus Hagander  wrote:
> I think what we want is basically the UNION ALL of all the different active
> versions. If we just use the definitions from Win10, we will map incorrectly
> on Win7. As long as they are not *conflicting*, we should just add them all.

I see, so that's why the script does not do any suggestions to remove any data.

> The UTC->GMT switch is mostly just annoying as it only hits the comments,
> right? I think we just accept that change and do a once-over patch that
> changes all those things.

OK, so after re-running that on my Win10 station and a newly updated
Win7 station I am finishing with the attached that combines all the
changes.
-- 
Michael


win32-tz-v2.patch
Description: application/download

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Magnus Hagander]

On Tue, Aug 16, 2016 at 11:15 AM, Michael Paquier  wrote:

> On Tue, Aug 16, 2016 at 9:14 AM, Michael Paquier
>  wrote:
> > On Tue, Aug 16, 2016 at 4:19 AM, Tom Lane  wrote:
> >> We have certainly not been doing that on a regular basis (as best I can
> >> tell, no such changes have been made since 2010).  Does anybody who uses
> >> Windows want to deal with it?  Or at least do it once so that our
> Windows
> >> TZ info is less than 5 years out of date?
> >
> > It would be a good idea to refresh that.
> >
> >> If we got this done in the next couple weeks, any resulting changes
> >> could go out in 9.6rc1.  Given that we've not done this routinely,
> >> that seems like a better plan than having them first hit the field
> >> in minor releases of stable branches.
> >
> > Agreed. I'll try to give it a shot in the next couple of days at worst.
>
> I ran the script on my Win10 station, and saw the attached output,
> which results in the patch attached once changes are applied. Results
> can be visibly quite different depending on the station used though,
> Win7 reports other things. Still my guess is that we'd want Win10 as a
> base. Note as well that the registry has switched to UTC instead of
> GMT. Thoughts?
>

I think what we want is basically the UNION ALL of all the different active
versions. If we just use the definitions from Win10, we will map
incorrectly on Win7. As long as they are not *conflicting*, we should just
add them all.

The UTC->GMT switch is mostly just annoying as it only hits the comments,
right? I think we just accept that change and do a once-over patch that
changes all those things.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Michael Paquier]

On Tue, Aug 16, 2016 at 9:14 AM, Michael Paquier
 wrote:
> On Tue, Aug 16, 2016 at 4:19 AM, Tom Lane  wrote:
>> We have certainly not been doing that on a regular basis (as best I can
>> tell, no such changes have been made since 2010).  Does anybody who uses
>> Windows want to deal with it?  Or at least do it once so that our Windows
>> TZ info is less than 5 years out of date?
>
> It would be a good idea to refresh that.
>
>> If we got this done in the next couple weeks, any resulting changes
>> could go out in 9.6rc1.  Given that we've not done this routinely,
>> that seems like a better plan than having them first hit the field
>> in minor releases of stable branches.
>
> Agreed. I'll try to give it a shot in the next couple of days at worst.

I ran the script on my Win10 station, and saw the attached output,
which results in the patch attached once changes are applied. Results
can be visibly quite different depending on the station used though,
Win7 reports other things. Still my guess is that we'd want Win10 as a
base. Note as well that the registry has switched to UTC instead of
GMT. Thoughts?
-- 
Michael
Timezone Afghanistan Standard Time changed displayname ('(UTC+04:30) Kabul' 
from '(GMT+04:30) Kabul')!
Timezone Alaskan Standard Time changed displayname ('(UTC-09:00) Alaska' from 
'(GMT-09:00) Alaska')!
Timezone Arab Standard Time changed displayname ('(UTC+03:00) Kuwait, Riyadh' 
from '(GMT+03:00) Kuwait, Riyadh')!
Timezone Arabian Standard Time changed displayname ('(UTC+04:00) Abu Dhabi, 
Muscat' from '(GMT+04:00) Abu Dhabi, Muscat')!
Timezone Arabic Standard Time changed displayname ('(UTC+03:00) Baghdad' from 
'(GMT+03:00) Baghdad')!
Timezone Argentina Standard Time changed displayname ('(UTC-03:00) City of 
Buenos Aires' from '(GMT-03:00) Buenos Aires')!
Timezone Atlantic Standard Time changed displayname ('(UTC-04:00) Atlantic Time 
(Canada)' from '(GMT-04:00) Atlantic Time (Canada)')!
Timezone AUS Central Standard Time changed displayname ('(UTC+09:30) Darwin' 
from '(GMT+09:30) Darwin')!
Timezone AUS Eastern Standard Time changed displayname ('(UTC+10:00) Canberra, 
Melbourne, Sydney' from '(GMT+10:00) Canberra, Melbourne, Sydney')!
Timezone Azerbaijan Standard Time changed displayname ('(UTC+04:00) Baku' from 
'(GMT+04:00) Baku')!
Timezone Azores Standard Time changed displayname ('(UTC-01:00) Azores' from 
'(GMT-01:00) Azores')!
Timezone Bangladesh Standard Time changed displayname ('(UTC+06:00) Dhaka' from 
'(GMT+06:00) Dhaka')!
Timezone Canada Central Standard Time changed displayname ('(UTC-06:00) 
Saskatchewan' from '(GMT-06:00) Saskatchewan')!
Timezone Caucasus Standard Time changed displayname ('(UTC+04:00) Yerevan' from 
'(GMT+04:00) Baku, Tbilisi, Yerevan')!
Timezone Cen. Australia Standard Time changed displayname ('(UTC+09:30) 
Adelaide' from '(GMT+09:30) Adelaide')!
Timezone Central America Standard Time changed displayname ('(UTC-06:00) 
Central America' from '(GMT-06:00) Central America')!
Timezone Central Asia Standard Time changed displayname ('(UTC+06:00) Astana' 
from '(GMT+06:00) Astana, Dhaka')!
Timezone Central Brazilian Standard Time changed displayname ('(UTC-04:00) 
Cuiaba' from '(GMT-04:00) Cuiaba')!
Timezone Central Europe Standard Time changed displayname ('(UTC+01:00) 
Belgrade, Bratislava, Budapest, Ljubljana, Prague' from '(GMT+01:00) Belgrade, 
Bratislava, Budapest,  Ljubljana, Prague')!
Timezone Central European Standard Time changed displayname ('(UTC+01:00) 
Sarajevo, Skopje, Warsaw, Zagreb' from '(GMT+01:00) Sarajevo, Skopje, Warsaw,  
Zagreb')!
Timezone Central Pacific Standard Time changed displayname ('(UTC+11:00) 
Solomon Is., New Caledonia' from '(GMT+11:00) Magadan, Solomon Is., New  
Caledonia')!
Timezone Central Standard Time changed displayname ('(UTC-06:00) Central Time 
(US & Canada)' from '(GMT-06:00) Central Time (US & Canada)')!
Timezone Central Standard Time (Mexico) changed displayname ('(UTC-06:00) 
Guadalajara, Mexico City, Monterrey' from '(GMT-06:00) Guadalajara, Mexico 
City,  Monterrey - New')!
Timezone China Standard Time changed displayname ('(UTC+08:00) Beijing, 
Chongqing, Hong Kong, Urumqi' from '(GMT+08:00) Beijing, Chongqing, Hong Kong,  
Urumqi')!
Timezone Dateline Standard Time changed displayname ('(UTC-12:00) International 
Date Line West' from '(GMT-12:00) International Date Line West')!
Timezone E. Africa Standard Time changed displayname ('(UTC+03:00) Nairobi' 
from '(GMT+03:00) Nairobi')!
Timezone E. Australia Standard Time changed displayname ('(UTC+10:00) Brisbane' 
from '(GMT+10:00) Brisbane')!
Timezone E. Europe Standard Time changed displayname ('(UTC+02:00) E. Europe' 
from '(GMT+02:00) Bucharest')!
Timezone E. South America Standard Time changed displayname ('(UTC-03:00) 
Brasilia' from '(GMT-03:00) Brasilia')!
Timezone Eastern Standard Time changed displayname ('(UTC-05:00) Eastern Time 
(US & Canada)' from '(GMT-05:00) Eastern Time (US & Canada)')!
Timezone 

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Michael Paquier]

On Tue, Aug 16, 2016 at 4:19 AM, Tom Lane  wrote:
> We have certainly not been doing that on a regular basis (as best I can
> tell, no such changes have been made since 2010).  Does anybody who uses
> Windows want to deal with it?  Or at least do it once so that our Windows
> TZ info is less than 5 years out of date?

It would be a good idea to refresh that.

> If we got this done in the next couple weeks, any resulting changes
> could go out in 9.6rc1.  Given that we've not done this routinely,
> that seems like a better plan than having them first hit the field
> in minor releases of stable branches.

Agreed. I'll try to give it a shot in the next couple of days at worst.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Tom Lane]

Thomas Munro  writes:
> On Tue, Aug 16, 2016 at 7:19 AM, Tom Lane  wrote:
>> We have certainly not been doing that on a regular basis (as best I can
>> tell, no such changes have been made since 2010).  Does anybody who uses
>> Windows want to deal with it?  Or at least do it once so that our Windows
>> TZ info is less than 5 years out of date?

> By the way, I noticed that Unicode CLDR publishes this data set which
> seems to be the same sort of thing:
> http://www.unicode.org/cldr/charts/29/supplemental/zone_tzid.html

> Could that be a better source than dumping stuff from arbitrary
> Windows versions?

Well, the point is that we need to recognize the timezone names that
Windows actually uses.  A list of strings that's more or less the same
doesn't really cut it ...

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Anyone want to update our Windows timezone map?

[Thomas Munro]

On Tue, Aug 16, 2016 at 7:19 AM, Tom Lane  wrote:
> src/timezone/README saith
>
>   When there has been a new release of Windows (probably including Service
>   Packs), the list of matching timezones need to be updated. Run the
>   script in src/tools/win32tzlist.pl on a Windows machine running this new
>   release and apply any new timezones that it detects. Never remove any
>   mappings in case they are removed in Windows, since we still need to
>   match properly on the old version.
>
> We have certainly not been doing that on a regular basis (as best I can
> tell, no such changes have been made since 2010).  Does anybody who uses
> Windows want to deal with it?  Or at least do it once so that our Windows
> TZ info is less than 5 years out of date?

By the way, I noticed that Unicode CLDR publishes this data set which
seems to be the same sort of thing:

http://www.unicode.org/cldr/charts/29/supplemental/zone_tzid.html

Could that be a better source than dumping stuff from arbitrary
Windows versions?

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Anyone want to update our Windows timezone map?

[Tom Lane]

src/timezone/README saith

  When there has been a new release of Windows (probably including Service
  Packs), the list of matching timezones need to be updated. Run the
  script in src/tools/win32tzlist.pl on a Windows machine running this new
  release and apply any new timezones that it detects. Never remove any
  mappings in case they are removed in Windows, since we still need to
  match properly on the old version.

We have certainly not been doing that on a regular basis (as best I can
tell, no such changes have been made since 2010).  Does anybody who uses
Windows want to deal with it?  Or at least do it once so that our Windows
TZ info is less than 5 years out of date?

If we got this done in the next couple weeks, any resulting changes
could go out in 9.6rc1.  Given that we've not done this routinely,
that seems like a better plan than having them first hit the field
in minor releases of stable branches.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers