Re: [HACKERS] Comment typo

[Etsuro Fujita]

On 2017/10/30 22:39, Magnus Hagander wrote:
On Mon, Oct 30, 2017 at 3:49 AM, Etsuro Fujita 
> wrote:


Here is a patch to fix a typo in a comment in partition.c:
s/specificiation/specification/.


Applied, thanks.


Thank you!

Best regards,
Etsuro Fujita



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Magnus Hagander]

On Mon, Oct 30, 2017 at 3:49 AM, Etsuro Fujita 
wrote:

> Here is a patch to fix a typo in a comment in partition.c:
> s/specificiation/specification/.
>

Applied, thanks.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

[HACKERS] Comment typo

[Etsuro Fujita]

Here is a patch to fix a typo in a comment in partition.c: 
s/specificiation/specification/.


Best regards,
Etsuro Fujita
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
index 07fdf66..e234167 100644
--- a/src/backend/catalog/partition.c
+++ b/src/backend/catalog/partition.c
@@ -703,7 +703,7 @@ partition_bounds_equal(int partnatts, int16 *parttyplen, 
bool *parttypbyval,
 
 /*
  * Return a copy of given PartitionBoundInfo structure. The data types of 
bounds
- * are described by given partition key specificiation.
+ * are described by given partition key specification.
  */
 extern PartitionBoundInfo
 partition_bounds_copy(PartitionBoundInfo src,

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Etsuro Fujita]

On 2017/10/05 21:48, Robert Haas wrote:

On Thu, Oct 5, 2017 at 6:11 AM, Etsuro Fujita
 wrote:

Here is a small patch to fix a typo in a comment in partition.c:
s/mantain/maintain/.


Committed.


Thanks!

Best regards,
Etsuro Fujita



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Robert Haas]

On Thu, Oct 5, 2017 at 6:11 AM, Etsuro Fujita
 wrote:
> Here is a small patch to fix a typo in a comment in partition.c:
> s/mantain/maintain/.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo

[Etsuro Fujita]

Here is a small patch to fix a typo in a comment in partition.c: 
s/mantain/maintain/.


Best regards,
Etsuro Fujita
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
index 1ab6dba..9777d40 100644
--- a/src/backend/catalog/partition.c
+++ b/src/backend/catalog/partition.c
@@ -1236,7 +1236,7 @@ RelationGetPartitionDispatchInfo(Relation rel,
  * get_partition_dispatch_recurse
  * Recursively expand partition tree rooted at rel
  *
- * As the partition tree is expanded in a depth-first manner, we mantain two
+ * As the partition tree is expanded in a depth-first manner, we maintain two
  * global lists: of PartitionDispatch objects corresponding to partitioned
  * tables in *pds and of the leaf partition OIDs in *leaf_part_oids.
  *

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in plannodes.h

[Etsuro Fujita]

On 2017/08/11 2:18, Robert Haas wrote:

On Thu, Aug 10, 2017 at 8:25 AM, Etsuro Fujita
 wrote:

Here is a small patch for fixing a comment typo in plannodes.h: s/all the
partitioned table/all the partitioned tables/.


Committed.


Thank you.

Best regards,
Etsuro Fujita



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in plannodes.h

[Robert Haas]

On Thu, Aug 10, 2017 at 8:25 AM, Etsuro Fujita
 wrote:
> Here is a small patch for fixing a comment typo in plannodes.h: s/all the
> partitioned table/all the partitioned tables/.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in plannodes.h

[Etsuro Fujita]

Hi,

Here is a small patch for fixing a comment typo in plannodes.h: s/all 
the partitioned table/all the partitioned tables/.


Best regards,
Etsuro Fujita
diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h
index f1a1b24..7c51e7f 100644
--- a/src/include/nodes/plannodes.h
+++ b/src/include/nodes/plannodes.h
@@ -67,7 +67,7 @@ typedef struct PlannedStmt
 
/*
 * rtable indexes of non-leaf target relations for UPDATE/DELETE on all
-* the partitioned table mentioned in the query.
+* the partitioned tables mentioned in the query.
 */
List   *nonleafResultRelations;
 

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in execMain.c

[Heikki Linnakangas]

On 06/21/2017 11:35 AM, Etsuro Fujita wrote:

Here is a patch to fix a typo in a comment in ExecWithCheckOptions():
s/as as/as/.


Fixed, thanks!

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in execMain.c

[Etsuro Fujita]

Here is a patch to fix a typo in a comment in ExecWithCheckOptions(): 
s/as as/as/.


Best regards,
Etsuro Fujita
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index 7f460bd..9dbe175 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -2093,8 +2093,8 @@ ExecWithCheckOptions(WCOKind kind, ResultRelInfo 
*resultRelInfo,
 * the permissions on the relation 
(that is, if the user
 * could view it directly anyway).  For 
RLS violations, we
 * don't include the data since we 
don't know if the user
-* should be able to view the tuple as 
as that depends on
-* the USING policy.
+* should be able to view the tuple as 
that depends on the
+* USING policy.
 */
case WCO_VIEW_CHECK:
insertedCols = 
GetInsertedColumns(resultRelInfo, estate);

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in xlogutils.c

[Peter Eisentraut]

On 4/15/17 11:26, Masahiko Sawada wrote:
> Attached patch for $subject.
> 
> s/apruptly/abruptly

Fixed, thanks.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in xlogutils.c

[Masahiko Sawada]

Hi,

Attached patch for $subject.

s/apruptly/abruptly

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


fix_typo_in_xlogutils_c.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in publicationcmd.c

[Magnus Hagander]

On Fri, Apr 7, 2017 at 9:00 AM, Masahiko Sawada 
wrote:

> Hi all,
>
> Attached fixes a typo in publicationcmd.c file.
>
> s/om/on/
>

Applied, thanks.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

[HACKERS] Comment typo in publicationcmd.c

[Masahiko Sawada]

Hi all,

Attached fixes a typo in publicationcmd.c file.

s/om/on/

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


fix_typo_in_publicationcmds_c.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in logical/worker.c

[Peter Eisentraut]

On 4/3/17 02:11, Masahiko Sawada wrote:
> Attached fixes a comment typo in logical/worker.c file.

committed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in logical/worker.c

[Masahiko Sawada]

Hi,

Attached fixes a comment typo in logical/worker.c file.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


fix_typo_logical_worker_c.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Amit Langote]

On 2016/10/12 18:10, Heikki Linnakangas wrote:
> On 10/11/2016 08:52 AM, Amit Langote wrote:
>> Attached fixes what seems like a copy-pasto in pg_cast.h.
> 
> Applied, thanks.

Thanks, Heikki!

Regards,
Amit




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Heikki Linnakangas]

On 10/11/2016 08:52 AM, Amit Langote wrote:

Attached fixes what seems like a copy-pasto in pg_cast.h.


Applied, thanks.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo

[Amit Langote]

Attached fixes what seems like a copy-pasto in pg_cast.h.

Thanks,
Amit
diff --git a/src/include/catalog/pg_cast.h b/src/include/catalog/pg_cast.h
index ee568d8..04d11c0 100644
--- a/src/include/catalog/pg_cast.h
+++ b/src/include/catalog/pg_cast.h
@@ -59,7 +59,7 @@ typedef enum CoercionCodes
 
 /*
  * The allowable values for pg_cast.castmethod are specified by this enum.
- * Since castcontext is stored as a "char", we use ASCII codes for human
+ * Since castmethod is stored as a "char", we use ASCII codes for human
  * convenience in reading the table.
  */
 typedef enum CoercionMethod

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in execIndexing.c

[Robert Haas]

On Tue, Sep 13, 2016 at 10:48 PM, Amit Langote
 wrote:
> Spotted a typo in the header comment of execIndexing.c.  Attached fixes it.
>
> s/exclusive constraints/exclusion constraints/g

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in execIndexing.c

[Amit Langote]

Spotted a typo in the header comment of execIndexing.c.  Attached fixes it.

s/exclusive constraints/exclusion constraints/g

Thanks,
Amit
diff --git a/src/backend/executor/execIndexing.c b/src/backend/executor/execIndexing.c
index 0e2d834..009c1b7 100644
--- a/src/backend/executor/execIndexing.c
+++ b/src/backend/executor/execIndexing.c
@@ -2,7 +2,7 @@
  *
  * execIndexing.c
  *	  routines for inserting index tuples and enforcing unique and
- *	  exclusive constraints.
+ *	  exclusion constraints.
  *
  * ExecInsertIndexTuples() is the main entry point.  It's called after
  * inserting a tuple to the heap, and it inserts corresponding index tuples

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment Typo

[Bruce Momjian]

On Tue, Sep  6, 2016 at 10:52:22AM +0900, Amit Langote wrote:
> Attached fixes a typo in header comment in libpq-be.h.
> 
> s/libpq_be.h/libpq-be.h/g

Applied.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment Typo

[Amit Langote]

Attached fixes a typo in header comment in libpq-be.h.

s/libpq_be.h/libpq-be.h/g

Thanks,
Amit
diff --git a/src/include/libpq/libpq-be.h b/src/include/libpq/libpq-be.h
index ecdfbc6..b91eca5 100644
--- a/src/include/libpq/libpq-be.h
+++ b/src/include/libpq/libpq-be.h
@@ -1,6 +1,6 @@
 /*-
  *
- * libpq_be.h
+ * libpq-be.h
  *	  This file contains definitions for structures and externs used
  *	  by the postmaster during client authentication.
  *

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] comment typo lmgr.c

[Robert Haas]

On Tue, Aug 23, 2016 at 8:13 AM, Erik Rijkers  wrote:
> comment typo in  src/backend/storage/lmgr.c  attached

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] comment typo lmgr.c

[Erik Rijkers]

comment typo in  src/backend/storage/lmgr.c  attached

Erik Rijkers--- src/backend/storage/lmgr/lmgr.c.orig	2016-08-23 14:04:33.0 +0200
+++ src/backend/storage/lmgr/lmgr.c	2016-08-23 14:05:41.0 +0200
@@ -33,7 +33,7 @@
  * constraint violations.  It's theoretically possible that a backend sees a
  * tuple that was speculatively inserted by another backend, but before it has
  * started waiting on the token, the other backend completes its insertion,
- * and then then performs 2^32 unrelated insertions.  And after all that, the
+ * and then performs 2^32 unrelated insertions.  And after all that, the
  * first backend finally calls SpeculativeInsertionLockAcquire(), with the
  * intention of waiting for the first insertion to complete, but ends up
  * waiting for the latest unrelated insertion instead.  Even then, nothing

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in tuplesort.c

[Bruce Momjian]

On Tue, Aug  2, 2016 at 01:56:27PM +0900, Amit Langote wrote:
> Attached patch fixes a minor typo in tuplesort.c
> 
> s/child content/child context/g

Thanks, patch applied.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in tuplesort.c

[Amit Langote]

Attached patch fixes a minor typo in tuplesort.c

s/child content/child context/g

Thanks,
Amit
diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
index 4c502bb..6756f26 100644
--- a/src/backend/utils/sort/tuplesort.c
+++ b/src/backend/utils/sort/tuplesort.c
@@ -661,7 +661,7 @@ tuplesort_begin_common(int workMem, bool randomAccess)
 	/*
 	 * Caller tuple (e.g. IndexTuple) memory context.
 	 *
-	 * A dedicated child content used exclusively for caller passed tuples
+	 * A dedicated child context used exclusively for caller passed tuples
 	 * eases memory management.  Resetting at key points reduces
 	 * fragmentation. Note that the memtuples array of SortTuples is allocated
 	 * in the parent context, not this context, because there is no need to

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in _readExtensibleNode()

[Robert Haas]

On Fri, May 6, 2016 at 3:26 AM, Amit Langote
 wrote:
> Attached fixes a minor typo comment in _readExtensibleNode().
>
> s/skip: extnodename/skip :extnodename/g
>
> I was confused at first as to why there is a skip extnodename on one line
> and get extnodename right on the next line as the comments say, :)

Thanks, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in _readExtensibleNode()

[Amit Langote]

Attached fixes a minor typo comment in _readExtensibleNode().

s/skip: extnodename/skip :extnodename/g

I was confused at first as to why there is a skip extnodename on one line
and get extnodename right on the next line as the comments say, :)

Thanks,
Amit
diff --git a/src/backend/nodes/readfuncs.c b/src/backend/nodes/readfuncs.c
index 6f28047..096bdde 100644
--- a/src/backend/nodes/readfuncs.c
+++ b/src/backend/nodes/readfuncs.c
@@ -2230,7 +2230,7 @@ _readExtensibleNode(void)
 	const char	   *extnodename;
 	READ_TEMP_LOCALS();
 
-	token = pg_strtok();		/* skip: extnodename */
+	token = pg_strtok();		/* skip :extnodename */
 	token = pg_strtok();		/* get extnodename */
 
 	extnodename = nullable_string(token, length);

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in slot.c

[Robert Haas]

On Thu, Feb 4, 2016 at 4:39 AM, Michael Paquier
 wrote:
> I just bumped into the following typo in slot.c:
> /*
>  * If we'd now fail - really unlikely - we wouldn't know
> whether this slot
>  * would persist after an OS crash or not - so, force a restart. The
> -* restart would try to fysnc this again till it works.
> +* restart would try to fsync this again till it works.
>  */
> START_CRIT_SECTION();

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in slot.c

[Michael Paquier]

Hi all,

I just bumped into the following typo in slot.c:
/*
 * If we'd now fail - really unlikely - we wouldn't know
whether this slot
 * would persist after an OS crash or not - so, force a restart. The
-* restart would try to fysnc this again till it works.
+* restart would try to fsync this again till it works.
 */
START_CRIT_SECTION();
Regards,
-- 
Michael
diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
index 251b549..11b44a4 100644
--- a/src/backend/replication/slot.c
+++ b/src/backend/replication/slot.c
@@ -984,7 +984,7 @@ CreateSlotOnDisk(ReplicationSlot *slot)
 	/*
 	 * If we'd now fail - really unlikely - we wouldn't know whether this slot
 	 * would persist after an OS crash or not - so, force a restart. The
-	 * restart would try to fysnc this again till it works.
+	 * restart would try to fsync this again till it works.
 	 */
 	START_CRIT_SECTION();
 

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in port/atomics/generic.h

[Magnus Hagander]

On Fri, Jan 15, 2016 at 2:35 AM, Tatsuro Yamada <
yamada.tats...@lab.ntt.co.jp> wrote:

> Hi,
>
> I found a typo in generic.h
> The attached patch fixes it: s/tomic/atomic/g
>


Applied, thanks!


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

[HACKERS] Comment typo in port/atomics/generic.h

[Tatsuro Yamada]

Hi,

I found a typo in generic.h
The attached patch fixes it: s/tomic/atomic/g

Best regards,
Tatsuro Yamada
*** a/src/include/port/atomics/generic.h
--- b/src/include/port/atomics/generic.h
***
*** 1,7 
  /*-
   *
   * generic.h
!  *	  Implement higher level operations based on some lower level tomic
   *	  operations.
   *
   * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group
--- 1,7 
  /*-
   *
   * generic.h
!  *	  Implement higher level operations based on some lower level atomic
   *	  operations.
   *
   * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in port/atomics/arch-x86.h

[Tatsuro Yamada]

Hi,

I found a typo in arch-x86.h.
The attached patch fixes a typo: s/468/486/g

Best regards,
Tatsuro Yamada
*** a/src/include/port/atomics/arch-x86.h
--- b/src/include/port/atomics/arch-x86.h
***
*** 67,73  typedef struct pg_atomic_uint32
  
  /*
   * It's too complicated to write inline asm for 64bit types on 32bit and the
!  * 468 can't do it anyway.
   */
  #ifdef __x86_64__
  #define PG_HAVE_ATOMIC_U64_SUPPORT
--- 67,73 
  
  /*
   * It's too complicated to write inline asm for 64bit types on 32bit and the
!  * 486 can't do it anyway.
   */
  #ifdef __x86_64__
  #define PG_HAVE_ATOMIC_U64_SUPPORT

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in port/atomics/arch-x86.h

[Magnus Hagander]

On Fri, Jan 8, 2016 at 7:37 AM, Tatsuro Yamada  wrote:

> Hi,
>
> I found a typo in arch-x86.h.
> The attached patch fixes a typo: s/468/486/g
>
>
Applied, thanks.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

[HACKERS] Comment typo in namespace.c

[Amit Langote]

Hi,

Attached fixes a typo: s/non-exstant/non-existant.

Alternatively, it could be spelled as 'existent' but the patch doesn't.
Nor does it drop the 's' and spell it 'non-extant' which may have been the
original intent.

Thanks,
Amit
diff --git a/src/backend/catalog/namespace.c b/src/backend/catalog/namespace.c
index 8b105fe..036eb37 100644
--- a/src/backend/catalog/namespace.c
+++ b/src/backend/catalog/namespace.c
@@ -513,7 +513,7 @@ RangeVarGetCreationNamespace(const RangeVar *newRelation)
  * As a side effect, this function acquires AccessShareLock on the target
  * namespace.  Without this, the namespace could be dropped before our
  * transaction commits, leaving behind relations with relnamespace pointing
- * to a no-longer-exstant namespace.
+ * to a no-longer-existant namespace.
  *
  * As a further side-effect, if the select namespace is a temporary namespace,
  * we mark the RangeVar as RELPERSISTENCE_TEMP.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in namespace.c

[Amit Langote]

On Wed, Jan 6, 2016 at 11:51 PM, Tom Lane  wrote:
> Amit Langote  writes:
>> Attached fixes a typo: s/non-exstant/non-existant.
>> Alternatively, it could be spelled as 'existent' but the patch doesn't.
>
> "non-existant" is flat wrong, so if we're going to fix typos, let's
> fix them to actually be English.

So, non-existent? non-extant? I seems to me like an 's' accidentally
sneaked in when the author of the comment tried to write the latter
spelling. But the former sounds more familiar (at least to me).

Thanks,
Amit


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in namespace.c

[Tom Lane]

Amit Langote  writes:
> Attached fixes a typo: s/non-exstant/non-existant.
> Alternatively, it could be spelled as 'existent' but the patch doesn't.

"non-existant" is flat wrong, so if we're going to fix typos, let's
fix them to actually be English.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in namespace.c

[Tom Lane]

Amit Langote  writes:
> On Wed, Jan 6, 2016 at 11:51 PM, Tom Lane  wrote:
>> "non-existant" is flat wrong, so if we're going to fix typos, let's
>> fix them to actually be English.

> So, non-existent? non-extant? I seems to me like an 's' accidentally
> sneaked in when the author of the comment tried to write the latter
> spelling. But the former sounds more familiar (at least to me).

"existent" is a word according to my dictionary, so "non-existent"
is fine.  "extant" is also a word but it's less common and doesn't
really mean the same thing --- it carries a connotation of "still
in existence, surviving".  So you might say "Stonebraker's papers
about Postgres from the '80s are still extant".  "Existent" just
means "in existence" without any particular implication about time
passing, so it's probably what is meant in most cases.

(Actually, in the particular context here, I guess "extant" would
be sensible, but it would be rather hi-falutin' usage.  I'd go
with "existent".)

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in namespace.c

[Amit Langote]

On 2016/01/07 1:03, Tom Lane wrote:
> Amit Langote  writes:
>> On Wed, Jan 6, 2016 at 11:51 PM, Tom Lane  wrote:
>>> "non-existant" is flat wrong, so if we're going to fix typos, let's
>>> fix them to actually be English.
> 
>> So, non-existent? non-extant? I seems to me like an 's' accidentally
>> sneaked in when the author of the comment tried to write the latter
>> spelling. But the former sounds more familiar (at least to me).
> 
> "existent" is a word according to my dictionary, so "non-existent"
> is fine.  "extant" is also a word but it's less common and doesn't
> really mean the same thing --- it carries a connotation of "still
> in existence, surviving".  So you might say "Stonebraker's papers
> about Postgres from the '80s are still extant".  "Existent" just
> means "in existence" without any particular implication about time
> passing, so it's probably what is meant in most cases.
> 
> (Actually, in the particular context here, I guess "extant" would
> be sensible, but it would be rather hi-falutin' usage.  I'd go
> with "existent".)

Thanks for the explanation.

Regards,
Amit




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] comment typo in RewindTest.pm

[Masahiko Sawada]

Hi all,

Attached patch fixes the comment typo in RewindTest.pm
Please find it.

Regards,

--
Masahiko Sawada
diff --git a/src/bin/pg_rewind/RewindTest.pm b/src/bin/pg_rewind/RewindTest.pm
index c1c7d1f..41d294e 100644
--- a/src/bin/pg_rewind/RewindTest.pm
+++ b/src/bin/pg_rewind/RewindTest.pm
@@ -183,7 +183,7 @@ sub promote_standby
 	  or die "Timed out while waiting for promotion of standby";
 
 	# Force a checkpoint after the promotion. pg_rewind looks at the control
-	# file todetermine what timeline the server is on, and that isn't updated
+	# file to determine what timeline the server is on, and that isn't updated
 	# immediately at promotion, but only at the next checkpoint. When running
 	# pg_rewind in remote mode, it's possible that we complete the test steps
 	# after promotion so quickly that when pg_rewind runs, the standby has not

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] comment typo in RewindTest.pm

[Robert Haas]

On Mon, Jan 4, 2016 at 8:08 AM, Masahiko Sawada  wrote:
> Attached patch fixes the comment typo in RewindTest.pm
> Please find it.

Committed and back-patched to 9.5.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in pg_dump.h

[Amit Langote]

On 2015/12/25 0:44, Tom Lane wrote:
> Amit Langote  writes:
>> Attached fixes the following comment typo (copy-pasto):
>> -Oid toast_oid;  /* for restore toast frozen xid */
>> +Oid toast_oid;  /* for restore toast table oid */
> 
> That comment needs more help than just that ;-).  Done, thanks.

It definitely did, thanks!

Regards,
Amit




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in pg_dump.h

[Amit Langote]

Attached fixes the following comment typo (copy-pasto):

-Oid toast_oid;  /* for restore toast frozen xid */
+Oid toast_oid;  /* for restore toast table oid */

Thanks,
Amit
diff --git a/src/bin/pg_dump/pg_dump.h b/src/bin/pg_dump/pg_dump.h
index 3c64a82..9c63abd 100644
--- a/src/bin/pg_dump/pg_dump.h
+++ b/src/bin/pg_dump/pg_dump.h
@@ -215,7 +215,7 @@ typedef struct _tableInfo
 	bool		hasoids;		/* does it have OIDs? */
 	uint32		frozenxid;		/* for restore frozen xid */
 	uint32		minmxid;		/* for restore min multi xid */
-	Oid			toast_oid;		/* for restore toast frozen xid */
+	Oid			toast_oid;		/* for restore toast table oid */
 	uint32		toast_frozenxid;	/* for restore toast frozen xid */
 	uint32		toast_minmxid;	/* for restore toast min multi xid */
 	int			ncheck;			/* # of CHECK expressions */

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in pg_dump.h

[Tom Lane]

Amit Langote  writes:
> Attached fixes the following comment typo (copy-pasto):
> -Oid toast_oid;  /* for restore toast frozen xid */
> +Oid toast_oid;  /* for restore toast table oid */

That comment needs more help than just that ;-).  Done, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in pg_upgrade.c

[Amit Langote]

On 2015/12/18 14:53, Amit Langote wrote:
> In prepare_new_cluster(), following looks like a typo:
> 
> - * would cause us to lose the frozenids restored by the load. We use
> + * would cause us to lose the frozenxids restored by the load. We use

Or maybe not, because "frozenids" is supposed to refer to both xids and mxids.

Sorry about the noise.

Thanks,
Amit





-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in pg_upgrade.c

[Amit Langote]

In prepare_new_cluster(), following looks like a typo:

- * would cause us to lose the frozenids restored by the load. We use
+ * would cause us to lose the frozenxids restored by the load. We use

Attached find the patch.

Thanks,
Amit
diff --git a/src/bin/pg_upgrade/pg_upgrade.c b/src/bin/pg_upgrade/pg_upgrade.c
index 4a7281b..7f8b75f 100644
--- a/src/bin/pg_upgrade/pg_upgrade.c
+++ b/src/bin/pg_upgrade/pg_upgrade.c
@@ -238,7 +238,7 @@ prepare_new_cluster(void)
 {
 	/*
 	 * It would make more sense to freeze after loading the schema, but that
-	 * would cause us to lose the frozenids restored by the load. We use
+	 * would cause us to lose the frozenxids restored by the load. We use
 	 * --analyze so autovacuum doesn't update statistics later
 	 */
 	prep_status("Analyzing all rows in the new cluster");

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in src/backend/executor/execMain.c

[Etsuro Fujita]

On 2015/01/10 1:08, Stephen Frost wrote:

* Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote:

I ran into a comment type.  Please find attached a patch.


Fix pushed.


Thanks!

Best regards,
Etsuro Fujita


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in src/backend/executor/execMain.c

[Stephen Frost]

Etsuro,

* Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote:
 I ran into a comment type.  Please find attached a patch.

Fix pushed.

Thanks!

Stephen


signature.asc
Description: Digital signature

[HACKERS] Comment typo in src/backend/executor/execMain.c

[Etsuro Fujita]

Hi,

I ran into a comment type.  Please find attached a patch.

Best regards,
Etsuro Fujita
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index 8c799d3..28abfa4 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -2024,7 +2024,7 @@ EvalPlanQualFetch(EState *estate, Relation relation, int lockmode,
 			 * heap_lock_tuple() will throw an error, and so would any later
 			 * attempt to update or delete the tuple.  (We need not check cmax
 			 * because HeapTupleSatisfiesDirty will consider a tuple deleted
-			 * by our transaction dead, regardless of cmax.) Wee just checked
+			 * by our transaction dead, regardless of cmax.) We just checked
 			 * that priorXmax == xmin, so we can test that variable instead of
 			 * doing HeapTupleHeaderGetXmin again.
 			 */

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in typedef struct BrinTuple

[Heikki Linnakangas]

On 12/15/2014 09:04 AM, Amit Langote wrote:


Hi,

Find attached that does:

-* mt_info is laid out in the following fashion:
+* bt_info is laid out in the following fashion:
snip-comment
 uint8   bt_info;
} BrinTuple;


Thanks. Fixed along with a bunch of other misc comment typos I've bumped 
into.


- Heikki


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in typedef struct BrinTuple

[Amit Langote]

Hi,

Find attached that does:

-* mt_info is laid out in the following fashion:
+* bt_info is laid out in the following fashion:
snip-comment
uint8   bt_info;
} BrinTuple;

Thanks,
Amit


BrinTuple-typo-fix.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in src/backend/command/cluster.c

[Sawada Masahiko]

Hi all,

Attached patch fixes the typo which is in src/backend/command/cluster.c.

Regards,

---
Sawada Masahiko


fix_typo-cluster.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in src/backend/command/cluster.c

[Fujii Masao]

On Tue, Jan 21, 2014 at 2:13 AM, Sawada Masahiko sawada.m...@gmail.com wrote:
 Hi all,

 Attached patch fixes the typo which is in src/backend/command/cluster.c.

Thanks! Committed.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in src/include/access/gin_private.h

[Robert Haas]

On Mon, Jan 13, 2014 at 9:59 PM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp wrote:
 I ran into a typo in src/include/access/gin_private.h.  Patch attached.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in src/include/access/gin_private.h

[Etsuro Fujita]

I ran into a typo in src/include/access/gin_private.h.  Patch attached.

Thanks,

Best regards,
Etsuro Fujita


gin_private.h-typo.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] comment typo in postgres_fdw/postgres_fdw.c

[Ian Lawrence Barwick]

Presumably classifyConditions, not classifyClauses, is meant.
Patch attached.


Regards

Ian Barwick
diff --git a/contrib/postgres_fdw/postgres_fdw.c 
b/contrib/postgres_fdw/postgres_fdw.c
index 246a3a9..46ea032 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -723,7 +723,7 @@ postgresGetForeignPlan(PlannerInfo *root,
/*
 * Separate the scan_clauses into those that can be executed remotely 
and
 * those that can't.  baserestrictinfo clauses that were previously
-* determined to be safe or unsafe by classifyClauses are shown in
+* determined to be safe or unsafe by classifyConditions are shown in
 * fpinfo-remote_conds and fpinfo-local_conds.  Anything else in the
 * scan_clauses list should be a join clause that was found safe by
 * postgresGetForeignPaths.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] comment typo in postgres_fdw/postgres_fdw.c

[Tom Lane]

Ian Lawrence Barwick barw...@gmail.com writes:
 Presumably classifyConditions, not classifyClauses, is meant.

Hm, I think this got missed in a bout of renaming.  Will apply, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Heikki Linnakangas]

On 20.02.2013 05:07, Etsuro Fujita wrote:

Sorry, I found one more typo.  Attached is a patch.


Thanks, applied.

- Heikki


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Etsuro Fujita]

Sorry, I found one more typo.  Attached is a patch.

Thanks,

Best regards,
Etsuro Fujita

 -Original Message-
 From: Magnus Hagander [mailto:mag...@hagander.net]
 Sent: Friday, February 08, 2013 7:47 PM
 To: Etsuro Fujita
 Cc: PostgreSQL-development
 Subject: Re: [HACKERS] Comment typo
 
 On Fri, Feb 8, 2013 at 6:49 AM, Etsuro Fujita
 fujita.ets...@lab.ntt.co.jp wrote:
  I found a comment typo.  Please find attached a patch.
 
 Applied, thanks.
 
 
 --
  Magnus Hagander
  Me: http://www.hagander.net/
  Work: http://www.redpill-linpro.com/



comment_typo_20130220.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Magnus Hagander]

On Fri, Feb 8, 2013 at 6:49 AM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp wrote:
 I found a comment typo.  Please find attached a patch.

Applied, thanks.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo

[Etsuro Fujita]

I found a comment typo.  Please find attached a patch.

Best regards,
Etsuro Fujita


comment_typo.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo

[Etsuro Fujita]

This is a little patch to fix a typo in a comment.

Best regards,
Etsuro Fujit


commentfix_20121102.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Etsuro Fujita]

Sorry, this is not a typo.  Please ignore the post.

Best regards,
Etsuro Fujit

 -Original Message-
 From: pgsql-hackers-ow...@postgresql.org
 [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Etsuro Fujita
 Sent: Friday, November 02, 2012 2:40 PM
 To: 'PostgreSQL-development'
 Subject: [HACKERS] Comment typo
 
 This is a little patch to fix a typo in a comment.
 
 Best regards,
 Etsuro Fujit



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo

[Etsuro Fujita]

This is a little patch to fix a typo in a comment.

Best regards,
Etsuro Fujit


commentfix.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Kevin Grittner]

Etsuro Fujita  wrote:
 This is a little patch to fix a typo in a comment.
 
Applied to HEAD and 9.2, which as far back as it went.  I figured it
was easy and eliminated any back-patch issues for subsequent changes.
 
Thanks!
 
-Kevin


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo

[Etsuro Fujita]

Thanks!

Best regards,
Etsuro Fujita

 -Original Message-
 From: pgsql-hackers-ow...@postgresql.org
 [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Kevin Grittner
 Sent: Thursday, September 13, 2012 12:40 PM
 To: fujita.ets...@lab.ntt.co.jp; pgsql-hackers@postgresql.org
 Subject: Re: [HACKERS] Comment typo
 
 Etsuro Fujita  wrote:
  This is a little patch to fix a typo in a comment.
 
 Applied to HEAD and 9.2, which as far back as it went.  I figured it
 was easy and eliminated any back-patch issues for subsequent changes.
 
 Thanks!
 
 -Kevin
 
 
 --
 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgsql-hackers




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in nodeWindowAgg.c

[Andreas Karlsson]

Hi,

Found a couple of small typos in the comments of nodeWindowAgg.c when
they refer to functions in nodeAgg.c. The pluralities of the function
names (initialize_aggregates and advance_aggregates) are wrong. The
reference to finalize_aggregate is correct though.


diff --git a/src/backend/executor/nodeWindowAgg.c
b/src/backend/executor/nodeWindowAgg.c
index c3efe12..51f98c1 100644
*** a/src/backend/executor/nodeWindowAgg.c
--- b/src/backend/executor/nodeWindowAgg.c
*** static bool window_gettupleslot(WindowOb
*** 181,187 
  
  /*
   * initialize_windowaggregate
!  * parallel to initialize_aggregate in nodeAgg.c
   */
  static void
  initialize_windowaggregate(WindowAggState *winstate,
--- 181,187 
  
  /*
   * initialize_windowaggregate
!  * parallel to initialize_aggregates in nodeAgg.c
   */
  static void
  initialize_windowaggregate(WindowAggState *winstate,
*** initialize_windowaggregate(WindowAggStat
*** 207,213 
  
  /*
   * advance_windowaggregate
!  * parallel to advance_aggregate in nodeAgg.c
   */
  static void
  advance_windowaggregate(WindowAggState *winstate,
--- 207,213 
  
  /*
   * advance_windowaggregate
!  * parallel to advance_aggregates in nodeAgg.c
   */
  static void
  advance_windowaggregate(WindowAggState *winstate,

Regards,
Andreas Karlsson



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in nodeWindowAgg.c

[Robert Haas]

On Tue, Dec 21, 2010 at 4:17 PM, Andreas Karlsson andr...@proxel.se wrote:
 Found a couple of small typos in the comments of nodeWindowAgg.c when
 they refer to functions in nodeAgg.c. The pluralities of the function
 names (initialize_aggregates and advance_aggregates) are wrong. The
 reference to finalize_aggregate is correct though.

Committed, thanks.  But please attach patches rather than including them inline.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Comment typo in xlog.c

[Fujii Masao]

Hi,

I found two typos in xlog.c. Could you apply the attached patch?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


typo.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Comment typo in xlog.c

[Heikki Linnakangas]

On 06.12.2010 09:01, Fujii Masao wrote:

I found two typos in xlog.c. Could you apply the attached patch?


Applied.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers