Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-04-07 Thread Alvaro Herrera 
Magnus Hagander wrote:
> On Wed, Mar 30, 2016 at 7:47 PM, Alvaro Herrera 
> wrote:
> 
> > José Luis Tallón wrote:
> >
> > > Just wanted to suggest two minor mods to the review e-mails
> > > auto-generated by the app:
> > >
> > > * Prepend a [review] tag to the e-mail subject
> > > ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
> > > "
> >
> > Changing the subject of an email causes Gmail to break the threads, so
> > anything in that line should be discouraged.  -1 from me.  I would be
> > happier if the subject of the submission email is kept intact, i.e. not
> > use the patch title that was used in commitfest app but use the one in
> > the email.  These often differ.
> 
> That's what the code tries to do. It will add a Re: if there isn't one
> already, but otherwise should reuse it.  At least that's how it's trying to
> work - do you have a pointer to an example where it doesn't, so I can
> investigate if something is off?

No, I don't, I was just stating that José Luis' description seemed wrong
to me.  I haven't looked carefully at the emails generated from
commitfest app, but it seems to work fine already.

> > > * Auto-CC the patch author on this e-mail
> > > I guess this should speed up reactions / make communication a bit
> > > more fluid.
> >
> > Yes, strong +1 on this.
> 
> Ok, that should be easy enough to add. I've stuck it on my TODO list and
> will try to get it ASAP.

Thanks for doing this :-)

> > 3) Have the auto-generated emails insert In-Reply-To headers (and
> > perhaps References).
> 
> It already does. Both. Again, do you have a pointer to where it doesn't?

No, works fine AFAICS.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-04-06 Thread Magnus Hagander 
On Wed, Apr 6, 2016 at 2:11 PM, Magnus Hagander  wrote:

> On Wed, Mar 30, 2016 at 7:47 PM, Alvaro Herrera 
> wrote:
>
>> José Luis Tallón wrote:
>>
> > * Auto-CC the patch author on this e-mail
>> > I guess this should speed up reactions / make communication a bit
>> more
>> > fluid.
>>
>> Yes, strong +1 on this.
>>
>
> Ok, that should be easy enough to add. I've stuck it on my TODO list and
> will try to get it ASAP.
>
>
That part was indeed easy, so it's now done.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-04-06 Thread Magnus Hagander 
On Wed, Mar 30, 2016 at 7:47 PM, Alvaro Herrera 
wrote:

> José Luis Tallón wrote:
>
> > Just wanted to suggest two minor mods to the review e-mails
> > auto-generated by the app:
> >
> > * Prepend a [review] tag to the e-mail subject
> > ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
> > "
>
> Changing the subject of an email causes Gmail to break the threads, so
> anything in that line should be discouraged.  -1 from me.  I would be
> happier if the subject of the submission email is kept intact, i.e. not
> use the patch title that was used in commitfest app but use the one in
> the email.  These often differ.
>

That's what the code tries to do. It will add a Re: if there isn't one
already, but otherwise should reuse it.  At least that's how it's trying to
work - do you have a pointer to an example where it doesn't, so I can
investigate if something is off?



> > * Auto-CC the patch author on this e-mail
> > I guess this should speed up reactions / make communication a bit
> more
> > fluid.
>
> Yes, strong +1 on this.
>

Ok, that should be easy enough to add. I've stuck it on my TODO list and
will try to get it ASAP.



> 3) Have the auto-generated emails insert In-Reply-To headers (and
> perhaps References).
>

It already does. Both. Again, do you have a pointer to where it doesn't?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-04-04 Thread Robert Haas 
On Wed, Mar 30, 2016 at 1:47 PM, Alvaro Herrera
 wrote:
> José Luis Tallón wrote:
>> Just wanted to suggest two minor mods to the review e-mails
>> auto-generated by the app:
>>
>> * Prepend a [review] tag to the e-mail subject
>> ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
>> "
>
> Changing the subject of an email causes Gmail to break the threads, so
> anything in that line should be discouraged.  -1 from me.  I would be
> happier if the subject of the submission email is kept intact, i.e. not
> use the patch title that was used in commitfest app but use the one in
> the email.  These often differ.

I entirely agree with Alvaro.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-03-30 Thread Stephen Frost 
* José Luis Tallón (jltal...@adv-solutions.net) wrote:
> * Prepend a [review] tag to the e-mail subject
> ... so that e-mails sent to -hackers will read  " [HACKERS]
> [review] "

Eh, I'm not against it but not sure it's all that necessary either.

> * Auto-CC the patch author on this e-mail
> I guess this should speed up reactions / make communication a
> bit more fluid.

This is almost a requirement, imv, as subsequent comments on the review
are frequent and it's a crime if the author misses all of that.

Thanks!

Stephen


signature.asc
Description: Digital signature

Re: [HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-03-30 Thread Alvaro Herrera 
José Luis Tallón wrote:

> Just wanted to suggest two minor mods to the review e-mails
> auto-generated by the app:
> 
> * Prepend a [review] tag to the e-mail subject
> ... so that e-mails sent to -hackers will read  " [HACKERS] [review]
> "

Changing the subject of an email causes Gmail to break the threads, so
anything in that line should be discouraged.  -1 from me.  I would be
happier if the subject of the submission email is kept intact, i.e. not
use the patch title that was used in commitfest app but use the one in
the email.  These often differ.

> * Auto-CC the patch author on this e-mail
> I guess this should speed up reactions / make communication a bit more
> fluid.

Yes, strong +1 on this.

3) Have the auto-generated emails insert In-Reply-To headers (and
perhaps References).

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] [CommitFest App] Feature request -- review e-mail additions

2016-03-30 Thread José Luis Tallón 

Hello,

Just wanted to suggest two minor mods to the review e-mails 
auto-generated by the app:


* Prepend a [review] tag to the e-mail subject
... so that e-mails sent to -hackers will read  " [HACKERS] 
[review] "


* Auto-CC the patch author on this e-mail
I guess this should speed up reactions / make communication a bit 
more fluid.



Dunno whether it'd be appreciated if I posted a tentative patch ¿?


Thanks,

/ J.L.



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Commitfest app

2016-01-06 Thread Magnus Hagander 
Hi!

I'm about to start some upgrades on the machine running
commitfest.postgresql.org. The app itself won't change, but the underlying
OS and webserver will, so there will be some disruptions of service and
some strange and scary error messages for a while.

Hopefully it will take less than an hour, but I'll let you know when it's
done as it might be a bit longer.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Commitfest app

2016-01-06 Thread Magnus Hagander 
On Wed, Jan 6, 2016 at 4:50 PM, Magnus Hagander  wrote:

> Hi!
>
> I'm about to start some upgrades on the machine running
> commitfest.postgresql.org. The app itself won't change, but the
> underlying OS and webserver will, so there will be some disruptions of
> service and some strange and scary error messages for a while.
>
> Hopefully it will take less than an hour, but I'll let you know when it's
> done as it might be a bit longer.
>
>
Upgrade is now complete. If you see any further issues, please let me know
and I'll look into them. None are *expected* anymore.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] commitfest app bug/feature

2015-08-14 Thread Magnus Hagander 
On Thu, May 7, 2015 at 9:17 PM, Fabien COELHO coe...@cri.ensmp.fr wrote:


 Hello,

 Some comments/bug report about the commitfest web app which just bite me:-)

 When creating a patch with the commitfest app, if the thread does not
 exist the application seems to reject the creation, so you may resubmit
 because you know the thread is going to exist soon... Well, this is a bad
 idea:-)

 Indeed the first submission, although it looked like it had failed, has
 really been created anyway, and the resubmission creates another entry. If
 you click again, you get a third. And so on.


Clearly I'm very slow at some things, but at least I've just pushed a fix
for this bug now. It validates the thread exists *before* it creates the
entry now...


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] commitfest app bug/feature

2015-05-08 Thread Fabien COELHO 



ISTM that an additional Duplicate or To remove status could be a tag for
admins to remove the entries?


This looks like an overkill to me. Entries with the same description
headline mean the same thing.


Sure.

My point was to provide a mean to signal explicitely that an entry can be 
removed, as removing it is not an option for the lay man, and all other 
status do not correspond to reality (Why put Rejected or Returned with 
feedback, as it is not the case in?). Morover the description if different 
submitions might be slightly different.


ISTM that sending a mail to hacker to remove spurious entries in the CF 
app is a little overkill too.


--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] commitfest app bug/feature

2015-05-07 Thread Fabien COELHO 


Hello,

Some comments/bug report about the commitfest web app which just bite 
me:-)


When creating a patch with the commitfest app, if the thread does not 
exist the application seems to reject the creation, so you may resubmit 
because you know the thread is going to exist soon... Well, this is a bad 
idea:-)


Indeed the first submission, although it looked like it had failed, has 
really been created anyway, and the resubmission creates another entry. If 
you click again, you get a third. And so on.


Maybe the description should be unique at least per commitfest?

Then there is no way to remove a patch from the application. You end up 
marking them as Rejected, which does not make much sense, see the bottom 
of the 2015-06 commitfest list...


Maybe a Duplicate status would be better, and the ability to actually 
remove a stupid entry would be even nicer, although maybe not desirable, 
ot sure. And/or some way to prevent duplicates based on the description...


--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] commitfest app bug/feature

2015-05-07 Thread Fabien COELHO 


Hello Michael,

It is possible to remove patches from the set, but administrator rights 
are necessary.


Good. Maybe this right could be granted to the person who as created the 
patch entry in the CF?


If there are duplicated entries that you would like to get removed, 
simply mention them here and I'll remove them. I do some cleanup of 
duplicate entries from time to time though, you are not the first one to 
get bitten by that.


Sure.

Feel free to remove the stupid Rejected entries at the end of the 
2015-06 CF: there are currently 11 pgbench allow '=' in \set (mine) and 
2 configure can't detect proper pthread flags -- fix.


--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] commitfest app bug/feature

2015-05-07 Thread Michael Paquier 
On Fri, May 8, 2015 at 4:17 AM, Fabien COELHO wrote:
 Then there is no way to remove a patch from the application. You end up
 marking them as Rejected, which does not make much sense, see the bottom
 of the 2015-06 commitfest list...
 Maybe a Duplicate status would be better, and the ability to actually
 remove a stupid entry would be even nicer, although maybe not desirable, ot
 sure. And/or some way to prevent duplicates based on the description...

It is possible to remove patches from the set, but administrator
rights are necessary. If there are duplicated entries that you would
like to get removed, simply mention them here and I'll remove them. I
do some cleanup of duplicate entries from time to time though, you are
not the first one to get bitten by that.
Regards,
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] commitfest app bug/feature

2015-05-07 Thread Michael Paquier 
On Fri, May 8, 2015 at 10:35 AM, Fabien COELHO coe...@cri.ensmp.fr wrote:

 Hello Michael,

 It is possible to remove patches from the set, but administrator rights
 are necessary.


 Good. Maybe this right could be granted to the person who as created the
 patch entry in the CF?

Er, well... #blamemagnus ;)
I'm fine to do this cleanup btw.

 If there are duplicated entries that you would like to get removed, simply
 mention them here and I'll remove them. I do some cleanup of duplicate
 entries from time to time though, you are not the first one to get bitten by
 that.


 Sure.

 Feel free to remove the stupid Rejected entries at the end of the 2015-06
 CF: there are currently 11 pgbench allow '=' in \set (mine) and 2
 configure can't detect proper pthread flags -- fix.

Done.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] commitfest app bug/feature

2015-05-07 Thread Michael Paquier 
On Fri, May 8, 2015 at 11:54 AM, Fabien COELHO coe...@cri.ensmp.fr wrote:

 I'm fine to do this cleanup btw.


 ISTM that an additional Duplicate or To remove status could be a tag for
 admins to remove the entries?

This looks like an overkill to me. Entries with the same description
headline mean the same thing.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] commitfest app bug/feature

2015-05-07 Thread Fabien COELHO 



I'm fine to do this cleanup btw.


ISTM that an additional Duplicate or To remove status could be a tag 
for admins to remove the entries?



Feel free to remove the stupid Rejected entries at the end of the 2015-06
CF: there are currently 11 pgbench allow '=' in \set (mine) and 2
configure can't detect proper pthread flags -- fix.


Done.


Thanks.

--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Commitfest app not exporting moved to another commitfest to rss

2011-10-12 Thread Brar Piening 
I use rss to follow up on patches that I'm interested in and  it's the 
second time I was wonering where my patch has gone in the commitfest app 
due to $Topic.


Is this a known limitation?
If yes: Is there a way to change this?
If yes: Can/shall I help?
If yes: Where should I start?

Regards,

Brar



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Commitfest app not exporting moved to another commitfest to rss

2011-10-12 Thread Brar Piening 

Brar Piening wrote:
I use rss to follow up on patches that I'm interested in and  it's the 
second time I was wonering where my patch has gone in the commitfest 
app due to $Topic.


Just after pushing the send button my RSS-feed got updated and contained 
the relevant information.

Sorry for the noise!

I don't actually understand the delay in my feed getting updated despite 
the fact that I'm regularly updating it on my side.


Regards,

Brar

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] commitfest app

2009-07-17 Thread Andrew Dunstan 


I haven't paid much attention to the new commitfest app until now. 
Generally, it looks good, but I'm wondering if we should have a 
committer field.


I'm thinking of picking up at least the following items if/when they are 
ready, but such a thing might help us to make sure we don't trip over 
each other.


   DROP COLUMN/CONSTRAINT IF EXISTS support
   https://commitfest.postgresql.org/action/patch_view?id=89
   COPY WITH CSV FORCE QUOTE *
   https://commitfest.postgresql.org/action/patch_view?id=93
   hstore enhancements
   https://commitfest.postgresql.org/action/patch_view?id=122


cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers