Re: [HACKERS] Commitfest progress, or lack thereof
On 2014-10-13 21:01:57 +0300, Heikki Linnakangas wrote: > The August commitfest is still Open, with a few more patches left. The > patches that remain have stayed in limbo for a long time. It's not realistic > to expect anything to happen to them. > > I'm going to move the remaining patches to the next commitfest, and close > the August one. I hate to do that, because the whole point of a commitfest > is to get patches either rejected or committed, and not leave them hanging. > But if nothing's happening, there's no point waiting. FWIW, I think all of the remaining patches did get a fair amount of feedback. It's not like they were completely ignored. Thanks for managing! Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress, or lack thereof
On Mon, Oct 13, 2014 at 11:31 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > > I'm going to move the remaining patches to the next commitfest, and close the August one. Many thanks for managing commit fest in a best possible way. I think it is big bonanza for all the authors who have patches in the CF as most of the patches got fair enough review in just one CF. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
[HACKERS] Commitfest progress, or lack thereof
The August commitfest is still Open, with a few more patches left. The patches that remain have stayed in limbo for a long time. It's not realistic to expect anything to happen to them. I'm going to move the remaining patches to the next commitfest, and close the August one. I hate to do that, because the whole point of a commitfest is to get patches either rejected or committed, and not leave them hanging. But if nothing's happening, there's no point waiting. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress
On Wed, Oct 9, 2013 at 2:03 PM, Robert Haas wrote: > I therefore propose that we start by marking all of the patches that > are currently Waiting on Author as Returned with Feedback. Most of > them have been that way for a long time. Hearing no objections, I went through and did this, but skipped some that had recent activity, and instead marked one as ready for committer on the basis that the reviewer thought it was in good shape except for needing test case revision. Together with today's rash of commits, this means that we've now disposed of half the patches in the CommitFest. IOW, we have a lot of work left to do. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress
On Thu, Oct 10, 2013 at 5:21 AM, Dimitri Fontaine wrote: > Robert Haas writes: >> The CommitFest is supposed to be a time to >> *commit the patches that are ready to be committed*, not to wait >> indefinitely for them to become ready to be committed. > > I beg to differ. Commit Fests are the time when patch authors know they > can get feedback from the community and in particular committers. > > So as a patch author it's best if you can arrange your schedule and be > ready to submit new versions as asked, or comment on your design choices > and trade-offs, etc. > > Patch commit can happen whenever in the cycle at the discretion of the > committer. Commit Fest are all about *review* and *feedback*. Sure, I don't disagree with any of that. >> I therefore propose that we start by marking all of the patches that >> are currently Waiting on Author as Returned with Feedback. Most of >> them have been that way for a long time. > > That seems fair. > >> Then, I think all of the people who are listed as reviewers need to >> take a look at the current state of their patches and decide whether >> or not they are reasonably ready to be committed. If they are, then > > I've been distracted away from this commit fest but should be able to > get back to it now. Will post soon about the patches I enrolled myself > with. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress
Robert Haas writes: > The CommitFest is supposed to be a time to > *commit the patches that are ready to be committed*, not to wait > indefinitely for them to become ready to be committed. I beg to differ. Commit Fests are the time when patch authors know they can get feedback from the community and in particular committers. So as a patch author it's best if you can arrange your schedule and be ready to submit new versions as asked, or comment on your design choices and trade-offs, etc. Patch commit can happen whenever in the cycle at the discretion of the committer. Commit Fest are all about *review* and *feedback*. > I therefore propose that we start by marking all of the patches that > are currently Waiting on Author as Returned with Feedback. Most of > them have been that way for a long time. That seems fair. > Then, I think all of the people who are listed as reviewers need to > take a look at the current state of their patches and decide whether > or not they are reasonably ready to be committed. If they are, then I've been distracted away from this commit fest but should be able to get back to it now. Will post soon about the patches I enrolled myself with. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] CommitFest progress
Of the 83 patches in this CommitFest, there are currently 35 that are marked as needing review, 23 that are waiting on author, 7 that are ready for committer, 11 that are committed, 5 that are returned with feedback, and 2 that are rejected. Since we're now supposedly in the last week of this month-long CommitFest, that doesn't bode well. I have no problem continuing to work on the patches that are ready for committer, and the people whose patches are marked as in need of review because they have never been reviewed (such as, cough, my background workers round three patch) surely deserve to get one. But I do have a problem with the fact that no concerted effort has been made to mark patches that are clearly nowhere near ready for commit, or which have been waiting on the author for extended periods of time, as returned with feedback. The CommitFest is supposed to be a time to *commit the patches that are ready to be committed*, not to wait indefinitely for them to become ready to be committed. If we make it into the latter, then nobody should be surprised when CommitFests never end. I therefore propose that we start by marking all of the patches that are currently Waiting on Author as Returned with Feedback. Most of them have been that way for a long time. Then, I think all of the people who are listed as reviewers need to take a look at the current state of their patches and decide whether or not they are reasonably ready to be committed. If they are, then they should be marked Ready for Committer. If they're not, but they've had at least one good thorough review, then they should also be marked Returned with Feedback; they can be resubmitted for the next CommitFest for further review. If they haven't had a good thorough review yet, then the people who signed up to review should, uh, hurry up and do that. If they can't, they should remove their name from the patch and we should seek other volunteers. Finally, we need to find reviewers for the patches that still don't have them, or that lack them once the names of people who aren't really going to review get removed. I have certainly reviewed more patches this CommitFest than I submitted by quite a bit, but I'm still willing to help with a few more if that's needed. I can't, however, do all of them, especially if I'm on the hook to also commit everything I review once it becomes ready. Thanks, -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
On 03/05/2013 02:06 AM, Josh Berkus wrote: >> Where was that discussed, and who objected to the 2nd CF manager? > It was discussed when Craig volunteered. I suggested two CF managers, > two people (and Craig) said no, and nobody supported the idea. So I > dropped it. If I said no I was wrong to do so. I don't remember that, but that's not unheard of for me. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
> Where was that discussed, and who objected to the 2nd CF manager? It was discussed when Craig volunteered. I suggested two CF managers, two people (and Craig) said no, and nobody supported the idea. So I dropped it. It's a bit late now, but we've learned that having only one CF manager for the last CF was the wrong choice. We'll know better next year. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
On 1 March 2013 18:36, Josh Berkus wrote: > >> As I stepped up to work on the CF and then became immediately swamped in >> other work I bear some of the responsibility for not keeping things >> rolling. > > Just FYI, this is exactly why I wanted a 2nd CF manager for this CF. Where was that discussed, and who objected to the 2nd CF manager? -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
On 03/03/2013 11:58 AM, Stefan Kaltenbrunner wrote: > On 03/03/2013 08:37 PM, Josh Berkus wrote: >> >>> Works for me, since I haven't been able to find time for it during the >>> week. >> >> Set aside a couple hours to deal with it this AM, foiled because my >> community account is broken. Grrr. > > we might be able to fix this if you could tell us what exactly the > problem is? Already sent you private email. Figured the web team would be offline by now, though ... -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
On 03/03/2013 08:37 PM, Josh Berkus wrote: > >> Works for me, since I haven't been able to find time for it during the >> week. > > Set aside a couple hours to deal with it this AM, foiled because my > community account is broken. Grrr. we might be able to fix this if you could tell us what exactly the problem is? Stefan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
> Works for me, since I haven't been able to find time for it during the > week. Set aside a couple hours to deal with it this AM, foiled because my community account is broken. Grrr. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
On 03/02/2013 02:36 AM, Josh Berkus wrote: >> As I stepped up to work on the CF and then became immediately swamped in >> other work I bear some of the responsibility for not keeping things >> rolling. > Just FYI, this is exactly why I wanted a 2nd CF manager for this CF. > >> It'd be really good if anyone with a patch in the CF could follow up >> with an opinion on its readiness and, if appropriate, push it to the >> next CF. I'll be going through the patch list and following up with my >> own summaries, but I remain pretty swamped so it'll be a trickle rather >> than a flood. > I'll try to find time this weekend to go through the pending patches and > check status. I'll start at the bottom of the list and you can start at > the top. Works for me, since I haven't been able to find time for it during the week. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Commitfest progress
> As I stepped up to work on the CF and then became immediately swamped in > other work I bear some of the responsibility for not keeping things > rolling. Just FYI, this is exactly why I wanted a 2nd CF manager for this CF. > It'd be really good if anyone with a patch in the CF could follow up > with an opinion on its readiness and, if appropriate, push it to the > next CF. I'll be going through the patch list and following up with my > own summaries, but I remain pretty swamped so it'll be a trickle rather > than a flood. I'll try to find time this weekend to go through the pending patches and check status. I'll start at the bottom of the list and you can start at the top. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Commitfest progress
Hi all It looks like the commitfest is making very slow progress. At this point it strikes me that it may be time to look for a line to draw between 9.3 and post-9.3 work, defer all post-9.3 work, and then get the rest into shape. As I stepped up to work on the CF and then became immediately swamped in other work I bear some of the responsibility for not keeping things rolling. There's been quite a lot of progress, in that we're down from over 90 open patches to less than 50, but 50 is still a lot of patches. Right now most work is awaiting comprehensive review. A smaller proportion are waiting to author and are likely to be bumped to the next version; it's the stuff waiting for review that seems most pressing. It'd be really good if anyone with a patch in the CF could follow up with an opinion on its readiness and, if appropriate, push it to the next CF. I'll be going through the patch list and following up with my own summaries, but I remain pretty swamped so it'll be a trickle rather than a flood. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress - or lack thereof
Aha, Teodor sent it to the list Dec 28, see http://archives.postgresql.org/message-id/4D1A1677.80300%40sigaev.ru After a month I didn't see any activity on this patch, so I I added it to https://commitfest.postgresql.org/action/patch_view?id=350 Jan 21 Now, I realised it was too late. Added to current commitfest. Oleg On Fri, 4 Feb 2011, Robert Haas wrote: On Fri, Feb 4, 2011 at 10:46 AM, Oleg Bartunov wrote: I don't see btree_gist with knn-support. I'm afraid it'll be forgotten. If you don't see it there, it's because you didn't add it. The deadline for getting your patch into the CommitFest application was January 15th, and several reminders were sent out in advance of that date. Regards, Oleg _ Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru), Sternberg Astronomical Institute, Moscow University, Russia Internet: o...@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(495)939-16-83, +007(495)939-23-83 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress - or lack thereof
On Fri, Feb 4, 2011 at 10:46 AM, Oleg Bartunov wrote: > I don't see btree_gist with knn-support. I'm afraid it'll be forgotten. If you don't see it there, it's because you didn't add it. The deadline for getting your patch into the CommitFest application was January 15th, and several reminders were sent out in advance of that date. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] CommitFest progress - or lack thereof
Robert, I don't see btree_gist with knn-support. I'm afraid it'll be forgotten. Oleg On Fri, 4 Feb 2011, Robert Haas wrote: With ten days left in the current CommitFest, being the last CommitFest for 9.1 development, there are presently 40 patches that are marked either Needs Review or Waiting on Author. The 11 patches that are Waiting on Author are the following: Synchronous Replication, transaction-controlled Recovery Control SQL/MED - postgresql_fdw FDW API Skip validation of Foreign Keys Self-tuning checkpoint sync spread PL/Python explicit subtransactions keeping timestamp of the lasts stats reset Named restore points pg_stat_activity.client_hostname field log_csv_fields ; add current_role log option If you are the author of one of these patches, you need to post an updated patch ASAP, or wait for 9.2. A number of these patches have been sitting for WEEKS without an update. When you post your updated patch (or if by chance you already did), please add a link to the CommitFest application and change the status to Needs Review. Many of these patches likely still need a few more rounds of review before they are committed. If you wait until February 14th at 11:59pm to update them, they're not going to make it in. https://commitfest.postgresql.org/action/commitfest_view/inprogress As for the patches that are marked Needs Review, some people have put their names into the CommitFest application, indicating their intent and commitment to review particular patches, and then have not done so. If you are one of those people, please post your review to the list and update the CommitFest application. If you are a reviewer who has completed all of the reviewing you've previously signed up for, and still want to do more, please consider jumping in on one of the patches that still needs review, and help move the discussion along. Even if you cannot do a full review, please review as much as you can and post your feedback to the list. We need to determine which of these patches are viable candidates for 9.2 and which are not. If you are a patch author and your patch is marked as needing review, please double-check that it still applies and has not bitrotted, and verify that you have responded to all feedback previously given, so that if someone has time to review your patch they can do so productively. Thanks, Regards, Oleg _ Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru), Sternberg Astronomical Institute, Moscow University, Russia Internet: o...@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(495)939-16-83, +007(495)939-23-83 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] CommitFest progress - or lack thereof
With ten days left in the current CommitFest, being the last CommitFest for 9.1 development, there are presently 40 patches that are marked either Needs Review or Waiting on Author. The 11 patches that are Waiting on Author are the following: Synchronous Replication, transaction-controlled Recovery Control SQL/MED - postgresql_fdw FDW API Skip validation of Foreign Keys Self-tuning checkpoint sync spread PL/Python explicit subtransactions keeping timestamp of the lasts stats reset Named restore points pg_stat_activity.client_hostname field log_csv_fields ; add current_role log option If you are the author of one of these patches, you need to post an updated patch ASAP, or wait for 9.2. A number of these patches have been sitting for WEEKS without an update. When you post your updated patch (or if by chance you already did), please add a link to the CommitFest application and change the status to Needs Review. Many of these patches likely still need a few more rounds of review before they are committed. If you wait until February 14th at 11:59pm to update them, they're not going to make it in. https://commitfest.postgresql.org/action/commitfest_view/inprogress As for the patches that are marked Needs Review, some people have put their names into the CommitFest application, indicating their intent and commitment to review particular patches, and then have not done so. If you are one of those people, please post your review to the list and update the CommitFest application. If you are a reviewer who has completed all of the reviewing you've previously signed up for, and still want to do more, please consider jumping in on one of the patches that still needs review, and help move the discussion along. Even if you cannot do a full review, please review as much as you can and post your feedback to the list. We need to determine which of these patches are viable candidates for 9.2 and which are not. If you are a patch author and your patch is marked as needing review, please double-check that it still applies and has not bitrotted, and verify that you have responded to all feedback previously given, so that if someone has time to review your patch they can do so productively. Thanks, -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
