Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Tue, Apr 6, 2010 at 07:29, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Tom Lane t...@sss.pgh.pa.us wrote: - cygwin_conv_to_full_win32_path(cmdLine, buf); + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); Buildfarm member brown_bat didn't like this. Seeing that that's the *only* active cygwin buildfarm member, that's not a good percentage. Hmmm, but avoiding deprecated APIs would be good on the lastest cygwin. How about checking the version with #ifdef? #ifdef __CYGWIN__ /* need to convert to windows path */ +#if CYGWIN_VERSION_DLL_MAJOR = 1007 cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); +#else + cygwin_conv_to_full_win32_path(cmdLine, buf); +#endif strcpy(cmdLine, buf); #endif That seems like the way to do it. Or if it's used in many places, use a #define from one to the other - we don't want those #ifdef's all over the place. Seems cygwin may have deprecated that API a bit early :-), but there's nothing we can do about that. If it's deprecated, they'll eventually delete it... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Any objections for the following fix? - cygwin_conv_to_full_win32_path(cmdLine, buf); + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); Buildfarm member brown_bat didn't like this. Seeing that that's the *only* active cygwin buildfarm member, that's not a good percentage. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On fre, 2010-04-02 at 14:44 -0400, Robert Haas wrote: On Apr 2, 2010, at 12:34 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Josh Berkus j...@agliodbs.com wrote: Robert, do you think you could put up replacement tarballs today? If you don't hear from him soon, perhaps he's traveling: http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php Yeah, sorry, I'm not going to have ssh until Sunday, as previously mentioned. But removing src/Makefile.custom ought to do it. Or perhaps someone else can re-export the tag. I could give it a shot, but a) The files on the FTP server master are not group writable, so I can't overwrite them. (Most are not, apparently a general problem.) b) The tag isn't actually version-stamped. configure/configure.in still say 9.0devel. Maybe it's best to delete everything so the test fest or whatever tomorrow doesn't trip over this. But see a). -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Peter Eisentraut pete...@gmx.net writes: b) The tag isn't actually version-stamped. configure/configure.in still say 9.0devel. Sure, because the tag is on a branch. According to the commit message that went by, Robert did that correctly: http://archives.postgresql.org/pgsql-committers/2010-03/msg00378.php regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Apr 2, 2010, at 6:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: b) The tag isn't actually version-stamped. configure/configure.in still say 9.0devel. Sure, because the tag is on a branch. According to the commit message that went by, Robert did that correctly: http://archives.postgresql.org/pgsql-committers/2010-03/msg00378.php I just took the patch Peter applied for alpha4 and ran it through sed, applied the result, and sanity it. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Tom Lane t...@sss.pgh.pa.us wrote: - cygwin_conv_to_full_win32_path(cmdLine, buf); + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); Buildfarm member brown_bat didn't like this. Seeing that that's the *only* active cygwin buildfarm member, that's not a good percentage. Hmmm, but avoiding deprecated APIs would be good on the lastest cygwin. How about checking the version with #ifdef? #ifdef __CYGWIN__ /* need to convert to windows path */ +#if CYGWIN_VERSION_DLL_MAJOR = 1007 cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); +#else + cygwin_conv_to_full_win32_path(cmdLine, buf); +#endif strcpy(cmdLine, buf); #endif Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Fri, Apr 2, 2010 at 2:44 PM, Robert Haas robertmh...@gmail.com wrote: On Apr 2, 2010, at 12:34 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Josh Berkus j...@agliodbs.com wrote: Robert, do you think you could put up replacement tarballs today? If you don't hear from him soon, perhaps he's traveling: http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php Yeah, sorry, I'm not going to have ssh until Sunday, as previously mentioned. But removing src/Makefile.custom ought to do it. Or perhaps someone else can re-export the tag. I have uploaded corrected tarballs alongside the originals. ftp://developer.postgresql.org/pub/source/9.0alpha5/ ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Tom, Robert, etc. Ok, this issue seems to be specific to some versions of gcc. Note that in testing this nobody enabled any special compile or environment variables of any kind, so if there's a -Werror where it shouldn't be, it's in our code. Succeeds on: Red Hat, gcc 4.4.3 OSX, gcc 4.2.1 Debian, gcc 4.3.2 FreeBSD, gcc 4.2.1 Fails on: Ubuntu, gcc 4.3.3 Ubuntu, gcc 4.4.1 OSX 10.5, gcc 4.0.1* I'd assume this was some kind of Ubuntu thing, except that I got it to fail on OSX as well. Ideas? -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com * fails at: gcc -no-cpp-precomp -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -I../../../../src/include -c -o dbsize.o dbsize.c cc1: warnings being treated as errors dbsize.c: In function ‘pg_relation_filepath’: dbsize.c:577: warning: ‘rnode.spcNode’ may be used uninitialized in this function dbsize.c:577: warning: ‘rnode.dbNode’ may be used uninitialized in this function make[4]: *** [dbsize.o] Error 1 make[3]: *** [adt-recursive] Error 2 make[2]: *** [utils-recursive] Error 2 make[1]: *** [all] Error 2 make: *** [all] Error 2 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Josh Berkus j...@agliodbs.com wrote: Ok, this issue seems to be specific to some versions of gcc. Note that in testing this nobody enabled any special compile or environment variables of any kind, so if there's a -Werror where it shouldn't be, it's in our code. Hi, cygwin also has -Werror in default, and build was failed with a warning: $ uname -a CYGWIN_NT-5.1 name 1.7.2(0.225/5/3) 2010-03-24 21:12 i686 Cygwin gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -DDEF_PGPORT=5432 -I../../. ./src/interfaces/libpq -I../../../src/include -c -o pg_ctl.o pg_ctl.c pg_ctl.c: In function `pgwin32_CommandLine': pg_ctl.c:1083: warning: `cygwin_conv_to_full_win32_path' is deprecated (declared at /usr/include/sys/cygwin.h:52) make[3]: *** [pg_ctl.o] Error 1 Any objections for the following fix? Index: src/bin/pg_ctl/pg_ctl.c === --- src/bin/pg_ctl/pg_ctl.c (HEAD) +++ src/bin/pg_ctl/pg_ctl.c (fixed) @@ -1080,7 +1080,7 @@ #ifdef __CYGWIN__ /* need to convert to windows path */ - cygwin_conv_to_full_win32_path(cmdLine, buf); + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); strcpy(cmdLine, buf); #endif Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Apr 2, 2010, at 2:28 AM, Josh Berkus j...@agliodbs.com wrote: Tom, Robert, etc. Ok, this issue seems to be specific to some versions of gcc. Note that in testing this nobody enabled any special compile or environment variables of any kind, so if there's a -Werror where it shouldn't be, it's in our code. Succeeds on: Red Hat, gcc 4.4.3 OSX, gcc 4.2.1 Debian, gcc 4.3.2 FreeBSD, gcc 4.2.1 Fails on: Ubuntu, gcc 4.3.3 Ubuntu, gcc 4.4.1 OSX 10.5, gcc 4.0.1* I'd assume this was some kind of Ubuntu thing, except that I got it to fail on OSX as well. I can't easily get on line to check this just now, but did I accidentally bundle my Makefile.custom into this tarball? ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On fre, 2010-04-02 at 04:48 -0400, Robert Haas wrote: I can't easily get on line to check this just now, but did I accidentally bundle my Makefile.custom into this tarball? Uhum, if you had followed http://wiki.postgresql.org/wiki/Alpha_release_process then this couldn't have happened. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On tor, 2010-04-01 at 23:28 -0700, Josh Berkus wrote: Fails on: Ubuntu, gcc 4.3.3 Ubuntu, gcc 4.4.1 OSX 10.5, gcc 4.0.1* Ubuntu builds with hardening options by default, which cause several warnings. Not sure about the OSX issue. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Fri, Apr 2, 2010 at 9:48 AM, Robert Haas robertmh...@gmail.com wrote:. I can't easily get on line to check this just now, but did I accidentally bundle my Makefile.custom into this tarball? D'oh! That explains the pain I had building the binaries (mainly the add-ons). We assumed that -Werror was an intentional addition in 9.0a5... -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Apr 2, 2010, at 5:18 AM, Peter Eisentraut pete...@gmx.net wrote: On fre, 2010-04-02 at 04:48 -0400, Robert Haas wrote: I can't easily get on line to check this just now, but did I accidentally bundle my Makefile.custom into this tarball? Uhum, if you had followed http://wiki.postgresql.org/wiki/Alpha_release_process then this couldn't have happened. Forgive me for being a little annoyed here, but I actually did follow that document quite closely. Unfortunately it omits to mention a few key points. What actually happened here is that I discovered that I couldn't run make distcheck on a clean source tree. configure needs to be run first, and the fine documentation makes no mention of what options should be used. So naturally I just ran my dev-configure alias, which also creates a one-line Makefile.custom. Now maybe I should have realized that this was going to lead to bad things happening, but I didn't. The wiki page in fact makes no reference at all to the state that one's source tree should be in when doing all of this; it just didn't occur to me that any random crap I happened to have lying around there was going to get shipped. I'm obviously very sorry for the hassle and frustration caused by this mistake, especially to Dave Page, but hopefully you understand that I was trying rather hard to get this right; and perhaps the Wiki page can also be improved to mention some of these details. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On fre, 2010-04-02 at 06:42 -0400, Robert Haas wrote: Forgive me for being a little annoyed here, but I actually did follow that document quite closely. Unfortunately it omits to mention a few key points. Sorry, I had suspected that you didn't do a clean cvs export. It was a frequent problem in the old days. What actually happened here is that I discovered that I couldn't run make distcheck on a clean source tree. configure needs to be run first, and the fine documentation makes no mention of what options should be used. Doesn't matter. Just ./configure is enough. So naturally I just ran my dev-configure alias, which also creates a one-line Makefile.custom. Now maybe I should have realized that this was going to lead to bad things happening, but I didn't. Ah, well, nothing can guard against that. ;-) The wiki page in fact makes no reference at all to the state that one's source tree should be in when doing all of this; it just didn't occur to me that any random crap I happened to have lying around there was going to get shipped. The state is that after a cvs export. I'm obviously very sorry for the hassle and frustration caused by this mistake, especially to Dave Page, but hopefully you understand that I was trying rather hard to get this right; and perhaps the Wiki page can also be improved to mention some of these details. Please add your findings. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Hi, I use Ubuntu 9.04 (GCC 4.3.3). Build was failed too. I was able to compile with some small correction. All are the one that relates only to the return value of write() and fgets(). (1) src/backend/utils/error/elog.c elog.c: In function 'write_console': elog.c:1698: error: ignoring return value of 'write', declared with attribute warn_unused_result elog.c: In function 'write_pipe_chunks': elog.c:2390: error: ignoring return value of 'write', declared with attribute warn_unused_result elog.c:2399: error: ignoring return value of 'write', declared with attribute warn_unused_result (2) src/interfaces/libpq/fe-connect.c fe-connect.c: In function 'PasswordFromFile': fe-connect.c:4403: error: ignoring return value of 'fgets', declared with attribute warn_unused_result (3) src/port/common.c common.c: In function 'handle_sigint': common.c:247: error: ignoring return value of 'write', declared with attribute warn_unused_result common.c:250: error: ignoring return value of 'write', declared with attribute warn_unused_result common.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result (4) src/bin/psql/prompt.c prompt.c: In function 'get_prompt': prompt.c:255: error: ignoring return value of 'fgets', declared with attribute warn_unused_result Regards, Genie Japo Guys, Hmmm. I appear to have had a compile error with that alpha5 tarball, in elog.c. No special options on compile, except an alternate directory and port. Ubunutu 9.10 server GCC 4.3.3 Tries both: ./configure --with-pgport=5490 --prefix=/usr/local/pgsql/9.0/ and: ./configure --with-pgport=5490 --prefix=/usr/local/pgsql/9.0/ --enable-debug -enable-cassert make[4]: Entering directory `/usr/local/src/postgresql-9.0alpha5/src/backend/utils/error' gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -I../../../../src/include -D_GNU_SOURCE -c -o assert.o assert.c gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -I../../../../src/include -D_GNU_SOURCE -c -o elog.o elog.c cc1: warnings being treated as errors elog.c: In function ‘write_console’: elog.c:1698: error: ignoring return value of ‘write’, declared with attribute warn_unused_result elog.c: In function ‘write_pipe_chunks’: elog.c:2390: error: ignoring return value of ‘write’, declared with attribute warn_unused_result elog.c:2399: error: ignoring return value of ‘write’, declared with attribute warn_unused_result make[4]: *** [elog.o] Error 1 -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Robert, I'm obviously very sorry for the hassle and frustration caused by this mistake, especially to Dave Page, but hopefully you understand that I was trying rather hard to get this right; and perhaps the Wiki page can also be improved to mention some of these details. Bound to happen the first time someone other than Peter did the bundling. Which was one of the points of the Alphas ... to get more people familiar with the process. Anyway, do you think you could put up replacement tarballs today? I'll remove Makefile.custom and see if that fixes what I have ... -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Josh Berkus j...@agliodbs.com wrote: Robert, do you think you could put up replacement tarballs today? If you don't hear from him soon, perhaps he's traveling: http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On Apr 2, 2010, at 12:34 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Josh Berkus j...@agliodbs.com wrote: Robert, do you think you could put up replacement tarballs today? If you don't hear from him soon, perhaps he's traveling: http://archives.postgresql.org/pgsql-hackers/2010-03/msg01298.php Yeah, sorry, I'm not going to have ssh until Sunday, as previously mentioned. But removing src/Makefile.custom ought to do it. Or perhaps someone else can re-export the tag. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Guys, Hmmm. I appear to have had a compile error with that alpha5 tarball, in elog.c. No special options on compile, except an alternate directory and port. Ubunutu 9.10 server GCC 4.3.3 Tries both: ./configure --with-pgport=5490 --prefix=/usr/local/pgsql/9.0/ and: ./configure --with-pgport=5490 --prefix=/usr/local/pgsql/9.0/ --enable-debug -enable-cassert make[4]: Entering directory `/usr/local/src/postgresql-9.0alpha5/src/backend/utils/error' gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -I../../../../src/include -D_GNU_SOURCE -c -o assert.o assert.c gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -Werror -I../../../../src/include -D_GNU_SOURCE -c -o elog.o elog.c cc1: warnings being treated as errors elog.c: In function ‘write_console’: elog.c:1698: error: ignoring return value of ‘write’, declared with attribute warn_unused_result elog.c: In function ‘write_pipe_chunks’: elog.c:2390: error: ignoring return value of ‘write’, declared with attribute warn_unused_result elog.c:2399: error: ignoring return value of ‘write’, declared with attribute warn_unused_result make[4]: *** [elog.o] Error 1 -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
Josh Berkus j...@agliodbs.com writes: Hmmm. I appear to have had a compile error with that alpha5 tarball, in elog.c. No special options on compile, except an alternate directory and port. No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or bleeding-edge anything). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
On 4/1/10 9:57 PM, Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: Hmmm. I appear to have had a compile error with that alpha5 tarball, in elog.c. No special options on compile, except an alternate directory and port. No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or bleeding-edge anything). I didn't actually. Must be set by default on Ubuntu's gcc? (goes looking for a way to disable it ...) -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c
No, you stuck in -Werror. Don't do that on bleeding-edge gcc (or bleeding-edge anything). Found it ... Robert, you stuck a -Werror in the gzip file you uploaded (but not, for some reason, the bzip). -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
