Re: [HACKERS] Compiler warning about overflow in xlog.c

2015-05-23 Thread Tom Lane 
Petr Jelinek p...@2ndquadrant.com writes:
 my compiler complains about overflow in xlog.c.

Yeah, Peter E. reported this yesterday.  Since Heikki didn't do
anything about that yet, I pushed your fix.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Compiler warning about overflow in xlog.c

2015-05-23 Thread Petr Jelinek 

Hi,

my compiler complains about overflow in xlog.c.

There is variable defined as char partialfname[MAXFNAMELEN]; but is used 
as snprintf(partialfname, MAXPGPATH, %s.partial, origfname);


There is no practical issue as the actual filename length is never over 
MAXFNAMELEN even with the .partial suffix but the code should still be 
fixed which is what attached one-line patch does.


--
 Petr Jelinek  http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


xlog-overflow-fix.diff
Description: binary/octet-stream

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers