Re: [HACKERS] Current Sources/UW7.1.1
* Tom Lane [EMAIL PROTECTED] [010101 23:26]: Larry Rosenman [EMAIL PROTECTED] writes: * Tom Lane [EMAIL PROTECTED] [010101 23:16]: [snip] there are a couple of them that I *THINK* have more tuples on one side or the other of the Diff. I'll try and narrow them... (or shouldn't I bother? ) That would certainly be a bug, if so, so do look closer. An easy way to check for such a thing is to grep the regression.diffs file for differences in the "(n rows)" comments appended by psql. Ok, I get to be wrong. The only row difference is our friend random. Never Mind. Maybe regressplan should check for that? Larry regards, tom lane -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
Re: [HACKERS] Current Sources/UW7.1.1
Larry Rosenman [EMAIL PROTECTED] writes: The planregress.sh tests generate errors. Attached is a tar of the planregress directory... Have you examined the diffs to see whether any represent real problems, as opposed to trivial changes in output tuple order? regards, tom lane
RE: [HACKERS] Current Sources/UW7.1.1
No I hadn't. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972 414 9812 (voice) Internet: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 -Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED]] Sent: Monday, January 01, 2001 1:19 PM To: Larry Rosenman Cc: PostgreSQL Hackers List Subject: Re: [HACKERS] Current Sources/UW7.1.1 Larry Rosenman [EMAIL PROTECTED] writes: The planregress.sh tests generate errors. Attached is a tar of the planregress directory... Have you examined the diffs to see whether any represent real problems, as opposed to trivial changes in output tuple order? regards, tom lane
Re: [HACKERS] Current Sources/UW7.1.1
Larry Rosenman [EMAIL PROTECTED] writes: The planregress.sh tests generate errors. Attached is a tar of the planregress directory... Have you examined the diffs to see whether any represent real problems, as opposed to trivial changes in output tuple order? Is the tuple order differences ok? If so, I believe these were just order differences, but... Yes, order differences are OK (except for queries that specify an ORDER BY, of course). Most of the regression test scripts are not so pedantic as to use an ORDER BY for every single SELECT, and so their result tuple orderings are not truly well-defined according to the letter of the SQL spec. In practice, since the regress tests start from a virgin database, the planner should choose the same plans on most or all platforms, and so we usually don't have problems with cross-platform differences in result orderings. (There are some tests in which we've had to insert explicit ORDER BY clauses just to prevent such problems, however.) planregress creates an additional source of order variation by forcing different plan types to be used, so you get some "failures" that have to be validated by inspection. We could eliminate these "failures" by adding more explicit ORDER BYs, but IMHO that would actually make planregress less useful, not more. The ORDER BY clauses would push the planner to favor ordered plans over unordered ones, and thus to some extent defeat the purpose of exercising multiple plan types. Since planregress isn't intended for general-purpose use, only as a test tool for planner hacking, I think it's most useful as-is. But you do have to know how to interpret the output. regards, tom lane
Re: [HACKERS] Current Sources/UW7.1.1
* Tom Lane [EMAIL PROTECTED] [010101 23:16]: [snip] there are a couple of them that I *THINK* have more tuples on one side or the other of the Diff. I'll try and narrow them... (or shouldn't I bother? ) -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
Re: [HACKERS] Current Sources/UW7.1.1
Larry Rosenman [EMAIL PROTECTED] writes: * Tom Lane [EMAIL PROTECTED] [010101 23:16]: [snip] there are a couple of them that I *THINK* have more tuples on one side or the other of the Diff. I'll try and narrow them... (or shouldn't I bother? ) That would certainly be a bug, if so, so do look closer. An easy way to check for such a thing is to grep the regression.diffs file for differences in the "(n rows)" comments appended by psql. regards, tom lane
[HACKERS] Current Sources/UW7.1.1
The planregress.sh tests generate errors. Attached is a tar of the planregress directory... -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 planregress.tar.gz
