[HACKERS] GetOldestWALSendPointer() in header

2010-06-16 Thread Takahiro Itagaki 
Hi,

GetOldestWALSendPointer() is commented out in the source code
with NOT_USED block, but is still declared in the header file.
Should we remove the function prototype from walsender.h ?

[walsender.h]
extern XLogRecPtr GetOldestWALSendPointer(void);

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] GetOldestWALSendPointer() in header

2010-06-16 Thread Tom Lane 
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes:
 GetOldestWALSendPointer() is commented out in the source code
 with NOT_USED block, but is still declared in the header file.
 Should we remove the function prototype from walsender.h ?

Yes, that's our usual convention.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers