Re: [HACKERS] Instructions for adding new catalog

2008-08-03 Thread Gustavo Tonini
Thanks for reply, Tom.
Well, just for documenting the process...
Adding new postgres catalog in 2 little steps:

1)Write catalog header file and save it into src/include/catalog
directory. Hint: copy format from other catalog headers.
2)Add your header file name to variable POSTGRES_BKI_SRCS in file
src/backend/catalog/Makefile

Make, make install, then initdb will create new system catalogs for you.

Gustavo.

On Fri, Aug 1, 2008 at 11:28 AM, Tom Lane [EMAIL PROTECTED] wrote:
 Gustavo Tonini [EMAIL PROTECTED] writes:
 I read the archives, but I can't find the instructions for adding new
 catalogs to the system.

 That's probably because there aren't any.  Look at recent patches
 that added a new catalog to get an idea of what you need to do.
 The enum patch might be a good choice.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Instructions for adding new catalog

2008-08-03 Thread Tom Lane
Gustavo Tonini [EMAIL PROTECTED] writes:
 Well, just for documenting the process...
 Adding new postgres catalog in 2 little steps:

 1)Write catalog header file and save it into src/include/catalog
 directory. Hint: copy format from other catalog headers.
 2)Add your header file name to variable POSTGRES_BKI_SRCS in file
 src/backend/catalog/Makefile

As long as we're documenting ...

* Documenting a new catalog in catalogs.sgml is not considered optional.
* Most likely, your catalog needs some indexes, which should be declared
  in catalog/indexing.h.
* Of course, the reason you are defining a new system catalog is that
  the C code is going to know about it.  So there is a whole lot of
  other stuff you probably need to write: object insertion code,
  object deletion code, lookup code (maybe a new syscache or two).
  Traditionally the lowest-level insertion/deletion code goes into
  catalog/pg_yourcatalog.c, while slightly higher-level code such as
  the implementation of new utility commands to manage this new kind
  of object will go elsewhere.

That's before you get to any actual new functionality...

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Instructions for adding new catalog

2008-08-01 Thread Gustavo Tonini
Hello,
I read the archives, but I can't find the instructions for adding new
catalogs to the system.
Where can I find those instructions? Is there a document about this?

Thanks,
Gustavo.

P.S: Please CC to me on reply

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Instructions for adding new catalog

2008-08-01 Thread Tom Lane
Gustavo Tonini [EMAIL PROTECTED] writes:
 I read the archives, but I can't find the instructions for adding new
 catalogs to the system.

That's probably because there aren't any.  Look at recent patches
that added a new catalog to get an idea of what you need to do.
The enum patch might be a good choice.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers