Re: [HACKERS] Minor improvement in gin_private.h

2014-04-20 Thread Robert Haas
On Fri, Apr 18, 2014 at 10:43 AM, Etsuro Fujita
 wrote:
> The attached improves a comment in gin_private.h a little bit.

Committed also.  That comment should probably be rephrased more
extensively, something like "We use our own versions of
ItemPointerGetBlockNumber and ItemPointerGetOffsetNumber ...".

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Minor improvement in gin_private.h

2014-04-18 Thread Etsuro Fujita
The attached improves a comment in gin_private.h a little bit.

Thanks,

Best regards,
Etsuro Fujita
diff --git a/src/include/access/gin_private.h b/src/include/access/gin_private.h
index 81a3bee..3aa4276 100644
--- a/src/include/access/gin_private.h
+++ b/src/include/access/gin_private.h
@@ -130,7 +130,7 @@ typedef struct GinMetaPageData
 #define GinPageRightMost(page) ( GinPageGetOpaque(page)->rightlink == 
InvalidBlockNumber)
 
 /*
- * We use our own ItemPointerGet(BlockNumber|GetOffsetNumber)
+ * We use our own ItemPointerGet(BlockNumber|OffsetNumber)
  * to avoid Asserts, since sometimes the ip_posid isn't "valid"
  */
 #define GinItemPointerGetBlockNumber(pointer) \

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers