Re: [HACKERS] Missing comment for create_modifytable_path

[Etsuro Fujita]

On 2017/06/23 2:53, Robert Haas wrote:

On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
 wrote:

While working on adding support for tuple routing for foreign partitions, I
noticed that in create_modifytable_path, we forgot to add a comment on its
new argument 'partitioned_rels'.  Attached a patch for including that in the
comments for that function.


Committed with a slight adjustment.


Thank you for committing this patch (and another one)!

Best regards,
Etsuro Fujita



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Missing comment for create_modifytable_path

[Robert Haas]

On Thu, Jun 15, 2017 at 4:40 AM, Etsuro Fujita
 wrote:
> While working on adding support for tuple routing for foreign partitions, I
> noticed that in create_modifytable_path, we forgot to add a comment on its
> new argument 'partitioned_rels'.  Attached a patch for including that in the
> comments for that function.

Committed with a slight adjustment.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Missing comment for create_modifytable_path

[Etsuro Fujita]

While working on adding support for tuple routing for foreign 
partitions, I noticed that in create_modifytable_path, we forgot to add 
a comment on its new argument 'partitioned_rels'.  Attached a patch for 
including that in the comments for that function.


Best regards,
Etsuro Fujita
diff --git a/src/backend/optimizer/util/pathnode.c 
b/src/backend/optimizer/util/pathnode.c
index ec4a093..46bc1df 100644
--- a/src/backend/optimizer/util/pathnode.c
+++ b/src/backend/optimizer/util/pathnode.c
@@ -3159,6 +3159,8 @@ create_lockrows_path(PlannerInfo *root, RelOptInfo *rel,
  * 'operation' is the operation type
  * 'canSetTag' is true if we set the command tag/es_processed
  * 'nominalRelation' is the parent RT index for use of EXPLAIN
+ * 'partitioned_rels' is an integer list of RT indexes of non-leaf tables in
+ * the partition tree if UPDATE/DELETE to a partitioned table, 
else NIL
  * 'resultRelations' is an integer list of actual RT indexes of target rel(s)
  * 'subpaths' is a list of Path(s) producing source data (one per rel)
  * 'subroots' is a list of PlannerInfo structs (one per rel)

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers