Re: [HACKERS] Patch for option in pg_resetxlog for restore from WAL files
On Tuesday, September 25, 2012 6:27 PM Simon Riggs wrote : > On 24 September 2012 04:00, Heikki Linnakangas > wrote: > > On 18.07.2012 16:47, Amit kapila wrote: > >> > >> Patch implementing the design in below mail chain is attached with > this > >> mail. > > > > > > This patch copies the ReadRecord() function and a bunch of related > functions > > from xlog.c into pg_resetxlog.c. There's a separate patch in the > current > > commitfest to make that code reusable, without having to copy-paste > it to > > every tool that wants to parse the WAL. See > > https://commitfest.postgresql.org/action/patch_view?id=860. This > patch > > should be refactored to make use of that framework, as soon as it's > > committed. > > Agreed, moving to next commitfest. > > Amit, suggest review of the patch that this now depends upon. Earlier I thought, I will try to finish in this CommitFest if the XLogReader Patch gets committed by next week. However if you feel it is better to work it for next CommitFest, I shall do it that way. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Patch for option in pg_resetxlog for restore from WAL files
On 24 September 2012 04:00, Heikki Linnakangas wrote: > On 18.07.2012 16:47, Amit kapila wrote: >> >> Patch implementing the design in below mail chain is attached with this >> mail. > > > This patch copies the ReadRecord() function and a bunch of related functions > from xlog.c into pg_resetxlog.c. There's a separate patch in the current > commitfest to make that code reusable, without having to copy-paste it to > every tool that wants to parse the WAL. See > https://commitfest.postgresql.org/action/patch_view?id=860. This patch > should be refactored to make use of that framework, as soon as it's > committed. Agreed, moving to next commitfest. Amit, suggest review of the patch that this now depends upon. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Patch for option in pg_resetxlog for restore from WAL files
> On Monday, September 24, 2012 2:30 PM Heikki Linnakangas wrote: > On 18.07.2012 16:47, Amit kapila wrote: > > Patch implementing the design in below mail chain is attached with > this mail. > > This patch copies the ReadRecord() function and a bunch of related > functions from xlog.c into pg_resetxlog.c. There's a separate patch in > the current commitfest to make that code reusable, without having to > copy-paste it to every tool that wants to parse the WAL. See > https://commitfest.postgresql.org/action/patch_view?id=860. This patch > should be refactored to make use of that framework, as soon as it's > committed. Sure. Thanks for the feedback. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Patch for option in pg_resetxlog for restore from WAL files
On 18.07.2012 16:47, Amit kapila wrote: Patch implementing the design in below mail chain is attached with this mail. This patch copies the ReadRecord() function and a bunch of related functions from xlog.c into pg_resetxlog.c. There's a separate patch in the current commitfest to make that code reusable, without having to copy-paste it to every tool that wants to parse the WAL. See https://commitfest.postgresql.org/action/patch_view?id=860. This patch should be refactored to make use of that framework, as soon as it's committed. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
