[HACKERS] Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

[Fujii Masao]

On Fri, Jun 4, 2010 at 7:17 AM, Tom Lane t...@postgresql.org wrote:
 Log Message:
 ---
 Add current WAL end (as seen by walsender, ie, GetWriteRecPtr() result)
 and current server clock time to SR data messages.  These are not currently
 used on the slave side but seem likely to be useful in future, and it'd be
 better not to change the SR protocol after release.  Per discussion.
 Also do some minor code review and cleanup on walsender.c, and improve the
 protocol documentation.

This commit changed walsender so that it doesn't call set_ps_display() if
update_process_title = off. On the other hand, walreceiver doesn't check
update_process_title. Though this check might not be required since it's
within set_ps_display(), we should do that for the sake of consistency?
I attached the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


walrcv_update_process_title_v1.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add current WAL end (as seen by walsender, ie, GetWriteRecPtr()

[Tom Lane]

Fujii Masao masao.fu...@gmail.com writes:
 This commit changed walsender so that it doesn't call set_ps_display() if
 update_process_title = off.

Yeah.  The idea is to not waste time on a useless snprintf() call when the
GUC is turned off.

 On the other hand, walreceiver doesn't check
 update_process_title. Though this check might not be required since it's
 within set_ps_display(), we should do that for the sake of consistency?

Seems reasonable to make the same minor optimization on that side.
Will commit.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers