Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
On 5/28/14, 7:02 PM, Andres Freund wrote:
That's a good idea. What i've been thinking about is to add
-Wno-deprecated to the bison rule in the interim. Maybe after a
configure test for the option. All deprecation warnings so far seem to
be pretty unhelpful.
Here is a patch.
diff --git a/config/programs.m4 b/config/programs.m4
index fd3a9a4..5570e55 100644
--- a/config/programs.m4
+++ b/config/programs.m4
@@ -23,6 +23,10 @@ if test $BISON; then
*** Bison version 1.875 or later is required, but this is $pgac_bison_version.])
BISON=
fi
+ if echo $pgac_bison_version | $AWK '{ if ([$]4 = 3) exit 0; else exit 1;}'
+ then
+BISONFLAGS=$BISONFLAGS -Wno-deprecated
+ fi
fi
if test -z $BISON; then
diff --git a/configure b/configure
index 3663e50..5499d56 100755
--- a/configure
+++ b/configure
@@ -7075,6 +7075,10 @@ $as_echo $as_me: WARNING:
*** Bison version 1.875 or later is required, but this is $pgac_bison_version. 2;}
BISON=
fi
+ if echo $pgac_bison_version | $AWK '{ if ($4 = 3) exit 0; else exit 1;}'
+ then
+BISONFLAGS=$BISONFLAGS -Wno-deprecated
+ fi
fi
if test -z $BISON; then
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
On 2014-05-29 08:33:05 -0400, Peter Eisentraut wrote: On 5/28/14, 7:02 PM, Andres Freund wrote: That's a good idea. What i've been thinking about is to add -Wno-deprecated to the bison rule in the interim. Maybe after a configure test for the option. All deprecation warnings so far seem to be pretty unhelpful. Here is a patch. FWIW, I vote for applying something like it. It seems better to collect the -Wno-deprecated in one place (i.e. configure) instead of having it in every developer's Makefile.custom. The latter will be harder to get rid of. I'd add a comment about why it's been added though. I won't remember why at least... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
Andres Freund and...@2ndquadrant.com writes: FWIW, I vote for applying something like it. It seems better to collect the -Wno-deprecated in one place (i.e. configure) instead of having it in every developer's Makefile.custom. The latter will be harder to get rid of. Yeah, that's a good point. I'd add a comment about why it's been added though. I won't remember why at least... +1 regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
On Thu, May 29, 2014 at 08:33:05AM -0400, Peter Eisentraut wrote: On 5/28/14, 7:02 PM, Andres Freund wrote: That's a good idea. What i've been thinking about is to add -Wno-deprecated to the bison rule in the interim. Maybe after a configure test for the option. All deprecation warnings so far seem to be pretty unhelpful. Here is a patch. Does this need a comment indicating why it's needed and when it can be removed? Have a nice day, -- Martijn van Oosterhout klep...@svana.org http://svana.org/kleptog/ He who writes carelessly confesses thereby at the very outset that he does not attach much importance to his own thoughts. -- Arthur Schopenhauer signature.asc Description: Digital signature
[HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
On 2014-05-28 18:52:22 -0400, Tom Lane wrote: I guess we have to revert this Looks like it. and IMO we should also lobby the Bison people to not emit the deprecation warnings yet. That's a good idea. What i've been thinking about is to add -Wno-deprecated to the bison rule in the interim. Maybe after a configure test for the option. All deprecation warnings so far seem to be pretty unhelpful. Btw, the bison release process and documentation suck. Majorly. The most efficient way to learn about changes seems to be to look at the git repository. Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.
On 2014-05-28 19:12:44 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-05-28 18:52:22 -0400, Tom Lane wrote: and IMO we should also lobby the Bison people to not emit the deprecation warnings yet. That's a good idea. What i've been thinking about is to add -Wno-deprecated to the bison rule in the interim. Maybe after a configure test for the option. All deprecation warnings so far seem to be pretty unhelpful. Meh. If we just hide them permanently, we're likely to be blindsided somewhere down the road when they turn a deprecation into an error. I think some bleeding edge buildfarm animal will warn us soon enough. It's not as if we're able to do much about the deprecations as is without breaking with older releases. What I was wondering about was if we could modify the .y files when building with a pre-2.4 bison. It'd be easy enough to fix this with sed, say. .oO(m4). Should be doable and might actually be interesting for a couple of other things. I think I'll just stick a BISONFLAGS=+ -Wno-deprecated in my Makefile.custom for now. I.e. I am not volunteering. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
