[HACKERS] Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Robert Haas
On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs si...@2ndquadrant.com wrote:
 Separate messages for standby replies and hot standby feedback.
 Allow messages to be sent at different times, and greatly reduce
 the frequency of hot standby feedback. Refactor to allow additional
 message types.

You could refactor this some more to avoid calling
GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but
I'm not sure whether it's worth it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Simon Riggs
On Fri, 2011-02-18 at 07:11 -0500, Robert Haas wrote:
 On Fri, Feb 18, 2011 at 6:34 AM, Simon Riggs si...@2ndquadrant.com wrote:
  Separate messages for standby replies and hot standby feedback.
  Allow messages to be sent at different times, and greatly reduce
  the frequency of hot standby feedback. Refactor to allow additional
  message types.
 
 You could refactor this some more to avoid calling
 GetCurrentTimestamp() and TimestampDifferenceExceeds() twice each, but
 I'm not sure whether it's worth it.

Thanks for the observation.

-- 
 Simon Riggs   http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services
 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers