[HACKERS] Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.

2008-03-17 Thread Alvaro Herrera
Magnus Hagander wrote:
 Log Message:
 ---
 Some cleanups of enum-guc code, per comments from Tom.

These bits seem to have broken --describe-config:

LC_ALL=C postmaster --describe-config  /dev/null
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type
internal error: unrecognized run-time parameter type

(Perhaps they were already broken in the previous patch, not sure).

-- 
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.

2008-03-17 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes:
 These bits seem to have broken --describe-config:
 (Perhaps they were already broken in the previous patch, not sure).

It was already broken :-(.  Not sure how both Magnus and I missed
the switch in help_config.c --- I know I grepped for references to
the PGC_xxx enum constants, and I suppose he did too.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom.

2008-03-17 Thread Magnus Hagander

Tom Lane wrote:

Alvaro Herrera [EMAIL PROTECTED] writes:

These bits seem to have broken --describe-config:
(Perhaps they were already broken in the previous patch, not sure).


It was already broken :-(.  Not sure how both Magnus and I missed
the switch in help_config.c --- I know I grepped for references to
the PGC_xxx enum constants, and I suppose he did too.


Yeah, that's what I did, and I have no idea how I missed it.

Will fix.

//Magnus

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers