Re: [HACKERS] Warning in views.c

[Robert Haas]

On Mon, Jan 16, 2012 at 3:47 PM, Magnus Hagander mag...@hagander.net wrote:
 Seem 1575fbcb caused this warning:

 view.c: In function ‘DefineVirtualRelation’:
 view.c:105:6: warning: variable ‘namespaceId’ set but not used
 [-Wunused-but-set-variable]

 Attached seems to be the easy fix - or am I missing something obvious?

No, I think you nailed it.  There is some more refactoring that should
be done there, I think, but until it is, we don't need that return
value for anything...

Thanks for fixing it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Warning in views.c

[Magnus Hagander]

Seem 1575fbcb caused this warning:

view.c: In function ‘DefineVirtualRelation’:
view.c:105:6: warning: variable ‘namespaceId’ set but not used
[-Wunused-but-set-variable]

Attached seems to be the easy fix - or am I missing something obvious?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/
diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c
index c3520ae..f895488 100644
--- a/src/backend/commands/view.c
+++ b/src/backend/commands/view.c
@@ -102,7 +102,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 	  List *options)
 {
 	Oid			viewOid;
-	Oid			namespaceId;
 	LOCKMODE	lockmode;
 	CreateStmt *createStmt = makeNode(CreateStmt);
 	List	   *attrList;
@@ -167,8 +166,7 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
 	 * namespace is temporary.
 	 */
 	lockmode = replace ? AccessExclusiveLock : NoLock;
-	namespaceId =
-		RangeVarGetAndCheckCreationNamespace(relation, lockmode, viewOid);
+	(void) RangeVarGetAndCheckCreationNamespace(relation, lockmode, viewOid);
 
 	if (OidIsValid(viewOid)  replace)
 	{

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers