[HACKERS] code cleanup: ss_currentScanDesc

2010-02-25 Thread Takahiro Itagaki
ScanState.ss_currentScanDesc is currently used by only SeqScan and
BitmapHeapScan. Other scan nodes don't use the field at all, right?

Can we move the field into SeqScanState and BitmapHeapScanState
for code cleanup? This change will not improve any performance,
but it can clear up what we do actually.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center


ss_currentScanDesc_20100226.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] code cleanup: ss_currentScanDesc

2010-02-25 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes:
 ScanState.ss_currentScanDesc is currently used by only SeqScan and
 BitmapHeapScan. Other scan nodes don't use the field at all, right?

 Can we move the field into SeqScanState and BitmapHeapScanState
 for code cleanup? This change will not improve any performance,
 but it can clear up what we do actually.

Why is that an improvement?  ISTM that the fact that other scan types
don't use a scandesc pointer is the oddity, not that these do.  You'd
also be making it harder to share any code between these two cases.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers