Re: [HACKERS] log_line_info plan

2004-02-18 Thread Andrew Dunstan
Tom Lane said:
> Andrew Dunstan <[EMAIL PROTECTED]> writes:
>> I am about to redo the patch that would allow tagging of log lines
>> with  info via a printf-style string.
>
>> Any comments or suggestions before I start?
>
> I think Bruce already applied the previous version of your patch.

Not that I can see. He did just apply the log_disconnections patch, but I
had split that out from this facility - back in August I did them together
in one never-applied patch.

> No
> problem with yanking it out for a better version --- but please supply
> the update as a diff from CVS tip.  Fewer chances for error that way.
>

I always do a CVS update before making a patch (unless I forget).

cheers

andrew



---(end of broadcast)---
TIP 8: explain analyze is your friend


Re: [HACKERS] log_line_info plan

2004-02-17 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes:
> I am about to redo the patch that would allow tagging of log lines with 
> info via a printf-style string.

> Any comments or suggestions before I start?

I think Bruce already applied the previous version of your patch.  No
problem with yanking it out for a better version --- but please supply
the update as a diff from CVS tip.  Fewer chances for error that way.

regards, tom lane

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [HACKERS] log_line_info plan

2004-02-17 Thread Andrew Dunstan


Joshua D. Drake wrote:

Andrew Dunstan wrote:

I am about to redo the patch that would allow tagging of log lines 
with info via a printf-style string.

Current plans are to call the config parameter "log_line_info" and 
implement the following escapes:

%U = user
%D = database
%T = timestamp
%P = pid
%L = session log line number
%C = sessionid cookie (hex encoded session start time + pid)
%S = session start timestamp
%I = Command Tag (e.g. "CREATE TABLE")
Any comments or suggestions before I start?


My be kind of cool if we a a duration variable in there, especially if 
combined with %I

Duration of what?

This patch will not generate a single extra log line. It is intended to 
tag existing log lines, particularly to make creating log analysis tools 
and loading logs to tables easier.

cheers

andrew



---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


Re: [HACKERS] log_line_info plan

2004-02-17 Thread Bruce Momjian
Joshua D. Drake wrote:
> Andrew Dunstan wrote:
> > 
> > I am about to redo the patch that would allow tagging of log lines with 
> > info via a printf-style string.
> > 
> > Current plans are to call the config parameter "log_line_info" and 
> > implement the following escapes:
> > 
> > %U = user
> > %D = database
> > %T = timestamp
> > %P = pid
> > %L = session log line number
> > %C = sessionid cookie (hex encoded session start time + pid)
> > %S = session start timestamp
> > %I = Command Tag (e.g. "CREATE TABLE")
> > 
> > Any comments or suggestions before I start?
> 
> My be kind of cool if we a a duration variable in there, especially if 
> combined with %I

Duration of what?  We could show the duration within the session, but we
don't know the query duration because we print this before the query is
executed, so folks can look in the logs to see what is currently
running.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


Re: [HACKERS] log_line_info plan

2004-02-17 Thread Joshua D. Drake
Andrew Dunstan wrote:
I am about to redo the patch that would allow tagging of log lines with 
info via a printf-style string.

Current plans are to call the config parameter "log_line_info" and 
implement the following escapes:

%U = user
%D = database
%T = timestamp
%P = pid
%L = session log line number
%C = sessionid cookie (hex encoded session start time + pid)
%S = session start timestamp
%I = Command Tag (e.g. "CREATE TABLE")
Any comments or suggestions before I start?
My be kind of cool if we a a duration variable in there, especially if 
combined with %I

J



cheers

andrew



---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
 subscribe-nomail command to [EMAIL PROTECTED] so that your
 message can get through to the mailing list cleanly


--
Command Prompt, Inc., home of Mammoth PostgreSQL - S/ODBC and S/JDBC
Postgresql support, programming shared hosting and dedicated hosting.
+1-503-667-4564 - [EMAIL PROTECTED] - http://www.commandprompt.com
Mammoth PostgreSQL Replicator. Integrated Replication for PostgreSQL
begin:vcard
fn:Joshua D. Drake
n:Drake;Joshua D.
org:Command Prompt, Inc.
adr:;;PO Box 215;Cascade Locks;Oregon;97014;USA
email;internet:[EMAIL PROTECTED]
title:Consultant
tel;work:503-667-4564
tel;fax:503-210-0034
note:Command Prompt, Inc. is the largest and oldest US based commercial PostgreSQL support provider. We  provide the only commercially viable integrated PostgreSQL replication solution, but also custom programming, and support. We authored  the book Practical PostgreSQL, the procedural language plPHP, and adding trigger capability to plPerl.
x-mozilla-html:FALSE
url:http://www.commandprompt.com/
version:2.1
end:vcard


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


[HACKERS] log_line_info plan

2004-02-17 Thread Andrew Dunstan
I am about to redo the patch that would allow tagging of log lines with 
info via a printf-style string.

Current plans are to call the config parameter "log_line_info" and 
implement the following escapes:

%U = user
%D = database
%T = timestamp
%P = pid
%L = session log line number
%C = sessionid cookie (hex encoded session start time + pid)
%S = session start timestamp
%I = Command Tag (e.g. "CREATE TABLE")
Any comments or suggestions before I start?

cheers

andrew



---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
 subscribe-nomail command to [EMAIL PROTECTED] so that your
 message can get through to the mailing list cleanly