[HACKERS] nicer error out in initdb?

2006-01-05 Thread Andrew Dunstan


If we find at the bottom of test_config_settings() that we have not been
able to run successfully at all (i.e. status != 0 at about line 1183 of
initdb.c) is there any point in continuing? Don't we know that we are
bound to fail at the template1 creation stage? Maybe we should just exit
nicely when we do know this.

cheers

andrew


---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [HACKERS] nicer error out in initdb?

2006-01-05 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes:
 If we find at the bottom of test_config_settings() that we have not been
 able to run successfully at all (i.e. status != 0 at about line 1183 of
 initdb.c) is there any point in continuing? Don't we know that we are
 bound to fail at the template1 creation stage? Maybe we should just exit
 nicely when we do know this.

Nope: since we've been suppressing stderr, exit nicely here would
translate as refuse to provide any information about the problem.
The existing behavior is just fine.

regards, tom lane

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org